MIME-Version: 1.0
References: <qtclihmrkq67ach3xjxyi4qcksstin5qxwsnkqefkmotxwh4g6@ae2bj6jvcmry>
 <B2FCB6A7-10C4-416D-BA22-240E9FCDCE18@yesql.se>
 <CAOYmi+n4U_g+k1Bfs2eavJdps0qQj3HFDa5i3V1c0m3CLYUWhA@mail.gmail.com>
 <BA41032F-217B-4BDE-9F16-4D237B63DA33@yesql.se>
 <CAOYmi+k6K6VKTZLPtQLHnoSSMRZfH_=x6bHRUC3zf1F9kjyb1Q@mail.gmail.com>
 <fcaddr2zt4q7ee5mm7vctb723pcgfjpyo2hnhjhgae2nysobjf@epjk3wl4i2ck>
 <CAOYmi+mGZ5H+k_Y-ascgK7X9snAGdBUOuc=FZRxu6gnB_mjFFQ@mail.gmail.com>
 <52EEC73C-5887-43F0-848B-DF515DCDFBBF@yesql.se>
In-Reply-To: <52EEC73C-5887-43F0-848B-DF515DCDFBBF@yesql.se>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Fri, 5 Jun 2026 12:06:27 -0700
Message-ID: 
 <CAOYmi+kKqSrU5c8D60rgSj6ybiNwsZkxgTJhef+w0-mRpw=m0A@mail.gmail.com>
Subject: Re: oauth integer overflow
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Andres Freund <andres@anarazel.de>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000049074c0653865cc8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAOYmi%2BkKqSrU5c8D60rgSj6ybiNwsZkxgTJhef%2Bw0-mRpw%3Dm0A%40mail.gmail.com>
Precedence: bulk

--00000000000049074c0653865cc8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 23, 2026 at 11:31=E2=80=AFAM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> Attached. The static_assert for the millisecond calculation is the
> only part I don't really like, but doing an overflow check on a
> calculation that can't overflow int64 is even more verbose/wasteful.

I was preparing to commit this for beta1 last week, and I realized
that I've changed my tune. With all the recent backports of overflow
checks, I think I need to be reaching for them by default, especially
in a non-performance-critical path.

v2 rewrites that part with a checked multiplication, which removes any
need for a static_assert complication.

On Tue, Apr 28, 2026 at 4:18=E2=80=AFAM Daniel Gustafsson <daniel@yesql.se>=
 wrote:
> When teading "disabled timer" I interpret that as a timer which is 0 and =
has no
> interval (which might be due to not being a native speaker), but what it
> actually describes is an interval which (in practice) never ends.  Perhap=
s it
> could be phrased more like "for most people is going to be equivalent to =
a
> never ending interval".

This has been completely rewritten now; see what you think.

Thanks!
--Jacob

--00000000000049074c0653865cc8
Content-Type: application/octet-stream;
	name="v2-0001-libpq-oauth-Avoid-overflow-for-very-large-interva.patch"
Content-Disposition: attachment;
	filename="v2-0001-libpq-oauth-Avoid-overflow-for-very-large-interva.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mq1ao2yd0>
X-Attachment-Id: f_mq1ao2yd0

RnJvbSBkNmQzYTg1MWU3M2ZlZGUzYjNkNjAxZjczNWUwOTlkMzIwNmM1Y2ZmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNvYiBDaGFtcGlvbiA8amNoYW1waW9uQHBvc3RncmVzcWwu
b3JnPgpEYXRlOiBGcmksIDI5IE1heSAyMDI2IDE2OjIxOjQ2IC0wNzAwClN1YmplY3Q6IFtQQVRD
SCB2Ml0gbGlicHEtb2F1dGg6IEF2b2lkIG92ZXJmbG93IGZvciB2ZXJ5IGxhcmdlIGludGVydmFs
cwoKVGhlIHNsb3dfZG93biBpbnRlcnZhbCBwYXJzaW5nIGNvZGUgY2hlY2tzIGV4cGxpY2l0bHkg
Zm9yIG92ZXJmbG93LCBidXQKc2luY2UgaXQgZG9lcyB0aGF0IGFmdGVyIHRoZSBzaWduZWQgb3Zl
cmZsb3cgaGFzIGFscmVhZHkgb2NjdXJyZWQsIHdlCmVuZCB1cCBpbnZpdGluZyB1bmRlZmluZWQg
YmVoYXZpb3IgZnJvbSB0aGUgY29tcGlsZXIgYW55d2F5LgoKVXNlIGNoZWNrZWQgYXJpdGhtZXRp
YyBpbnN0ZWFkLiBzZXRfdGltZXIoKSB0YWtlcyBhIGxvbmcgaW50IGluIG9yZGVyIHRvCmludGVy
ZmFjZSBuaWNlbHkgd2l0aCBsaWJjdXJsLCBzbyB1c2UgYW4gaW50MzIgYXMgdGhlIGludGVydmFs
IGNvdW50ZXIKYW5kIGNsYW1wIHRvIExPTkdfTUFYIGR1cmluZyBjb252ZXJzaW9uIHRvIG1pbGxp
c2Vjb25kcy4KCkJhY2twYXRjaCB0byAxOCwgd2hlcmUgbGlicHEtb2F1dGggd2FzIGludHJvZHVj
ZWQuCgpSZXBvcnRlZC1ieTogQW5kcmVzIEZyZXVuZCA8YW5kcmVzQGFuYXJhemVsLmRlPgpSZXZp
ZXdlZC1ieTogRGFuaWVsIEd1c3RhZnNzb24gPGRhbmllbEB5ZXNxbC5zZT4KRGlzY3Vzc2lvbjog
aHR0cHM6Ly9wb3N0Z3IuZXMvbS9xdGNsaWhtcmtxNjdhY2gzeGp4eWk0cWNrc3N0aW41cXh3c25r
cWVma21vdHh3aDRnNiU0MGFlMmJqNmp2Y21yeQpCYWNrcGF0Y2gtdGhyb3VnaDogMTgKLS0tCiBz
cmMvaW50ZXJmYWNlcy9saWJwcS1vYXV0aC9vYXV0aC1jdXJsLmMgfCAzNSArKysrKysrKysrKysr
KysrKystLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRp
b25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2ludGVyZmFjZXMvbGlicHEtb2F1dGgvb2F1dGgtY3Vy
bC5jIGIvc3JjL2ludGVyZmFjZXMvbGlicHEtb2F1dGgvb2F1dGgtY3VybC5jCmluZGV4IDdiYTc1
ZmM2ZDA0Li4yNjAxMzcyOTFjYiAxMDA2NDQKLS0tIGEvc3JjL2ludGVyZmFjZXMvbGlicHEtb2F1
dGgvb2F1dGgtY3VybC5jCisrKyBiL3NyYy9pbnRlcmZhY2VzL2xpYnBxLW9hdXRoL29hdXRoLWN1
cmwuYwpAQCAtMjgsNiArMjgsNyBAQAogI2Vycm9yIGxpYnBxLW9hdXRoIGlzIG5vdCBzdXBwb3J0
ZWQgb24gdGhpcyBwbGF0Zm9ybQogI2VuZGlmCiAKKyNpbmNsdWRlICJjb21tb24vaW50LmgiCiAj
aW5jbHVkZSAiY29tbW9uL2pzb25hcGkuaCIKICNpbmNsdWRlICJtYi9wZ193Y2hhci5oIgogI2lu
Y2x1ZGUgIm9hdXRoLWN1cmwuaCIKQEAgLTEzNiw3ICsxMzcsNyBAQCBzdHJ1Y3QgZGV2aWNlX2F1
dGh6CiAKIAkvKiBGaWVsZHMgYmVsb3cgYXJlIHBhcnNlZCBmcm9tIHRoZSBjb3JyZXNwb25kaW5n
IHN0cmluZyBhYm92ZS4gKi8KIAlpbnQJCQlleHBpcmVzX2luOwotCWludAkJCWludGVydmFsOwor
CWludDMyCQlpbnRlcnZhbDsKIH07CiAKIHN0YXRpYyB2b2lkCkBAIC0xMDIwLDcgKzEwMjEsNyBA
QCBwYXJzZV9qc29uX251bWJlcihjb25zdCBjaGFyICpzKQogICogZXhwZW5zaXZlIG5ldHdvcmsg
cG9sbGluZyBsb29wLikgVGVzdHMgbWF5IHJlbW92ZSB0aGUgbG93ZXIgYm91bmQgd2l0aAogICog
UEdPQVVUSERFQlVHLCBmb3IgaW1wcm92ZWQgcGVyZm9ybWFuY2UuCiAgKi8KLXN0YXRpYyBpbnQK
K3N0YXRpYyBpbnQzMgogcGFyc2VfaW50ZXJ2YWwoc3RydWN0IGFzeW5jX2N0eCAqYWN0eCwgY29u
c3QgY2hhciAqaW50ZXJ2YWxfc3RyKQogewogCWRvdWJsZQkJcGFyc2VkOwpAQCAtMTAzMSw4ICsx
MDMyLDggQEAgcGFyc2VfaW50ZXJ2YWwoc3RydWN0IGFzeW5jX2N0eCAqYWN0eCwgY29uc3QgY2hh
ciAqaW50ZXJ2YWxfc3RyKQogCWlmIChwYXJzZWQgPCAxKQogCQlyZXR1cm4gKGFjdHgtPmRlYnVn
X2ZsYWdzICYgT0FVVEhERUJVR19VTlNBRkVfRE9TX0VORFBPSU5UKSA/IDAgOiAxOwogCi0JZWxz
ZSBpZiAocGFyc2VkID49IElOVF9NQVgpCi0JCXJldHVybiBJTlRfTUFYOworCWVsc2UgaWYgKHBh
cnNlZCA+PSBJTlQzMl9NQVgpCisJCXJldHVybiBJTlQzMl9NQVg7CiAKIAlyZXR1cm4gcGFyc2Vk
OwogfQpAQCAtMjYyMCwxMCArMjYyMSw3IEBAIGhhbmRsZV90b2tlbl9yZXNwb25zZShzdHJ1Y3Qg
YXN5bmNfY3R4ICphY3R4LCBjaGFyICoqdG9rZW4pCiAJICovCiAJaWYgKHN0cmNtcChlcnItPmVy
cm9yLCAic2xvd19kb3duIikgPT0gMCkKIAl7Ci0JCWludAkJCXByZXZfaW50ZXJ2YWwgPSBhY3R4
LT5hdXRoei5pbnRlcnZhbDsKLQotCQlhY3R4LT5hdXRoei5pbnRlcnZhbCArPSA1OwotCQlpZiAo
YWN0eC0+YXV0aHouaW50ZXJ2YWwgPCBwcmV2X2ludGVydmFsKQorCQlpZiAocGdfYWRkX3MzMl9v
dmVyZmxvdyhhY3R4LT5hdXRoei5pbnRlcnZhbCwgNSwgJmFjdHgtPmF1dGh6LmludGVydmFsKSkK
IAkJewogCQkJYWN0eF9lcnJvcihhY3R4LCAic2xvd19kb3duIGludGVydmFsIG92ZXJmbG93Iik7
CiAJCQlnb3RvIHRva2VuX2NsZWFudXA7CkBAIC0yOTQ5LDggKzI5NDcsMjUgQEAgcGdfZmVfcnVu
X29hdXRoX2Zsb3dfaW1wbChQR2Nvbm4gKmNvbm4sIFBHb2F1dGhCZWFyZXJSZXF1ZXN0VjIgKnJl
cXVlc3QsCiAJCQkJICogV2FpdCBmb3IgdGhlIHJlcXVpcmVkIGludGVydmFsIGJlZm9yZSBpc3N1
aW5nIHRoZSBuZXh0CiAJCQkJICogcmVxdWVzdC4KIAkJCQkgKi8KLQkJCQlpZiAoIXNldF90aW1l
cihhY3R4LCBhY3R4LT5hdXRoei5pbnRlcnZhbCAqIDEwMDApKQotCQkJCQlnb3RvIGVycm9yX3Jl
dHVybjsKKwkJCQl7CisJCQkJCS8qCisJCQkJCSAqIEF2b2lkIG92ZXJmbG93IG9mIGxvbmcgaW50
LiAoQnkgdGhlIHRpbWUgd2UgcmVhY2gKKwkJCQkJICogTE9OR19NQVggbWlsbGlzZWNvbmRzIC0t
IDI0IGRheXMgb24gMzItYml0IHBsYXRmb3JtcyAtLQorCQkJCQkgKiBjb250aW51aW5nIHRvIGhv
bm9yIHNsb3dfZG93biByZXF1ZXN0cyBzZWVtcyBwcmV0dHkKKwkJCQkJICogcG9pbnRsZXNzIGFu
eXdheS4pCisJCQkJCSAqLworCQkJCQlpbnQ2NAkJaW50ZXJ2YWxfbXM7CisKKwkJCQkJaWYgKHBn
X211bF9zNjRfb3ZlcmZsb3coYWN0eC0+YXV0aHouaW50ZXJ2YWwsIDEwMDAsCisJCQkJCQkJCQkJ
CSZpbnRlcnZhbF9tcykKKwkJCQkJCXx8IChpbnRlcnZhbF9tcyA+IExPTkdfTUFYKSkKKwkJCQkJ
eworCQkJCQkJaW50ZXJ2YWxfbXMgPSBMT05HX01BWDsKKwkJCQkJfQorCisJCQkJCWlmICghc2V0
X3RpbWVyKGFjdHgsIChsb25nKSBpbnRlcnZhbF9tcykpCisJCQkJCQlnb3RvIGVycm9yX3JldHVy
bjsKKwkJCQl9CiAKIAkJCQkvKgogCQkJCSAqIE5vIEN1cmwgcmVxdWVzdHMgYXJlIHJ1bm5pbmcs
IHNvIHdlIGNhbiBzaW1wbGlmeSBieSBoYXZpbmcKLS0gCjIuMzQuMQoK
--00000000000049074c0653865cc8--