MIME-Version: 1.0
References: <CAN4CZFPim7hUiyb7daNKQPSZ8CvQRBGkVhbvED7yZi8VktSn4Q@mail.gmail.com>
 <7DB528BA-C7A0-4B23-890C-5332FB35A16E@yesql.se> <CAN4CZFNNfhFCQdFWui5HWbQR60eM-cyndZ7YgSv7b5SKxB9C2A@mail.gmail.com>
 <CAOYmi+mDSmh6RNizHRmMAwg4ZP2W=uai3Fr3-wm186NMypf_Pg@mail.gmail.com>
 <CAN4CZFNJftK8NaREYaLi-wqpEz3=crQ=1+3f_XUVji=aOrDSWA@mail.gmail.com> <7094F798-8DD1-4974-9A04-10E147B29581@gmail.com>
In-Reply-To: <7094F798-8DD1-4974-9A04-10E147B29581@gmail.com>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Tue, 24 Feb 2026 15:24:23 -0800
Message-ID: <CAOYmi+kjtmRMBdBU3_bGKGDoRSK2AErXbGtHkAjFRapcQNmjhA@mail.gmail.com>
Subject: Re: Improve OAuth discovery logging
To: Chao Li <li.evan.chao@gmail.com>, Zsolt Parragi <zsolt.parragi@percona.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, 
	Michael Paquier <michael@paquier.xyz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAOYmi%2BkjtmRMBdBU3_bGKGDoRSK2AErXbGtHkAjFRapcQNmjhA%40mail.gmail.com>
Precedence: bulk

> On Feb 13, 2026, at 21:13, Zsolt Parragi <zsolt.parragi@percona.com> wrot=
e:
> > Maybe something like PG_SASL_EXCHANGE_ABANDONED?
>
> This is the only one I wasn't sure of, I used RESTART because I was
> focusing more on the intention of the server ("please restart
> authentication with this additional information"), and a bit also on
> the idea that later restart could stay even within the same
> connection, both in this case and if we add support for
> reauthentication on token expiration.

I think "abandoned" would still work as a descriptor if we eventually
supported multiple SASL exchanges per connection.

On Mon, Feb 23, 2026 at 7:01=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wr=
ote:
> Looks like you forgot to update the commit message to change PG_SASL_EXCH=
ANGE_RESTART to PG_SASL_EXCHANGE_ABANDONED.

Yes -- though keep in mind that committers will often rewrite commit
messages from scratch. So while keeping it accurate and well-written
should be the goal, perfection isn't required to move something into
RfC.

Speaking of which: Zsolt, would you mind adding this to the Commitfest?

> "ctx->state =3D OAUTH_STATE_FINISHED;" is duplicated in the =E2=80=9Cif=
=E2=80=9D and after the =E2=80=9Cif=E2=80=9D, so it can be pull up to befor=
e the =E2=80=9Cif=E2=80=9D.

+1

--Jacob