MIME-Version: 1.0
References: 
 <CAOYmi+nDZxJHaWj9_jRSyf8uMToCADAmOfJEggsKW-kY7aUwHA@mail.gmail.com>
 <CAOYmi+mRhhzGUvrcdickepAnsdaGbqhNcboNe4-YvgtkSzGNbQ@mail.gmail.com>
 <CA+hUKGLyS-GK_rkENaVbFVTa4VJ+reJxWtt+q4gmgNUXhptfYA@mail.gmail.com>
 <CAOYmi+k1q3feeMxfbaJA=+hx+XnOFQA0z2JU+0igA7fTUZTmoA@mail.gmail.com>
 <CA+hUKG+H1gwDh96jn5jB6Q3HyXrSC9x2y=uQJAthT8NLs6GN_Q@mail.gmail.com>
 <CAOYmi+n1xRNCDnwZzigXVk8V=+sr7ZzuGpJ0tAyozX-zQT19Gg@mail.gmail.com>
 <CAOYmi+mvk8Y7btYJhBzOGiNTY3cCpYZKjhA4-TP2Lkb=zOr4oQ@mail.gmail.com>
 <87ldnvgkdq.fsf@wibble.ilmari.org>
 <CAOYmi+=9J0nA7XfUCaEdjUdAb9+L6nLoJCEGRYXZbUtZ_o2k5Q@mail.gmail.com>
 <87fre1h90x.fsf@wibble.ilmari.org>
 <CAOYmi+nUAU+eJx__j6Uhmn3QV2G6NTdbL-_OJA1YQmscmKZiqw@mail.gmail.com>
 <87cy95h5uh.fsf@wibble.ilmari.org>
In-Reply-To: <87cy95h5uh.fsf@wibble.ilmari.org>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Fri, 8 Aug 2025 14:31:49 -0700
Message-ID: 
 <CAOYmi+m6t7r3jvDH-vUmy+GS_ZhstnPViE6Hee8c_M=_ASM9hg@mail.gmail.com>
Subject: Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events
To: =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
Cc: Thomas Munro <thomas.munro@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Daniel Gustafsson <daniel@yesql.se>,
	Peter Eisentraut <peter@eisentraut.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAOYmi%2Bm6t7r3jvDH-vUmy%2BGS_ZhstnPViE6Hee8c_M%3D_ASM9hg%40mail.gmail.com>
Precedence: bulk

On Fri, Aug 8, 2025 at 2:16=E2=80=AFPM Dagfinn Ilmari Manns=C3=A5ker
<ilmari@ilmari.org> wrote:
> That's because encode_json has a prototype[1], which changes how the
> argument list is parsed: no longer just as a flat list of values like a
> normal function.  Specifically, it has a prototype of '$', which means
> it only takes one argument, which is evaluated in scalar context.  So
> the first example is a syntax error, but in the second example the
> parenthesised expression is the single argument.  Becuse it's in scalar
> context, the comma is actually the scalar comma operator, not the list
> element separator, so the return value is the right-hand side of the
> comma (just like in C), not the length of the would-be list.

ron-swanson-throws-away-computer.gif

Well, thank you for the explanation. I'll make that change.

--Jacob