Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFyBd-005klB-1X for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2026 17:50:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wFyBc-002diu-14 for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2026 17:50:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFyBb-002dik-3D for pgsql-hackers@lists.postgresql.org; Thu, 23 Apr 2026 17:50:00 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wFyBY-00000002S4r-16Cw for pgsql-hackers@postgresql.org; Thu, 23 Apr 2026 17:49:57 +0000 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-8ec9f099fc6so455185885a.0 for ; Thu, 23 Apr 2026 10:49:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776966595; cv=none; d=google.com; s=arc-20240605; b=HMhNMqwScSs8oFAXxdp5eS1k1WzNLS2nXcb1IQxaz3EEiCcKdi62wBf4Wv0P2fEjAh PbqmcmhptltTaWkxUSOnAV5oTGYF3/ot5FjHrVAvXsgxA3x8ZFH1vrzgqM1irw4Qucu8 r9Qc+TDPY5Dkoq5YAja4qdy+Y5HgjBo1wQf+evR+0B/FHiojF8Kydg9VqMd6HpHligY8 C70T9K43j9f+knWJz/sMUYI07XcRdggXN+MLcusWgbY09sQV93CJak4uqvJ3F8xVH7Iq M8wouNxjCc3M9BEI9SGfpWk13sgGI22xCuC+AVmucYtTkP1MwUj6YnldMtwahORYcVC6 ssvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Q9XKkqHl5dywi9zXqRJiMbZEudeyJpAZZPK0YQpHvHQ=; fh=IgEnO65J++HTo6iOQmqI/dpBHPC4ScZUzB1jxtfXvgM=; b=UNaixQvK0ztsRuPq3CYavjRxdfMnYY/DtFbqf/FvKRlnaTHRLJ0K8yPxHDg3+a1cLa PQWpRG97oWUAoUwKGHrEOrlHwM7BviEMEwe6tsYXYUzG72XLSl0opIGPJnjSf/kLAxMz tYOXocADDSRnnozWGH2pb+7WSABQeWMZJ4bL4GDEAdHUs7I0FDFBvUsXFIvZkw1pc0ly sjxO4xD73t4yQjk/bF8T1e4xYh4w5tvSGyafx1j6VLf8yjgIE0y68F4GSORGkrxwIRxJ upU7eJ13cv+Y+o8qCaEz/VIze7Zo2AJmhsv7vmg2WXWnMjWnALPuvrKOHtKzldoS0dLn xRQg==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1776966595; x=1777571395; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q9XKkqHl5dywi9zXqRJiMbZEudeyJpAZZPK0YQpHvHQ=; b=IgliUkC2ZLxGVNTh1WAZYw80Jo835MvIVSR+Hv1hB1R+iQADMm4dkiU9b2noy97PBu z1STEFya0TcS6G1eu7xmDv6U5vNqSHJPfCIyeMErofL8rbjv77NrfYKU2nK0Sks8Q9W3 EAhIg6/z6fulF8xaCNTne14uvl7UFoKj82nTFlQWxkerJ6lr9TLLQrreXHVyk5OdDIzL wwRo0aDOGaLZBl+00ZsJZvjLA3e9KGv6CDfwDOppws8b5WnZjsYH59uA7hxqxfI9x4gc zar4NAxD8YbALflH5hKKaHKB1fqgI1kiWsNsE9TH6BNQgyTyXsf8KFDqkQVtuY0T6f6o 8Pxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776966595; x=1777571395; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q9XKkqHl5dywi9zXqRJiMbZEudeyJpAZZPK0YQpHvHQ=; b=A2kd8tlfLkJ7zlgD1Gd6OSNG0CUHL5DQv5cDwtwnfUbqvFD355EVCUyPGrVV1rixpi jVL6afAcl9kf7GnUl6JnfcysNt3FiyvrD/ryejPqa5vUtnZSYvoi5/bjHXBcB9RWUowB Cd6kXoVcniGyIo5AgBqDijynlUnl+k4g1AnlCftNsAwmYxyTgWN7yghI4vFFT8d0/t57 f2BWzXp2DpIvCsa/QsbK946icqXQ7u7POtKF6NmzFA6PX+hJorgNqVXef8EEvyWc4Ctt wmJ+/9YnDuUE/VvoYcFRF8h5XdHCxqyIOZLAQ19q02Nz50L0I41/WRU5NjFuRNTGOTA7 Fdbg== X-Forwarded-Encrypted: i=1; AFNElJ/FD9BaOnVzJFUUQ2C3GoY8a6d1kZUdOgO0tB4rtS93hPPAohE9j9o++kojE3AVjHBLJ0U/do08Jju2oa0C@postgresql.org X-Gm-Message-State: AOJu0YwMy8xESIeofyb5xeCuk/hu5WDT4Y8Q+ScKMlRGhFJay4OaVKqS 4xo/ggmQEcVDMZ5iO81reewiQEZPvvRlVCJE9P1WPMuQvatrCO9JSEFyq11/Cc4cm3UPYsecGj/ 6Ln6MrrGh73kmsKvXHvwfFKn57jwkxw9hEnANZvJf X-Gm-Gg: AeBDietxqK1TP/txGW9k/xwVMJMCtmwyjIaRysT+oCB+aaZx5wKsr6tupbriBA7ANFd 9MV3ybYNEUwhIqmqcdxPiaW+sYhcbM05zzG+3UlyTxHhDP+EnOhOsIT0c0DCSrLCKH+16myRcvf /yI/9SHBpyA1Co1HPg8fyYo0BQYrI2xlxAejXedC56cxjr3pvXYzvrbVEsREz4AfhvaTF3qp76g +ZzKng2S4vt6KqIyftvMZ9M1yOktXT5+ygSSd/4egdPgHbr9Z5FGY//016XwN33BmWMe+7UIi0R nTP/uXYqvsL/2UdKSaNQ X-Received: by 2002:a05:620a:708a:b0:8cf:db04:8a39 with SMTP id af79cd13be357-8e7918a34acmr3792032485a.37.1776966595551; Thu, 23 Apr 2026 10:49:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jacob Champion Date: Thu, 23 Apr 2026 10:49:42 -0700 X-Gm-Features: AQROBzCY4eC-esmly-TbtAC4ae9Jp-BChulUQcYKz0IsA2qY-irH__gTXdJ1nX4 Message-ID: Subject: Re: oauth integer overflow To: Daniel Gustafsson Cc: Andres Freund , PostgreSQL Hackers , Jacob Champion Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Apr 23, 2026 at 10:29=E2=80=AFAM Daniel Gustafsson wrote: > > On 23 Apr 2026, at 18:12, Andres Freund wrote: > > I think this should use pg_add_s32_overflow(). Agreed, thanks for the report! > Agreed, I'll write up a patch to fix it. Cool. I have one written up and can share it for comparison, if you'd like, but it's fairly verbose and I wonder if there's a better way to do it. --Jacob