public inbox for [email protected]
help / color / mirror / Atom feedFrom: Jacob Champion <[email protected]>
To: Zsolt Parragi <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Chao Li <[email protected]>
Subject: Re: [oauth] Stabilize the libpq-oauth ABI (and allow alternative implementations?)
Date: Tue, 10 Mar 2026 16:27:24 -0700
Message-ID: <CAOYmi+nWwDQmXLDhH+vmpyp-Y-ELydxv6sg8Oy81qvYUFn+vxg@mail.gmail.com> (raw)
In-Reply-To: <CAN4CZFOhtfezJPXAmzWwSOAR0parDxDP_vy5jUDBy1YD1S33CA@mail.gmail.com>
References: <CAOYmi+mrGg+n_X2MOLgeWcj3v_M00gR8uz_D7mM8z=dX1JYVbg@mail.gmail.com>
<[email protected]>
<CAOYmi+mwzS4xfgomL1Lte+W1hRk+zahhZLnRMDJ8nYxoHUWt_w@mail.gmail.com>
<CAOYmi+mEU_q9sr1PMmE-4rLwFN=OjyndDwFZvpsMU3RNJLrM9g@mail.gmail.com>
<CAN4CZFPwdH_GMrappThju=t4m5n95Dse6ecTNwN=h4GpZLOMng@mail.gmail.com>
<CAOYmi+m-hphbx=CRfGSdcrHi-jL3OrZGJMTAPOYp=OK253hBTA@mail.gmail.com>
<CAOYmi+nnYr_Oe=KH2ZW6Ld88eZWv5P-s5ZtWOEh2KsPtMqOzbg@mail.gmail.com>
<CAOYmi+nCg5upBVOo_UCSjMfO=YMkZXcSEsgaADKXqerr5wahZQ@mail.gmail.com>
<CAOYmi+nRmt+K+ZVNztKFv=LuasDCCSsXLihZB6BEkVeroW8EvA@mail.gmail.com>
<CAN4CZFOMv=0Y1PZ8uw3xgJmEqt4D1dr1-yOq9jjZYTARZp7H9Q@mail.gmail.com>
<CAOYmi+mLaohk3FLbH9fKGmzN7yFGHs2Zefdyp31wbL1130puiA@mail.gmail.com>
<CAOYmi+=Pr7AAdkcKXyLw3ycxcrjGKsOV2CTYVV2PKYQw9ecG0Q@mail.gmail.com>
<CAN4CZFOhtfezJPXAmzWwSOAR0parDxDP_vy5jUDBy1YD1S33CA@mail.gmail.com>
On Tue, Mar 10, 2026 at 3:10 PM Zsolt Parragi <[email protected]> wrote:
> +#define MASK_BITS ((uintptr_t) 0x55aa55aa55aa55aa)
>
> Won't this cause a warning in 32 bit builds? (0x55aa55aa definitely
> should work in both?)
Hopefully not -- it's an explicit rather than implicit truncation, and
we've required 64-bit integer support from our compilers for a long
time now. But I'm bad at keeping the rules in my head; did you have a
particular compiler in mind?
(The 32-bit build in Cirrus doesn't seem to mind this, though it does
mind the unused variables that I forgot to wrap in USE_VALGRIND...
will fix.)
--Jacob
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [oauth] Stabilize the libpq-oauth ABI (and allow alternative implementations?)
In-Reply-To: <CAOYmi+nWwDQmXLDhH+vmpyp-Y-ELydxv6sg8Oy81qvYUFn+vxg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox