MIME-Version: 1.0
References: <2039ac58-d3e0-434b-ac1a-2a987f3b4cb1@greiz-reinsdorf.de>
 <CAOYmi+=jZNU9mZ4Z83aR0RiqZ2pF35u5040gCxBgcFqoA4oNbQ@mail.gmail.com> <68cb19fc-4a1c-473e-99e6-d83b99c2e245@greiz-reinsdorf.de>
In-Reply-To: <68cb19fc-4a1c-473e-99e6-d83b99c2e245@greiz-reinsdorf.de>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Wed, 11 Sep 2024 16:00:25 -0700
Message-ID: <CAOYmi+nmT+VRMKnyfLmW0FQh3Qynz_Aw4V=4FqK7=oz=b8m_BQ@mail.gmail.com>
Subject: Re: libpq: Process buffered SSL read bytes to support records >8kB on
 async API
To: Lars Kanis <lars@greiz-reinsdorf.de>
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAOYmi%2BnmT%2BVRMKnyfLmW0FQh3Qynz_Aw4V%3D4FqK7%3Doz%3Db8m_BQ%40mail.gmail.com>
Precedence: bulk

On Wed, Sep 11, 2024 at 12:08=E2=80=AFPM Lars Kanis <lars@greiz-reinsdorf.d=
e> wrote:
> How did you verify the issue on the server side - with YugabyteDB or
> with a modified Postgres server? I'd like to verify the GSSAPI part and
> I'm familiar with the Postgres server only.

Neither, unfortunately -- I have a protocol testbed that I use for
this kind of stuff. I'm happy to share once I get it cleaned up, but
it's unlikely to help you in this case since I haven't implemented
gssenc support. Patching the Postgres server itself seems like a good
way to go.

> > And are there any other sites that
> > need to make the same guarantee before returning?
>
> Which other sites do you mean?

I'm mostly worried that other parts of libpq might assume that a
single call to pqReadData will drain the buffers. If not, great! --
but I haven't had time to check all the call sites.

> > I need to switch away from this for a bit. Would you mind adding this
> > to the next Commitfest as a placeholder?
>
> No problem; registered: https://commitfest.postgresql.org/50/5251/

Thank you!

--Jacob