MIME-Version: 1.0
References: <202405101223.66lahv2qiwe7@alvherre.pgsql> <6dae7e56-5233-4183-bd12-c14cf3c9312e@eisentraut.org>
 <ZkP7ARo6lo90su3K@paquier.xyz> <bc57073e-27a3-4a4a-9d93-ef734d473a74@eisentraut.org>
In-Reply-To: <bc57073e-27a3-4a4a-9d93-ef734d473a74@eisentraut.org>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Wed, 15 May 2024 11:22:58 -0700
Message-ID: <CAOYmi+noK+9neP2Y1QLqBTFhpEnMT21TeKFdoRKHV0zGrgV_ow@mail.gmail.com>
Subject: Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Michael Paquier <michael@paquier.xyz>, Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAOYmi%2BnoK%2B9neP2Y1QLqBTFhpEnMT21TeKFdoRKHV0zGrgV_ow%40mail.gmail.com>
Precedence: bulk

On Tue, May 14, 2024 at 11:15=E2=80=AFPM Peter Eisentraut <peter@eisentraut=
.org> wrote:
>
> On 15.05.24 02:00, Michael Paquier wrote:
> > Is that a recent regression?  I have some blurry memories from
> > working on these areas that changing src/common/ reflected on the
> > compiled pieces effectively at some point.
>
> One instance of this problem that I can reproduce at least back to PG12 i=
s
>
> 1. touch src/common/exec.c
> 2. make -C src/bin/pg_dump
>
> This will rebuild libpgcommon, but it will not relink pg_dump.

I remember src/common/unicode changes having similar trouble, as well [1].

--Jacob

[1] https://www.postgresql.org/message-id/CAFBsxsGZTwzDnTs=3DTVM38CCTPP3Y0D=
3=3Dh+UiWt8M83D5THHf9A@mail.gmail.com