MIME-Version: 1.0
References: <CAOj6k6d0YO6AO-bhxkfUXPxUi-+YX9-doh2h5D5z0Bm8D2w=OA@mail.gmail.com>
In-Reply-To: <CAOj6k6d0YO6AO-bhxkfUXPxUi-+YX9-doh2h5D5z0Bm8D2w=OA@mail.gmail.com>
From: Dharin Shah <dharinshah95@gmail.com>
Date: Fri, 2 Jan 2026 12:38:25 +0100
Message-ID: <CAOj6k6cr+9HA2Dd=iQvZWPbmSgd2eV-8Vk2=hP-rouwa+gLVfg@mail.gmail.com>
Subject: Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs
To: pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000062291b06476626ca"
Archived-At: <https://www.postgresql.org/message-id/CAOj6k6cr%2B9HA2Dd%3DiQvZWPbmSgd2eV-8Vk2%3DhP-rouwa%2BgLVfg%40mail.gmail.com>
Precedence: bulk

--00000000000062291b06476626ca
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

Gentle ping on the textsearch docs patch. Happy to address any feedback

Thanks,
Dharin

On Sat, Dec 27, 2025 at 10:09=E2=80=AFPM Dharin Shah <dharinshah95@gmail.co=
m> wrote:

> Hello,
>
> A minor doc patch for this page
> https://www.postgresql.org/docs/current/textsearch-limitations.html
> and this line
>
> *- The number of lexemes must be less than 2^64*
>
> Docs wrongly claim "lexemes must be < 2^64" but the actual constraint is
> 1 MB total storage (MAXSTRPOS), and no 2^64 check exists in the code.
>
> From src/include/tsearch/ts_type.h:
>
>>     #define MAXSTRPOS ( (1<<20) - 1)   // 1,048,575 bytes
>>
>>     typedef struct {
>>         int32  size;     // number of lexemes
>>         ...
>>     } TSVectorData;
>
>
>  The attached patch:
> - Removes the incorrect 2^64 claim
> - Clarifies this means "distinct lexemes in a single tsvector value"
>
> Thanks,
> Dharin
>

--00000000000062291b06476626ca
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hello,<div><br></div><div>Gentle ping on the textsearch do=
cs patch. Happy to address any feedback</div><div><br></div><div>Thanks,</d=
iv><div>Dharin</div></div><br><div class=3D"gmail_quote gmail_quote_contain=
er"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Dec 27, 2025 at 10:09=E2=
=80=AFPM Dharin Shah &lt;<a href=3D"mailto:dharinshah95@gmail.com">dharinsh=
ah95@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd=
ing-left:1ex"><div dir=3D"ltr">Hello,<div><br></div><div>A minor doc patch =
for this page<br><a href=3D"https://www.postgresql.org/docs/current/textsea=
rch-limitations.html" target=3D"_blank">https://www.postgresql.org/docs/cur=
rent/textsearch-limitations.html</a></div><div>and this line</div><div><br>=
</div><div><i><font color=3D"#666666">- The number of lexemes must be less =
than 2^64</font></i></div><div><br></div><div>Docs wrongly claim &quot;lexe=
mes must be &lt; 2^64&quot; but the actual constraint is <br>1 MB total sto=
rage (MAXSTRPOS), and no 2^64 check exists in the code.</div><div><br>From =
src/include/tsearch/ts_type.h:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad=
ding-left:1ex">=C2=A0 =C2=A0 #define MAXSTRPOS ( (1&lt;&lt;20) - 1) =C2=A0 =
// 1,048,575 bytes<br><br>=C2=A0 =C2=A0 typedef struct {<br>=C2=A0 =C2=A0 =
=C2=A0 =C2=A0 int32 =C2=A0size; =C2=A0 =C2=A0 // number of lexemes<br>=C2=
=A0 =C2=A0 =C2=A0 =C2=A0 ...<br>=C2=A0 =C2=A0 } TSVectorData;</blockquote><=
div><br>=C2=A0The attached patch:</div>- Removes the incorrect 2^64 claim<b=
r>- Clarifies this means &quot;distinct lexemes in a single tsvector value&=
quot;<br><br>Thanks,<br>Dharin</div>
</blockquote></div>

--00000000000062291b06476626ca--