MIME-Version: 1.0
References: <20221104140238.GA16921@telsasoft.com>
 <4E379ADE-1FC3-4D53-BE46-562BDC77C5FE@crunchydata.com>
 <20221104183838.GD16921@telsasoft.com>
In-Reply-To: <20221104183838.GD16921@telsasoft.com>
From: David Christensen <david.christensen@crunchydata.com>
Date: Fri, 4 Nov 2022 14:43:15 -0500
Message-ID: 
 <CAOxo6X+2-k6gqwv2okbgLR_B_MkBCVHOW3CqFomFta2wNkHYdw@mail.gmail.com>
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Ian Lawrence Barwick <barwick@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
 pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAOxo6X%2B2-k6gqwv2okbgLR_B_MkBCVHOW3CqFomFta2wNkHYdw%40mail.gmail.com>
Precedence: bulk

On Fri, Nov 4, 2022 at 1:38 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > > As I recall, that's due to relying on "cp".  And "rsync", which
> > > shouldn't be assumed to exist by regression tests).

Will poke around other TAP tests to see if there's a more consistent
interface, what perl version we can assume and available modules, etc.
If there's not some trivial wrapper at this point so all TAP tests
could use it regardless of OS, it would definitely be good to
introduce such a method.

> > I will work on supporting the windows compatibility here. Is there some=
 list of guidelines for what you can and can=E2=80=99t use? I don=E2=80=99t=
 have a windows machine available to develop on.
>
> I think a lot (most?) developers here don't have a windows environment
> available, so now have been using cirrusci's tests to verify.  If you
> haven't used cirrusci directly (not via cfbot) before, start at:
> src/tools/ci/README

Thanks, good starting point.

> > Was it failing on windows? I was attempting to skip it as I recall.
>
> I don't see anything about skipping, and cirrus's logs from 2
> commitfests ago were pruned.  I looked at this patch earlier this year,
> but never got around to replacing the calls to rsync and cp.

Ah, it's skipped (not fixed) in my git repo, but never got around to
submitting that version through email.  That explains it.

David