MIME-Version: 1.0
From: Shinya Kato <shinya11.kato@gmail.com>
Date: Mon, 4 May 2026 16:58:12 +0900
Message-ID: 
 <CAOzEurQKuy3RiPkd=25PEwEzaqHuGvEOf=X7vaVzhgNjaukYzA@mail.gmail.com>
Subject: Call EndCopyFrom() after initial table sync in logical replication
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000fba3300650f94ce4"
Archived-At: 
 <https://www.postgresql.org/message-id/CAOzEurQKuy3RiPkd%3D25PEwEzaqHuGvEOf%3DX7vaVzhgNjaukYzA%40mail.gmail.com>
Precedence: bulk

--000000000000fba3300650f94ce4
Content-Type: text/plain; charset="UTF-8"

Hi hackers,

While reading the logical replication initial table sync code, I
noticed that copy_table() calls BeginCopyFrom() and CopyFrom() but
never calls the matching EndCopyFrom().

EndCopyFrom() calls pgstat_progress_end_command(), which resets
st_progress_command to PROGRESS_COMMAND_INVALID. Without that call,
the backend status entry continues to report an active COPY operation
while the tablesync worker proceeds to WAL catchup. As a result,
pg_stat_progress_copy shows a stale entry for the entire WAL catchup
phase.

Attached patch adds EndCopyFrom(cstate) immediately after
CopyFrom(cstate) returns.

--
Best regards,
Shinya Kato
NTT OSS Center

--000000000000fba3300650f94ce4
Content-Type: application/octet-stream;
	name="v1-0001-Call-EndCopyFrom-during-initial-table-sync-in-log.patch"
Content-Disposition: attachment;
	filename="v1-0001-Call-EndCopyFrom-during-initial-table-sync-in-log.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_moqwlvot0>
X-Attachment-Id: f_moqwlvot0

RnJvbSAxNGY1MjM2MDFhNDRmODE2ODMzZGQ1ZTRlMGYyMzI2ZWRmNTMzMjc4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTaGlueWEgS2F0byA8c2hpbnlhMTEua2F0b0BnbWFpbC5jb20+
CkRhdGU6IFR1ZSwgMjEgQXByIDIwMjYgMTA6Mjk6MDcgKzA5MDAKU3ViamVjdDogW1BBVENIIHYx
XSBDYWxsIEVuZENvcHlGcm9tKCkgZHVyaW5nIGluaXRpYWwgdGFibGUgc3luYyBpbiBsb2dpY2Fs
CiByZXBsaWNhdGlvbgoKUHJldmlvdXNseSwgY29weV90YWJsZSgpIGNhbGxlZCBCZWdpbkNvcHlG
cm9tKCkgYW5kIENvcHlGcm9tKCkgYnV0Cm9taXR0ZWQgdGhlIG1hdGNoaW5nIEVuZENvcHlGcm9t
KCkgY2FsbC4gIFdpdGhvdXQgaXQsIHRoZSBiYWNrZW5kCnN0YXR1cyBlbnRyeSBjb250aW51ZWQg
dG8gcmVwb3J0IGFuIGFjdGl2ZSBDT1BZIG9wZXJhdGlvbiB3aGlsZSB0aGUKdGFibGVzeW5jIHdv
cmtlciBwcm9jZWVkZWQgdG8gV0FMIGNhdGNodXAsIGNhdXNpbmcgcGdfc3RhdF9wcm9ncmVzc19j
b3B5CnRvIHNob3cgYSBzdGFsZSBlbnRyeSBmb3IgdGhlIGVudGlyZSBXQUwgY2F0Y2h1cCBwaGFz
ZSwgd2hpY2ggY2FuIGJlCnNpZ25pZmljYW50IGZvciBsYXJnZSB0YWJsZXMuCgpUaGlzIGNvbW1p
dCBhZGRzIHRoZSBtaXNzaW5nIEVuZENvcHlGcm9tKCkgY2FsbCwgd2hpY2ggaW52b2tlcwpwZ3N0
YXRfcHJvZ3Jlc3NfZW5kX2NvbW1hbmQoKSB0byByZXNldCBzdF9wcm9ncmVzc19jb21tYW5kIHRv
ClBST0dSRVNTX0NPTU1BTkRfSU5WQUxJRCBhcyBzb29uIGFzIHRoZSBDT1BZIHBoYXNlIGNvbXBs
ZXRlcy4KCkF1dGhvcjogU2hpbnlhIEthdG8gPHNoaW55YTExLmthdG9AZ21haWwuY29tPgpSZXZp
ZXdlZC1ieToKRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS8KLS0tCiBzcmMvYmFja2Vu
ZC9yZXBsaWNhdGlvbi9sb2dpY2FsL3RhYmxlc3luYy5jIHwgMSArCiAxIGZpbGUgY2hhbmdlZCwg
MSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dp
Y2FsL3RhYmxlc3luYy5jIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC90YWJsZXN5
bmMuYwppbmRleCBlYjcxODExNDI5Ny4uYTA0Yjg0ZWJjMWQgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNr
ZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvdGFibGVzeW5jLmMKKysrIGIvc3JjL2JhY2tlbmQvcmVw
bGljYXRpb24vbG9naWNhbC90YWJsZXN5bmMuYwpAQCAtMTIxMCw2ICsxMjEwLDcgQEAgY29weV90
YWJsZShSZWxhdGlvbiByZWwpCiAKIAkvKiBEbyB0aGUgY29weSAqLwogCSh2b2lkKSBDb3B5RnJv
bShjc3RhdGUpOworCUVuZENvcHlGcm9tKGNzdGF0ZSk7CiAKIAlsb2dpY2FscmVwX3JlbF9jbG9z
ZShyZWxtYXBlbnRyeSwgTm9Mb2NrKTsKIH0KLS0gCjIuNDcuMwoK
--000000000000fba3300650f94ce4--