MIME-Version: 1.0
References: <Zt6cDnwSvnuLLnak@paquier.xyz> <Zt-V90bS4diq4e0Q@paquier.xyz>
 <ZurvG45F3lQHLw4G@nathan> <Zur4qqhABOXtZS8h@nathan>
 <Zutc67q6my4AXOt2@paquier.xyz>
 <ZuujwbHFor1zLufJ@paquier.xyz> <Zv36cbgluA_oZPYq@paquier.xyz>
 <CAOzEurQZ1a+6d1K8b=+Ww1NFQVwAt9KSCQsBWXYBaPnYCenK3g@mail.gmail.com>
 <CAOzEurRRfPaZn_ZGmoDz2C3+74SAhk+FUZo_9oB1Zg_rQNGkYA@mail.gmail.com>
 <aEBxIcAiiDVlQvdx@nathan> <aEDjjpritZuv3h2J@paquier.xyz>
In-Reply-To: <aEDjjpritZuv3h2J@paquier.xyz>
From: Shinya Kato <shinya11.kato@gmail.com>
Date: Thu, 5 Jun 2025 10:04:23 +0900
Message-ID: 
 <CAOzEurS=3xu8WV6KRmc-axLn5tUs_5Ggy0DY_Gj8XcFOJTDeWQ@mail.gmail.com>
Subject: Re: Partitioned tables and [un]loggedness
To: Michael Paquier <michael@paquier.xyz>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAOzEurS%3D3xu8WV6KRmc-axLn5tUs_5Ggy0DY_Gj8XcFOJTDeWQ%40mail.gmail.com>
Precedence: bulk

On Thu, Jun 5, 2025 at 9:23=E2=80=AFAM Michael Paquier <michael@paquier.xyz=
> wrote:
> Agreed to not suggest the PARTITION BY clause in the tab completion as
> it is not supported by the backend for unlogged tables.
> tab-complete.in.c has some handling for CREATE UNLOGGED TABLE around
> line 3667, so we could just have an extra case for it, like in the
> attached patch.  A split already exists for temporary tables to handle
> the ON COMMIT clause after the attribute list.
>
> Thoughts?

Thank you. It looks good to me.

--=20
Best regards,
Shinya Kato
NTT OSS Center