public inbox for [email protected]  

help / color / mirror / Atom feed

From: Lukas Fittl <[email protected]>
To: Tom Lane <[email protected]>
Cc: John Naylor <[email protected]>
Cc: Jakob Egger <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Tobias Bussmann <[email protected]>
Cc: Andres Freund <[email protected]>
Subject: Re: Broken build on macOS (Universal / Intel): cpuid instruction not available
Date: Thu, 7 May 2026 10:33:33 -0700
Message-ID: <CAP53PkzLmeNUiNtcOyw62KkD7OzthdCbkwGTyAk+Lu3LKsmOcg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

On Thu, May 7, 2026 at 9:22 AM Tom Lane <[email protected]> wrote:
>
> I wrote:
> > ... The code in HEAD doesn't have
> > that guard, and is essentially assuming that every x86 platform
> > wil provide HAVE__GET_CPUID or HAVE__CPUID.
>
> Independently of whether macOS multi-arch is something we consider
> supportable, I think the aforesaid assumption is a bad idea.
> Can't we make pg_cpuid() return zeroes if it doesn't know how to
> get the info, analogously to what pg_cpuid_subleaf() does?

Having worked in that area in this cycle, I think returning zeroes (or
adding a return value that confirms we got data) could work for the
TSC related functionality, since we just fall back to the system clock
and disallow TSC use if we can't get CPUID data. I'll let John confirm
if there are any other optimizations that require CPUID data.

CCing Andres as well, since he reviewed some of those patches for pg_cpu_x86.c.

Thanks,
Lukas

-- 
Lukas Fittl

view thread (24+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Broken build on macOS (Universal / Intel): cpuid instruction not available
  In-Reply-To: <CAP53PkzLmeNUiNtcOyw62KkD7OzthdCbkwGTyAk+Lu3LKsmOcg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox