MIME-Version: 1.0
References: 
 <CAPgqM1V4LW2qiDLPsusb7s0kYbSDJjH5Tt+-ZzVmPU7xV0TJNQ@mail.gmail.com>
 <CACJufxE_8DveuvpiSnnRpeRGC9UdGY6X7ZptNt08-x+v-_5QQg@mail.gmail.com>
 <CAPgqM1URzR017U5gEK6S5dYz8VdYMaJf82G9sZFq5xbpHR1J_g@mail.gmail.com>
 <E3B668DD-7D16-418F-819A-052B893C1B02@gmail.com>
In-Reply-To: <E3B668DD-7D16-418F-819A-052B893C1B02@gmail.com>
From: Tim Waizenegger <tim.waizenegger@enterprisedb.com>
Date: Wed, 22 Oct 2025 14:00:21 +0200
Message-ID: 
 <CAPgqM1XBMQGP=w2a9jajGkrGMzVk0rGBm0+F1pnwsZnn_U6YoQ@mail.gmail.com>
Subject: Re: [PATCH] pg_get_domain_ddl: DDL reconstruction function for CREATE
 DOMAIN statement
To: Chao Li <li.evan.chao@gmail.com>
Cc: pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAPgqM1XBMQGP%3Dw2a9jajGkrGMzVk0rGBm0%2BF1pnwsZnn_U6YoQ%40mail.gmail.com>
Precedence: bulk

On Wed, Oct 22, 2025 at 12:27=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> w=
rote:
>
> Hi Tim,
>
> Thanks for working on this. I haven=E2=80=99t finished reviewing the enti=
re patch. But I got a quick question:
>
> While reviewing a similar patch of pg_get_policy_ddl(), it take the last =
parameter as a pretty flag. I wonder why pg_get_domain_ddl() doesn=E2=80=99=
t support an argument for pretty?
>
>

That's a good point; we'll add pretty printing support for consistency
with the other functions. I'll send a new patch in the coming days.

Best regards,
Florin Irion
Tim Waizenegger
EDB (EnterpriseDB)