Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w8G0m-000M4D-0V for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Apr 2026 11:14:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w8G0k-005Ovc-1v for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Apr 2026 11:14:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w8G0k-005OvQ-0y for pgsql-hackers@lists.postgresql.org; Thu, 02 Apr 2026 11:14:54 +0000 Received: from mail-dy1-x1329.google.com ([2607:f8b0:4864:20::1329]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w8G0i-00000000BYV-1BWu for pgsql-hackers@postgresql.org; Thu, 02 Apr 2026 11:14:54 +0000 Received: by mail-dy1-x1329.google.com with SMTP id 5a478bee46e88-2b4520f6b32so934467eec.0 for ; Thu, 02 Apr 2026 04:14:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775128490; cv=none; d=google.com; s=arc-20240605; b=XZ7XoSrQEFGDIhJZ/2wgbRkdXf6AXxUPmn21gzopqhGecGFH7HmKpdhb7R49DRfy8J ucxmyDUInikT6OEBJSK/b8obovuwr3Lz+84TedjyE8pG2Ye/orakfVuZoee3/neUefwX biWk80pY7IhH6PZppGZ6Vtt4fwUaNPzsEm1xt2mSjGdofuZA3YRskyI0SckvgJcaVmg6 /NoH0EGq2SGvyvSYSWyRxzGm+D9JmOuBmKDGYkextKT8qtjagObu303k0ihum6D0KAGE NO3C/NKViBqOYiUQfECnuPah8BDYFFZnuCQLike3aNltJ0G4B5JOHp8xEi34MN3u++gP OlFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=qIfWLYP4pt4UYb2TuIrQitoxBIa2/y4mW3PXouhGpIU=; fh=YeTQX2xyjTQAsn/4ffZ/2qmjmKGuXrKLeMubLejgerk=; b=kQH40ne1JcFsBX+mKehO5EERpZrexl3AAxIN9uBKaOsQ1NumX8c8hdJpx8Q2e20elr aXGkRHIc5x+1DSxdi0rXMZPqWNZlwRUvGfkFD61Tbf5LJzkOVCls4tpxxGKKWZYiQHxj QrcZcTU32iCf1hPvK+YKnM4lt224E3u9MhFmJM3/THZbtJ0gJ+TjnMLxnM4egkjrJolk gowQneI0H+HiGrjiNjoRQ34saA3Q2ZYsp5fv7GZs7C0IWb5IWaFfZUkwe2emCir73NCl MgWwDFKyJDzn4R4Yn+4KrRoosJ4w5Dz5k8hp9U3MxIvSyUeWtbNWMHN4iSOeiwZPPV4Y MsIg==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775128490; x=1775733290; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qIfWLYP4pt4UYb2TuIrQitoxBIa2/y4mW3PXouhGpIU=; b=RARhEbZLh+bvV1pTDNgYcaPeV6rqw+bijzDO4yOKS982Qirx2qngFFB9Z0YGcuy8kP erfeQGZ1CxelLBKB7mcidxQFQwNQl/bwuh12155zjdVEnOzTqUalhBLSJUmUYUPXWeS9 RvzLPgkBlaJhW28B6cInzIwFK5t4g/wAQJvxwZn+jt6zjOCEv0nEbc8QG5ICUeIS52wh ldxzrAZuj+kqUPEmEZAZbzSfnPqc2lG4M96pVuOe45N/It1lzcu7h2g2+Ijjg1mAzwNx wFxUsNs6ilA2oDh+KPc2MJEny73+kbtH+XC0//jfcb1e9iaRu86f8A3hkYBnqryMiZXj ZsCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775128490; x=1775733290; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qIfWLYP4pt4UYb2TuIrQitoxBIa2/y4mW3PXouhGpIU=; b=rDpQXfwg8XVlUHs4P7cDGCivQw/0IV8bv5UiXJLvMlUEUUUemIgfPsQUBuD1fEeJFF rz2Gu4g2OC5SjDIGJ3Yn37xo8Gj/QrUCORuSSU4UO09D7fR43QV2DyT3oCibymhZGEGQ IDzsg9MmNbzVbY2FlLXoCpaMKsSB1kt8ueumkRtojUhoBFH8+dvqUS3r2CU67l/+wenB kC64gUu1z6RLvDUzoIkuvIofwOaDMCGaopOAyRCw7mlqUHY7c7xTJ4+vsDTOfEXjq4qH /SNklDUEtfnWnZ74XZ/qREYI2mgjyW+B/ysCbmYoNn979gB8rNi3ETtoKuhWjln9q3uJ HUTQ== X-Forwarded-Encrypted: i=1; AJvYcCUJ3nLbJBBgS4DeikXcrZSKec6C6mWroYKG+4R7DMvmnoUsDUrXKR+1wCdWUCnClOlJJwc7oNwJVRmgHGvW@postgresql.org X-Gm-Message-State: AOJu0Yw/tlRJBav7kLQaElEM1nQYQYUjhPiUP2TsJICj8qmsNQ/KkWW7 TFZVgXkfp5upVpfuZkLtxTfnncGYux2AT3ZjIw65A3ewl7ScrWCrJBS2kYD5MWi5HNI73XcMNL/ OqGKkYRm1ePRgsbHBl6wrCzEo/betvcakZNBNvLc= X-Gm-Gg: AeBDiev5AbXCt6UWZzJGAwsbkn4mF43ZFF547EVRhpNDEkMX+8BLF2jJJFc0M7zRdWw c1nLzAAM9kdOc3G8oGDy+f/1xvwaHII9jNBe8Pbg60ZVjT4Pd7z1kWV+SLk5W8hQlSEkUlUZnPJ eShf9Luu554zr8y9VUSe6usj8PUR2G16U8vqIewQTbD7+BxZsaRrc2X1K9yUDEzGVbccnckC0et zlOVMT/c0ZiNM1dNZ3sC4EiMB6ZEp6ZRdxT823GedraiNntrWtCE1vF4wC1sWR4IMQ8ZPWYU1+s mNuVHTeTXSiDX1oGez+Bb0ZCN+hj4sjPbbEQ8JksvM8SfhlULPpHP0dxji1myRCSS9Gqpg6auQv jW8jcfT/tbu8coMaDEbR1/uSs2LyhDUkj37KW+Vwo X-Received: by 2002:a05:7301:1284:b0:2c8:7172:3b88 with SMTP id 5a478bee46e88-2c932eb2a0dmr3674317eec.28.1775128490054; Thu, 02 Apr 2026 04:14:50 -0700 (PDT) MIME-Version: 1.0 References: <238121774875528@mail.360.yandex.ru> <903e5b83-e94b-440e-b47d-fedd151c854d@tantorlabs.com> In-Reply-To: From: Etsuro Fujita Date: Thu, 2 Apr 2026 20:14:37 +0900 X-Gm-Features: AQROBzCybDwSMatkSRx6YX3wTCg599WNuT_ihOpvctFIjeyjPAnB03rU5kkbxHY Message-ID: Subject: Re: [PATCH] analyze: move elevel calculation into do_analyze_rel() To: Andreas Karlsson Cc: Lev Nikolaev , "pgsql-hackers@postgresql.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Apr 2, 2026 at 8:29=E2=80=AFAM Andreas Karlsson = wrote: > On 3/31/26 7:56 PM, Lev Nikolaev wrote: > > I reworked the patch slightly. > > This small cleanup makes sense to me since do_analyze_rel() already > looks at if VACOPT_VERBOSE is set meaning related code is grouped closer > after this small refactoring. > > The patch no longer applied so I rebased it. Sorry, but -1 from me because this change would lead to doing the same setup repeatedly when analyzing inheritance trees, which is not great. Best regards, Etsuro Fujita