MIME-Version: 1.0
References: 
 <CA+TgmoYqMtWb4zLUkT98oFnEkJ=Wz0Pw-ggDJrp9wnSXPzUaeQ@mail.gmail.com>
 <CAPmGK161TJ4G01eptv3sBqgxa4SNHDE9VRqoC6jy5Y6G3D8yDw@mail.gmail.com>
 <CA+TgmoZpwfTGqqp=0efV99e_BMYWdLFq2XKRWVSDcukifkZMeA@mail.gmail.com>
 <CADkLM=dxe8NbQu4RNi2OFXpaRKdpS0-CHGm6Mqtf_rW155BM4g@mail.gmail.com>
 <CADkLM=cV=uezAKyZdyyxnZOBRhGLUSbeYfDj5_jbDCLP9LP24Q@mail.gmail.com>
 <CA+TgmoaVcgZJpwxyi7HEfNMJhmm7BXkTQ468jvxkW2QzQZRkvg@mail.gmail.com>
 <CADkLM=dy18dDJ+j3-_Ofn11vt5J7zF33oTWnE6N=ePc83uS91A@mail.gmail.com>
 <CAPmGK15MfVT2H+PUvA_nAJvySGr_pAVkVx3KcnVXWGO36acWLA@mail.gmail.com>
 <CADkLM=dr5bfB8YN-bV1U0NDvyVO7a6uuz0BsAi89a1Md4A==8g@mail.gmail.com>
 <CAPmGK14P2GRe78hp6fZ3vExU_9RRDjMsYVOx7AALvUQ-hKTUiQ@mail.gmail.com>
 <CADkLM=cL9ZGvO-72QWyXA5Wqv-4P3T1fp+VFJy5e6k3Hf=POMw@mail.gmail.com>
 <CA+TgmoZdTVeXRQo__cEr_1y+mUO9nubOX=6PEfw7Cr0UfZQn6w@mail.gmail.com>
 <CADkLM=fe=ycPdwT2wE_iYwK8e8viMbWvwWhXR9vDe+55KKF-KQ@mail.gmail.com>
 <CADkLM=dWJaw04u9FU=WkykOy7bu7B5eKmoDkfVz6JXh7mdemkw@mail.gmail.com>
 <CA+TgmoY3a_S0munZ0wg4hQpMKVMyM_jpi6aGhFR0gAm1jLukag@mail.gmail.com>
 <CADkLM=cdKjgphHpFW8kKukHF+DVYKogHcqLXO=BA8MGfiRFqQA@mail.gmail.com>
 <CADkLM=c9BEuA9vPjE9Wco6+Lz-HSnnmBZrFhi=-yNi0K8tmZug@mail.gmail.com>
 <CAPmGK17W1sUB3JnkRoBpgO0_iSH5HRcc0_nxk8Us4KYsQhuQxg@mail.gmail.com>
 <CA+TgmoZd5MDhcx6uav6MWxhM42yWcfaRAHYKNtNkuog=yrKAgw@mail.gmail.com>
 <CADkLM=f_c7Xoq-bSzw28LgvxPa+OQ3rVow=xwkTyjz1J0=pMdw@mail.gmail.com>
 <CAPmGK14dY-Cex2rc08TinQjHR4Q1L6nqPBfdEBRZusP7n_TZSA@mail.gmail.com>
 <CADkLM=enKc-3-uTjUSXXhoRhSKDHVdb_ate+S2dtkEcscW5bvA@mail.gmail.com>
 <CAPmGK17rNA=dknxHCXbUoQ_xe2PQcPq0d-bhTr47wrUfXrDLFA@mail.gmail.com>
 <CADkLM=dYZ2XJ=nUMSYgA6D3VEFQ4rvpyDLKD-RrnfESUGxktiA@mail.gmail.com>
 <CAPmGK15eTnEtn_tPm+o0QA-jEnJUW+B2FPAF=vGNkFAGMApWNQ@mail.gmail.com>
 <CAPmGK16-=HvkijvSiDfo8=JmrHQ4ra79gSnJbKzW4Oob9yPfdQ@mail.gmail.com>
 <CAPmGK16XqvvkWhsGgUASUQAtrxEtOfUud4id6do3zZ+XX44WZA@mail.gmail.com>
 <CAHGQGwGjcQ4SwHMUQ9P8UYQ7iLKL1QE3uLSdONToQ1MrzpUUoQ@mail.gmail.com>
 <CAPmGK17r6fPH21k6abF=qaQ96AnoJpv1SdOSayk4VHmp_8-fjw@mail.gmail.com>
In-Reply-To: 
 <CAPmGK17r6fPH21k6abF=qaQ96AnoJpv1SdOSayk4VHmp_8-fjw@mail.gmail.com>
From: Etsuro Fujita <etsuro.fujita@gmail.com>
Date: Fri, 10 Jul 2026 20:36:57 +0900
Message-ID: 
 <CAPmGK14hN-YXxPp-OeWZ6E8=YvT5SESh+NdcQywsdnV_AXsRiA@mail.gmail.com>
Subject: Re: use of SPI by postgresImportForeignStatistics
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAPmGK14hN-YXxPp-OeWZ6E8%3DYvT5SESh%2BNdcQywsdnV_AXsRiA%40mail.gmail.com>
Precedence: bulk

On Fri, Jul 10, 2026 at 4:40=E2=80=AFPM Etsuro Fujita <etsuro.fujita@gmail.=
com> wrote:
> On Fri, Jul 10, 2026 at 2:37=E2=80=AFPM Fujii Masao <masao.fujii@gmail.co=
m> wrote:
> > In the committed patch, I found that the set_*_arg() helper functions
> > in postgres_fdw.c are declared static in their prototypes, but their
> > definitions omit the static keyword. This looks like an oversight.
> >
> > Attached patch adds static to the definitions for consistency and
> > to make their intended file-local scope explicit. It also fixes a few
> > nearby comment typos.
>
> Good catch!  Thanks for the patch!  LGTM.

My compiler (Apple clang version 17.0.0 (clang-1700.4.4.1)) doesn't
output any error/warning about that declaration.  Actually, it's
allowed?  Anyway, +1 for adding it for consistency.

Best regards,
Etsuro Fujita