public inbox for [email protected]  

help / color / mirror / Atom feed

From: Etsuro Fujita <[email protected]>
To: Alexander Korotkov <[email protected]>
Cc: Richard Guo <[email protected]>
Cc: Matheus Alcantara <[email protected]>
Cc: Alexander Pyhalov <[email protected]>
Cc: Pgsql Hackers <[email protected]>
Subject: Re: Asynchronous MergeAppend
Date: Tue, 7 Apr 2026 19:25:41 +0900
Message-ID: <CAPmGK16dNmOhFpSu1nSh7699PXViTJNp12enfUmiBn95gRVUdQ@mail.gmail.com> (raw)
In-Reply-To: <CAPpHfdueTP03n-icH+OgT4-Odhu6M4T1-fNZTymoqSj8QcPARA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAFY6G8d3Yvxa_kRQA24BsJhwqfmSCv1ujiv_7b6g5isf-ZTs_Q@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAPpHfdu+3Eud0CBpdFT+osWiT=e=zOQUtBsx8Z5okKrqhgVAJg@mail.gmail.com>
	<[email protected]>
	<CAPpHfdsO8zYpDW==D6T5N0cJ+AzK7a_OyXJoYU1kFi=xZFTLuQ@mail.gmail.com>
	<CAMbWs49Nc_UKJ9Lm-j4w=X6Xd4a5SayQmb1F0P6OfA3XzGy=aw@mail.gmail.com>
	<CAPmGK16c_hsMz1RM9Wu7F44cQzL+oOdC_T1S0nteAYG0hwTrxQ@mail.gmail.com>
	<CAPpHfdueTP03n-icH+OgT4-Odhu6M4T1-fNZTymoqSj8QcPARA@mail.gmail.com>

On Tue, Apr 7, 2026 at 9:25 AM Alexander Korotkov <[email protected]> wrote:
> Thank you for your feedback.  I would say that this patch is here for
> quite long, and it's pretty straightforward.  It passed many rounds of
> review by Matheus Alcantara.  I've done a lot of minor cleanups and
> improvements, and reorganized changes into multiple patches.  The only
> major change I did is actually a simplification which come from the
> fact that only initial heap filling is effectively async [1].  Today
> Matheus gave a feedback on my changes.

I think Matheus did a good job, but he said "I still don't have too
much experience with the executor code but I hope that I can help with
something.", and IIUC, his reviews were mostly about code
cleanup/deduplication, so ISTM that the patch hadn't been reviewed
that extensively, despite its complexity.  That was actually one of
the reasons why I lowered the priority of the patch.

> Surely, I wouldn't commit this patch without giving you a chance to
> review.  We can postpone it till early PG20 development cycle.  But if
> you find it possible to take a look at this patch during Apr 7, let me
> know.

Sorry, I don't have time for that.  I will defer to your judgment, too.

Thank all of you for working on this important feature, anyway!

Best regards,
Etsuro Fujita

view thread (33+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Asynchronous MergeAppend
  In-Reply-To: <CAPmGK16dNmOhFpSu1nSh7699PXViTJNp12enfUmiBn95gRVUdQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox