Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1iaX4O-0005BS-U3
	for pgsql-hackers@arkaria.postgresql.org; Fri, 29 Nov 2019 03:35:49 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1iaX4M-0000xh-FV
	for pgsql-hackers@arkaria.postgresql.org; Fri, 29 Nov 2019 03:35:46 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <etsuro.fujita@gmail.com>)
	id 1iaX4M-0000xZ-1D
	for pgsql-hackers@lists.postgresql.org; Fri, 29 Nov 2019 03:35:46 +0000
Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <etsuro.fujita@gmail.com>)
	id 1iaX4J-0006v1-IS
	for pgsql-hackers@postgresql.org; Fri, 29 Nov 2019 03:35:44 +0000
Received: by mail-lf1-x135.google.com with SMTP id r15so18544144lff.2
        for <pgsql-hackers@postgresql.org>;
 Thu, 28 Nov 2019 19:35:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=b4M1oBViaFqZvHTl54EJUmJ7rtgNcB3OahwrkHuFXNI=;
        b=WkQdpEqMjCiDHZqOrB5xfDJG465jk5pH5CBlG3/cO/qVqqhUn7vaz7NBAdGnRr7dfz
         7wCP1V+eLGstR3MjjL4IY9P4uVtWr3WpBpm/LFOzoINwR/RiU8nDThOcKmJHPUh/VHC/
         vODJ8EN1mBwCAEB5Lo5g8uBGlSl1SOgxmoNs22nt+B4yqdeOj+QczvLsqFH0K76cUYjn
         /H3sVLMYiNA3aVmD07OeSiGirxMe+bn/P0KqYwBDyq8q+I5NNsD3gK+vByHPWQ0tCCWJ
         it87vUDoJJ6f7XwkiU+YLm8ef5ZnSuah5sXToXy8/fuuElE53/hwJ+L7x3u3+zBYZA6z
         U9ng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=b4M1oBViaFqZvHTl54EJUmJ7rtgNcB3OahwrkHuFXNI=;
        b=lciquZZpy0vVN5RHL1VJH971q/KNnuNNXj3rarEJdUPaUeMqWEgOE3F9yurl7JEdAf
         qXaXF/eoRsL/OX6PY/S1yk+A8uw7d08R7yy4Kz4aVyulBn8TJONjc9opd2X4dSJH2teg
         YCq//O4FwVv8bMh40B0ePeFJzTxHDwtIDYHJ51eauRGLYBUHovhXxk5SgftPOBH/rH8M
         Ou7zjNwWqQ4ssAMB7xWCYPgjrsflA738g0HQMfw2Kn6/cA7TfXGJ6XNB/AyxbmmkCiKL
         13P/C/wez7dUEJ/V97+qX+ROyF+lldjEZpr+nb7J9+yoITn0W+iyyRO9+cd9XSHNdRZ7
         QWSQ==
X-Gm-Message-State: APjAAAVg/22OPru6JimsgIML6l/34UoFUn0B1PGJLDqXVuxdFlu38kWI
	rMrlynPLfSZr7kEoMxih5E0KrIDpuBR+dM2dneo=
X-Google-Smtp-Source: 
 APXvYqxSGn1uJIlDXjvk54FtlRz7b4cY3c/uAsMRbqFWcJwLM3qYyOE/Ecb5jJCW80f4B8FEwWgvLmQEXZsuMgiTfl4=
X-Received: by 2002:a19:84d:: with SMTP id 74mr33560766lfi.122.1574998540795;
 Thu, 28 Nov 2019 19:35:40 -0800 (PST)
MIME-Version: 1.0
References: 
 <CAN_9JTzo_2F5dKLqXVtDX5V6dwqB0Xk+ihstpKEt3a1LT6X78A@mail.gmail.com>
 <CA+HiwqE7amp3-+2UULgYxyAnj4ki23w9VLgMOCpxA6rtS123fQ@mail.gmail.com>
 <CAN_9JTzPTG5qEJ9MerarmuRoifhiejtS3fiRe+ZEZMyz-3NZuw@mail.gmail.com>
 <CAPmGK14kuyh9JciSN-2hDb7cDf6H300S3t07pLTbfkxaCO5BHw@mail.gmail.com>
 <CAN_9JTxC8JdpCDDY0ic-VqQ4fbUGS9O_xas1pU6aXF4Q8imcKA@mail.gmail.com>
 <CAPmGK15szCqpXT1RPxtHq=XTK019mUCPQ4RCFAMsRoU4vsyd1A@mail.gmail.com>
 <CAPmGK15cnjECPmncz=_JkaaEXnADrvhBYBkB2nCUV8phvc7WhA@mail.gmail.com>
 <20191129030305.GF2505@paquier.xyz>
 <CAN_9JTxi=Wqq8g=dQQqjV3eOFaDCZxD5j=TfMXD4BXLPKW=tjg@mail.gmail.com>
In-Reply-To: 
 <CAN_9JTxi=Wqq8g=dQQqjV3eOFaDCZxD5j=TfMXD4BXLPKW=tjg@mail.gmail.com>
From: Etsuro Fujita <etsuro.fujita@gmail.com>
Date: Fri, 29 Nov 2019 12:35:33 +0900
Message-ID: 
 <CAPmGK16jVjvtCtw387VsGTQ2jz8GCwpHgghLskyth8LPoOqZZQ@mail.gmail.com>
Subject: Re: A problem about partitionwise join
To: Richard Guo <riguo@pivotal.io>
Cc: Michael Paquier <michael@paquier.xyz>,
 Amit Langote <amitlangote09@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On Fri, Nov 29, 2019 at 12:08 PM Richard Guo <riguo@pivotal.io> wrote:
> On Fri, Nov 29, 2019 at 11:03 AM Michael Paquier <michael@paquier.xyz> wrote:
>> On Tue, Nov 26, 2019 at 08:35:33PM +0900, Etsuro Fujita wrote:
>> > I've just started reviewing this patch.  One comment I have for now
>> > is: this is categorized into Bug Fixes, but we have a workaround at
>> > least to the regression test case in the patch (ie, just reorder join
>> > clauses), so this seems to me more like an improvement than a bug fix.
>>
>> Hmm.  Agreed.  Changed the category and moved to next CF.

> thanks Michael for the change.

+1

Best regards,
Etsuro Fujita