Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd6M6-00013E-28 for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Mar 2023 09:26:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pd6M4-0006O4-VS for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Mar 2023 09:26:32 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd6M4-0006Nu-M7 for pgsql-hackers@lists.postgresql.org; Fri, 17 Mar 2023 09:26:32 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pd6M2-00043d-Iq for pgsql-hackers@lists.postgresql.org; Fri, 17 Mar 2023 09:26:31 +0000 Received: by mail-wr1-x434.google.com with SMTP id t15so3799126wrz.7 for ; Fri, 17 Mar 2023 02:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679045189; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BrTIpRCgRat0rktMWpByz+GxBiG84oenyG8LALcSork=; b=K9irzFJBKLjA43/JzZ3wIARryFNW2tFsV+t6NtviqAwZk6uoGN9SedcEXz58LwwpRC c1EF1GeZ1NB+p0WRV54rwcRzMId/C73WibYu8o+8spo9Jvrhz4S9Bybq6fWyTmJUokBf ZPwcpZ8riHdlmii++F80FTKeLdaInxgVEVfM//S1ajjOLRd8B4pIClYQMCKw1GThZ024 hQ3xoScFcj3RYucROsoKOtee2z+OsjQVM3roOuGwvzxim/tVUsZ0+YSQaE3sECbx9zqX 6lX1ww8gcNBGfc9yD/Z82j8R8+5HXUiunkndA6a/EgAVqs9LwtY1m7eFtWTtaV8OqeIP qmnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679045189; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BrTIpRCgRat0rktMWpByz+GxBiG84oenyG8LALcSork=; b=4pcDXkwWtYtxynCcdq8X2YvgTpPIbJU7mnhZfb/EfJFIdQp5HR6EMig8yl8hiOhqSn lmGH64ijuBRwxwbpY3XA8fwXrNVW9b1y+5hJWF9fBVx+Q86bvWc5+Cll7B1r9iNZIBh8 yb0iCCxYQnSD9DE60FJ0vI0e9HSKbCNQQqTCbpNBuW7smhU8O73wFZE9lW0C1T7VXx3c i1Cnflrrb7vTrLnOXA78qQXVMIdsSr3s6QnjmA71Vj1KIlljiTU3xiXFNysXFzRJt96t hHrk1lMYCE/iTiwBKyCGfPXueNl7Kmb8vwizsPxgclINuuDBkjRbQJZY2YAWEn1L6oCz HjlQ== X-Gm-Message-State: AO0yUKUVphW+yUwG7C3BphZ7vSEUPHWYJJLV7sfaIgbMBrqOsWny82F6 zQlgwD+qGY90IOshQd2BM7XSmdjaWlqyBFOALuqS8ASxJUk= X-Google-Smtp-Source: AK7set/opwh/5N4Gz5IUehqnNTHbC4HzQ0akIqj/4bJjnm8h2MdWWQMJSYckmxYpkhRFZdy7xk6lQs/pntZhTZTUjaI= X-Received: by 2002:adf:dd46:0:b0:2c7:1320:7781 with SMTP id u6-20020adfdd46000000b002c713207781mr1872601wrm.13.1679045188762; Fri, 17 Mar 2023 02:26:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Etsuro Fujita Date: Fri, 17 Mar 2023 18:28:20 +0900 Message-ID: Subject: Re: postgres_fdw: Useless if-test in GetConnection() To: PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Mar 15, 2023 at 7:18=E2=80=AFPM Etsuro Fujita wrote: > This would be harmless, so I am planning to apply the patch to HEAD only. I forgot to mention that this was added in v14. Done that way. Best regards, Etsuro Fujita