MIME-Version: 1.0
References: <567ED6CA.2040504@sigaev.ru> <CACJufxFSfSGZpmVt_98SRojdugW2s9H-qYm2sYr0A3o-xPea0g@mail.gmail.com>
 <e3338e82-a28d-4631-9eec-b9c0984b32d5@postgrespro.ru> <1cf6b382-6e27-4268-9f2a-54ada66eb2eb@postgrespro.ru>
 <CACJufxH-zju3VfosSRBu8d3xs99sGENn6+P3AETLuTiAPFY+0g@mail.gmail.com>
 <5f119769-ab11-4807-abcc-71d5dd914ea0@postgrespro.ru> <CACJufxFMFoosvbuFYDiFtpam4sKCSGJeh5jYiZSY8PHjCpEHYA@mail.gmail.com>
 <cf0d1615-b594-404d-9a23-3d8ffd9070ec@postgrespro.ru> <CAEudQAq4XTcwhw2OmfW1AJNqvMfbReEWjuzqv6YTz6ZjbpmL0g@mail.gmail.com>
 <21088129-7cd3-424a-bcce-6a3427ba3276@postgrespro.ru> <CAEudQArk002t_C9LGoeJWnw=iGKikt+gSa8Mh==muG00WS=qYA@mail.gmail.com>
 <CACJufxFhQn0awSEcZD7=FHvjx6OLt6PUtuoi0_10pWFVXUEDJw@mail.gmail.com>
 <ded629b2-7885-4be2-b5f5-9426ff47f72c@postgrespro.ru> <11ee9c04-281f-43c8-a0ff-d481c1e01c09@postgrespro.ru>
 <CACJufxGqLA32zTtaJRL2Cacp771k6PJnau7gsax0KRV434Qq7w@mail.gmail.com>
 <54009ba5-4aea-4344-a30d-e3558a59e2a9@postgrespro.ru> <380e5683-cdfd-4220-ab9b-7cccb9d3e480@postgrespro.ru>
In-Reply-To: <380e5683-cdfd-4220-ab9b-7cccb9d3e480@postgrespro.ru>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Fri, 1 Mar 2024 17:33:05 +0200
Message-ID: <CAPpHfds=4kTMhrdijV2hxL4o1ffyceZ+p95KxnF2zBTOb12LWg@mail.gmail.com>
Subject: Re: POC, WIP: OR-clause support for indexes
To: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>, jian he <jian.universality@gmail.com>, 
	Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org, 
	Peter Geoghegan <pg@bowt.ie>, "Finnerty, Jim" <jfinnert@amazon.com>, Marcos Pegoraro <marcos@f10.com.br>, teodor@sigaev.ru, 
	Tomas Vondra <tomas.vondra@enterprisedb.com>, Peter Eisentraut <peter@eisentraut.org>, 
	Ranier Vilela <ranier.vf@gmail.com>
Content-Type: multipart/alternative; boundary="0000000000005aa94406129b1859"
Archived-At: <https://www.postgresql.org/message-id/CAPpHfds%3D4kTMhrdijV2hxL4o1ffyceZ%2Bp95KxnF2zBTOb12LWg%40mail.gmail.com>
Precedence: bulk

--0000000000005aa94406129b1859
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi, Andrei,
Hi, Alena!

On Thu, Feb 29, 2024 at 10:59=E2=80=AFAM Andrei Lepikhov <a.lepikhov@postgr=
espro.ru>
wrote:

> On 28/2/2024 17:27, Alena Rybakina wrote:
> > Maybe like that:
> >
> > It also considers the way to generate a path using BitmapScan indexes,
> > converting the transformed expression into expressions separated by "OR=
"
> > operations, and if it turns out to be the best and finally selects the
> > best one.
> Thanks,
> I spent some time describing the feature with documentation.
> A condensed description of the GUC is in the runtime-config file.
> Feature description has spread between TransformOrExprToANY and
> generate_saop_pathlist routines.
> Also, I've made tiny changes in the code to look more smoothly.
> All modifications are integrated into the two new patches.
>
> Feel free to add, change or totally rewrite these changes.
>

I'm going to review and revise the patch.

One question I have yet.

>        /*
>         * Transformation only works with both side type is not
>         * { array | composite | domain | record }.

Why do we limit transformation for these types?  Also, it doesn't seem the
current code restricts anything except composite/record.

------
Regards,
Alexander Korotkov

--0000000000005aa94406129b1859
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div>Hi, Andrei,</div><div>Hi, Alena!</di=
v><br clear=3D"all"><div><div dir=3D"ltr" class=3D"gmail_signature"><div di=
r=3D"ltr">On Thu, Feb 29, 2024 at 10:59=E2=80=AFAM Andrei Lepikhov &lt;<a h=
ref=3D"mailto:a.lepikhov@postgrespro.ru">a.lepikhov@postgrespro.ru</a>&gt; =
wrote:<br></div></div></div></div><div class=3D"gmail_quote"><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid=
 rgb(204,204,204);padding-left:1ex">On 28/2/2024 17:27, Alena Rybakina wrot=
e:<br>
&gt; Maybe like that:<br>
&gt; <br>
&gt; It also considers the way to generate a path using BitmapScan indexes,=
 <br>
&gt; converting the transformed expression into expressions separated by &q=
uot;OR&quot; <br>
&gt; operations, and if it turns out to be the best and finally selects the=
 <br>
&gt; best one.<br>
Thanks,<br>
I spent some time describing the feature with documentation.<br>
A condensed description of the GUC is in the runtime-config file.<br>
Feature description has spread between TransformOrExprToANY and <br>
generate_saop_pathlist routines.<br>
Also, I&#39;ve made tiny changes in the code to look more smoothly.<br>
All modifications are integrated into the two new patches.<br>
<br>
Feel free to add, change or totally rewrite these changes.<br></blockquote>=
<div><br></div><div>I&#39;m going to review and revise the patch.</div><div=
><br></div><div>One question=C2=A0I have yet.</div><div><br></div><div><fon=
t face=3D"monospace">&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 /*<br>&gt;=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0* Transformation only works with both side type is =
not<br>&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* { array | composite | domain=
 | record }.<br></font></div><div><br></div><div>Why do we limit transforma=
tion for these types?=C2=A0 Also, it doesn&#39;t seem the current code rest=
ricts anything except composite/record.=C2=A0</div><div><br></div><div>----=
--<br>Regards,<br>Alexander Korotkov<br class=3D"gmail-Apple-interchange-ne=
wline"></div></div></div>

--0000000000005aa94406129b1859--