MIME-Version: 1.0
References: <20260707185751.f9.noahmisch@microsoft.com>
In-Reply-To: <20260707185751.f9.noahmisch@microsoft.com>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Wed, 8 Jul 2026 02:49:45 +0300
Message-ID: 
 <CAPpHfdsVnD=BNHFo37sUkMCBi5EpsSJA3DYRGn5rOSdpVonpuA@mail.gmail.com>
Subject: Re: SPLIT/MERGE use of is_internal=true
To: Noah Misch <noah@leadboat.com>
Cc: d.koval@postgrespro.ru, pgsql-hackers@postgresql.org
Content-Type: multipart/mixed; boundary="00000000000062402a06560e0cfd"
Archived-At: 
 <https://www.postgresql.org/message-id/CAPpHfdsVnD%3DBNHFo37sUkMCBi5EpsSJA3DYRGn5rOSdpVonpuA%40mail.gmail.com>
Precedence: bulk

--00000000000062402a06560e0cfd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 7, 2026 at 9:57=E2=80=AFPM Noah Misch <noah@leadboat.com> wrote=
:
>
> commit f2e4cc4 wrote:
> > +/*
> > + * createPartitionTable:
> > + *
> > + * Create a new partition (newPartName) for the partitioned table (par=
ent_rel).
> > + * ownerId is determined by the partition on which the operation is pe=
rformed,
> > + * so it is passed separately.  The new partition will inherit the acc=
ess method
> > + * and persistence type from the parent table.
> > + *
> > + * Returns the created relation (locked in AccessExclusiveLock mode).
> > + */
> > +static Relation
> > +createPartitionTable(List **wqueue, RangeVar *newPartName,
> > +                                      Relation parent_rel, Oid ownerId=
)
> > +{
> ...
> > +     /* Create the relation. */
> > +     newRelId =3D heap_create_with_catalog(newPartName->relname,
> > +                                                                      =
       namespaceId,
> > +                                                                      =
       parent_relform->reltablespace,
> > +                                                                      =
       InvalidOid,
> > +                                                                      =
       InvalidOid,
> > +                                                                      =
       InvalidOid,
> > +                                                                      =
       ownerId,
> > +                                                                      =
       relamId,
> > +                                                                      =
       descriptor,
> > +                                                                      =
       NIL,
> > +                                                                      =
       RELKIND_RELATION,
> > +                                                                      =
       newPartName->relpersistence,
> > +                                                                      =
       false,
> > +                                                                      =
       false,
> > +                                                                      =
       ONCOMMIT_NOOP,
> > +                                                                      =
       (Datum) 0,
> > +                                                                      =
       true,
> > +                                                                      =
       allowSystemTableMods,
> > +                                                                      =
       true,
> > +                                                                      =
       InvalidOid,
> > +                                                                      =
       NULL);
>
> This and other places in the SPLIT/MERGE patches pass is_internal=3Dtrue,=
 which
> ultimately flows to hooks with the following meaning:
>
>         /*
>          * If this flag is set, the user hasn't requested that the object=
 be
>          * altered, but we're doing it anyway for some internal reason.
>          * Permissions-checking hooks may want to skip checks if, say, we=
're alter
>          * the constraints of a temporary heap during CLUSTER.
>          */
>         bool            is_internal;
>
> SPLIT/MERGE constitute user requests to create and/or drop tables, so the=
y're
> not like a CLUSTER temporary heap.  They should pass is_internal=3Dfalse,=
 like
> when the user runs CREATE/DROP directly.

Thank you for catching this.  For sure, we shouldn't pass
is_internal=3Dtrue here.  Attached patch fixes this.  I'm going to push
it if no objections.

------
Regards,
Alexander Korotkov
Supabase

--00000000000062402a06560e0cfd
Content-Type: application/octet-stream;
	name="v1-0001-Don-t-create-SPLIT-MERGE-partitions-as-internal-r.patch"
Content-Disposition: attachment;
	filename="v1-0001-Don-t-create-SPLIT-MERGE-partitions-as-internal-r.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mrbawdji0>
X-Attachment-Id: f_mrbawdji0

RnJvbSA3NzUzOThmNjgyMzM3OGE2ODJlYzUzNDc4ODRmZDRhOTM5MGQ5Njc5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgS29yb3Rrb3YgPGFrb3JvdGtvdkBwb3N0Z3Jl
c3FsLm9yZz4KRGF0ZTogV2VkLCA4IEp1bCAyMDI2IDAyOjQ3OjA3ICswMzAwClN1YmplY3Q6IFtQ
QVRDSCB2MV0gRG9uJ3QgY3JlYXRlIFNQTElUL01FUkdFIHBhcnRpdGlvbnMgYXMgaW50ZXJuYWwg
cmVsYXRpb25zCgpjcmVhdGVQYXJ0aXRpb25UYWJsZSgpLCB3aGljaCBidWlsZHMgdGhlIG5ldyBw
YXJ0aXRpb25zIGZvciBBTFRFUiBUQUJMRQouLi4gU1BMSVQgUEFSVElUSU9OIGFuZCBBTFRFUiBU
QUJMRSAuLi4gTUVSR0UgUEFSVElUSU9OUywgcGFzc2VkCmlzX2ludGVybmFsPXRydWUgdG8gaGVh
cF9jcmVhdGVfd2l0aF9jYXRhbG9nKCkuICBUaGVzZSByZWxhdGlvbnMgYXJlCmNyZWF0ZWQgYXQg
dGhlIGV4cGxpY2l0IHJlcXVlc3Qgb2YgdGhlIHVzZXIsIGp1c3QgbGlrZSBhIHBsYWluIENSRUFU
RQpUQUJMRSwgc28gcGFzcyBpc19pbnRlcm5hbD1mYWxzZSBpbnN0ZWFkLiAgVGhlIGlzX2ludGVy
bmFsIGZsYWcgaXMgbWVhbnQKZm9yIG9iamVjdHMgY3JlYXRlZCBhcyBhbiBpbnRlcm5hbCBpbXBs
ZW1lbnRhdGlvbiBkZXRhaWwgKGZvciBleGFtcGxlLCBhCnRyYW5zaWVudCBoZWFwIGJ1aWx0IGR1
cmluZyBDTFVTVEVSKSwgYW5kIGl0IGlzIG9ic2VydmVkIGJ5Cm9iamVjdC1hY2Nlc3MgaG9va3Mu
CgpSZXBvcnRlZC1ieTogTm9haCBNaXNjaCA8bm9haEBsZWFkYm9hdC5jb20+CkRpc2N1c3Npb246
IGh0dHBzOi8vcG9zdGdyLmVzL20vMjAyNjA3MDcxODU3NTEuZjkubm9haG1pc2NoQG1pY3Jvc29m
dC5jb20KLS0tCiBzcmMvYmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYyB8IDIgKy0KIDEgZmls
ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3Ny
Yy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFi
bGVjbWRzLmMKaW5kZXggOTVhYmFmNDg5MGMuLjBiNmE4NGIzMmI3IDEwMDY0NAotLS0gYS9zcmMv
YmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYworKysgYi9zcmMvYmFja2VuZC9jb21tYW5kcy90
YWJsZWNtZHMuYwpAQCAtMjMxMzcsNyArMjMxMzcsNyBAQCBjcmVhdGVQYXJ0aXRpb25UYWJsZShM
aXN0ICoqd3F1ZXVlLCBSYW5nZVZhciAqbmV3UGFydE5hbWUsCiAJCQkJCQkJCQkJKERhdHVtKSAw
LAogCQkJCQkJCQkJCXRydWUsCiAJCQkJCQkJCQkJYWxsb3dTeXN0ZW1UYWJsZU1vZHMsCi0JCQkJ
CQkJCQkJdHJ1ZSwKKwkJCQkJCQkJCQlmYWxzZSwJLyogaXNfaW50ZXJuYWwgKi8KIAkJCQkJCQkJ
CQlJbnZhbGlkT2lkLAogCQkJCQkJCQkJCU5VTEwpOwogCi0tIAoyLjUwLjEgKEFwcGxlIEdpdC0x
NTUpCgo=
--00000000000062402a06560e0cfd--