public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alexander Korotkov <[email protected]>
To: Alexander Lakhin <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Pavel Borisov <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Dmitry Koval <[email protected]>
Cc: [email protected]
Cc: Tomas Vondra <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Date: Sun, 26 May 2024 06:58:11 +0300
Message-ID: <CAPpHfdsuDeeoamezsox+6MaSWJLdyyYPRKKVQCccXDcqSJtaEA@mail.gmail.com> (raw)
In-Reply-To: <CAPpHfduiaby-MntcEsuj5vwifmVSCiLq6vNn8WG7OAOfE2sf3Q@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<[email protected]>
<ZjFRSVnvvGrsdndU@pryzbyj2023>
<[email protected]>
<ZjTlQiBPYm707Rxv@pryzbyj2023>
<CAPpHfduhHm+4yeObsj9wK4iZvV2Ve5xcr6BwZDFiNBYbE1PfLg@mail.gmail.com>
<CAPpHfdtgLiT2d++-qLircLB8ATUfzgR=aTmRDdF7w=2E9yDHbQ@mail.gmail.com>
<Zjvwqs-GV0MjWIhU@pryzbyj2023>
<CAPpHfdvh_XYHahtpoxfzDkvYOFUH1F5tm3JTV=sOZt8M4CTBcA@mail.gmail.com>
<ZkN6EfjQGz8TOhbL@pryzbyj2023>
<CAPpHfdvz3S7SoRiaSk9C-Juy2EzHs6NC_c9uUR0i7bymKXkvuQ@mail.gmail.com>
<CALT9ZEHCDCXvg_=9oPb99mHzJPE=+N-DOodsuE20UorY35Jkzw@mail.gmail.com>
<CAPpHfduYTTATcdm_gTr2O9NM+CeaEPy9WhL=ycaQUxGqcgnKvA@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAPpHfduiaby-MntcEsuj5vwifmVSCiLq6vNn8WG7OAOfE2sf3Q@mail.gmail.com>
On Sat, May 25, 2024 at 3:53 PM Alexander Korotkov <[email protected]> wrote:
> On Fri, May 24, 2024 at 11:00 PM Alexander Lakhin <[email protected]> wrote:
> >
> > 24.05.2024 22:29, Tom Lane wrote:
> > > The partition_split test has unstable results, as shown at [1].
> > > I suggest adding "ORDER BY conname" to the two queries shown
> > > to fail there. Better look at other queries in the test for
> > > possible similar problems, too.
> >
> > Yes, I've just reproduced it on an aarch64 device as follows:
> > echo "autovacuum_naptime = 1
> > autovacuum_vacuum_threshold = 1
> > autovacuum_analyze_threshold = 1
> > " > ~/temp.config
> > TEMP_CONFIG=~/temp.config TESTS="$(printf 'partition_split %.0s' `seq 100`)" make -s check-tests
> > ...
> > ok 80 - partition_split 749 ms
> > not ok 81 - partition_split 728 ms
> > ok 82 - partition_split 732 ms
> >
> > $ cat src/test/regress/regression.diffs
> > diff -U3 .../src/test/regress/expected/partition_split.out .../src/test/regress/results/partition_split.out
> > --- .../src/test/regress/expected/partition_split.out 2024-05-15 17:15:57.171999830 +0000
> > +++ .../src/test/regress/results/partition_split.out 2024-05-24 19:28:37.329999749 +0000
> > @@ -625,8 +625,8 @@
> > SELECT pg_get_constraintdef(oid), conname, conkey FROM pg_constraint WHERE conrelid =
> > 'sales_feb_mar_apr2022'::regclass::oid;
> > pg_get_constraintdef | conname | conkey
> > ---------------------------------------------------------------------+---------------------------------+--------
> > - CHECK ((sales_amount > 1)) | sales_range_sales_amount_check | {2}
> > FOREIGN KEY (salesperson_id) REFERENCES salespeople(salesperson_id) | sales_range_salesperson_id_fkey | {1}
> > + CHECK ((sales_amount > 1)) | sales_range_sales_amount_check | {2}
> > (2 rows)
> >
> > ALTER TABLE sales_range SPLIT PARTITION sales_feb_mar_apr2022 INTO
>
> Tom, Alexander, thank you for spotting this.
> I'm going to care about it later today.
ORDER BY is added in d53a4286d7 in these queries altogether with other
catalog queries with potentially unstable result.
------
Regards,
Alexander Korotkov
Supabase
view thread (33+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
In-Reply-To: <CAPpHfdsuDeeoamezsox+6MaSWJLdyyYPRKKVQCccXDcqSJtaEA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox