MIME-Version: 1.0
References: 
 <CAHg+QDcN-n3NUqgRtj=BQb9fFQmH8-DeEROCr=PDbw_BBRKOYA@mail.gmail.com>
 <CAPpHfdsZ6YrzX-5uenwvw1VXuG7mpBXSOT6JFTg6aCCC0SaNEg@mail.gmail.com>
 <CAHg+QDevycEwWfTMJ6ADZQJR9YSMcsAf=Dg=vH2R8Efcx1NH1w@mail.gmail.com>
In-Reply-To: 
 <CAHg+QDevycEwWfTMJ6ADZQJR9YSMcsAf=Dg=vH2R8Efcx1NH1w@mail.gmail.com>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Thu, 9 Apr 2026 15:28:16 +0300
Message-ID: 
 <CAPpHfdtJ_oZ3qJvXWAtOV4k02=m1P6AQUgoBofNgytQ3KyotbQ@mail.gmail.com>
Subject: Re: Bug: WAIT FOR LSN crashes with assertion failure inside PL/pgSQL
 DO blocks and procedures
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000055a455064f062776"
Archived-At: 
 <https://www.postgresql.org/message-id/CAPpHfdtJ_oZ3qJvXWAtOV4k02%3Dm1P6AQUgoBofNgytQ3KyotbQ%40mail.gmail.com>
Precedence: bulk

--00000000000055a455064f062776
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 9, 2026 at 10:27=E2=80=AFAM SATYANARAYANA NARLAPURAM
<satyanarlapuram@gmail.com> wrote:
> On Wed, Apr 8, 2026 at 11:00=E2=80=AFPM Alexander Korotkov <aekorotkov@gm=
ail.com> wrote:
>> On Thu, Apr 9, 2026 at 5:03=E2=80=AFAM SATYANARAYANA NARLAPURAM
>> <satyanarlapuram@gmail.com> wrote:
>> > An assertion failure (server crash in assert-enabled builds) occurs wh=
en WAIT FOR LSN ... INTO is used inside PL/pgSQL DO blocks or within void p=
rocedures.
>> >
>> > Repro:
>> >
>> > -- Run this on a standby
>> >
>> > CREATE PROCEDURE test_wait()
>> >   LANGUAGE plpgsql AS $$
>> >   DECLARE
>> >     result text;
>> >   BEGIN
>> >     WAIT FOR LSN '0/1234' INTO result;
>> >     RAISE NOTICE '%', result;
>> >   END;
>> >   $$;
>> >   CALL test_wait();
>> >
>> >
>> > The WAIT FOR itself succeeds, but the very next PL/pgSQL statement tha=
t requires a snapshot crashes the backend with:
>> >
>> >   TRAP: failed Assert("portal->portalSnapshot =3D=3D NULL"),
>> >   File: "pquery.c", Line: 1776
>> >
>> > Attached patches for both the test case and a potential fix. Please re=
view.
>>
>> Thank you for reporting.  But I doubt the fix is correct.  Even that
>> this particular might work OK, I don't think it's safe to release
>> snapshots belonging to functions/procedures: it might affect them.  I
>> tend to think we must forbid wrapping WAIT FOR LSN with
>> functions/procedures.  I'll explore more on this today.
>
>
> Agreed, attached a v2 patch with your suggestion on preventing it running
> from procedures.

Thank you.  I've slightly revised your patch.  I'm going to push it if
no objections.

------
Regards,
Alexander Korotkov
Supabase

--00000000000055a455064f062776
Content-Type: application/octet-stream;
	name="v3-0001-Explicitly-forbid-WAIT-FOR-inside-functions-and-p.patch"
Content-Disposition: attachment;
	filename="v3-0001-Explicitly-forbid-WAIT-FOR-inside-functions-and-p.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnrgd1ih0>
X-Attachment-Id: f_mnrgd1ih0

RnJvbSAwZDNiM2ExMjM1N2Y2NWRjNmZmMGFmNTRhYWJkYWY4OGRiY2QyYTliIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgS29yb3Rrb3YgPGFrb3JvdGtvdkBwb3N0Z3Jl
c3FsLm9yZz4KRGF0ZTogVGh1LCA5IEFwciAyMDI2IDE1OjAyOjMyICswMzAwClN1YmplY3Q6IFtQ
QVRDSCB2M10gRXhwbGljaXRseSBmb3JiaWQgV0FJVCBGT1IgaW5zaWRlIGZ1bmN0aW9ucyBhbmQg
cHJvY2VkdXJlcwoKUHJldmlvdXNseSB3ZSB3ZXJlIHJlbHlpbmcgb24gc25hcHNob3QtYmFzZWQg
Y2hlY2sgdG8gZGV0ZWN0IHN1Y2ggY2FzZXMuCkhvd2V2ZXIsIGl0IGFwcGVhcnMgdGhhdCB3aGVu
IFdBSVQgRk9SIGlzIHdyYXBwZWQgaW50byBhIHN0b3JlZCBwcm9jZWR1cmUKaXQgY291bGQgcGFz
cyB0aGlzIGNoZWNrIGNhdXNpbmcgYW4gZXJyb3IgZWxzZXdoZXJlLiAgVGhpcyBjb21taXQgaW1w
bG1lbnRzCmFuIGV4cGxpY2l0IGlzVG9wTGV2ZWwgY2hlY2sgdG8gcmVqZWN0IFdBSVQgRk9SIHdo
ZW4gY2FsbGVkIGZyb20gd2l0aGluCmEgZnVuY3Rpb24gb3IgcHJvY2VkdXJlLiAgVGhlIGlzVG9w
TGV2ZWwgY2hlY2sgY2F0Y2hlcyB0aGlzIGNhc2UgZWFybHkgd2l0aAphIGNsZWFyIGVycm9yIG1l
c3NhZ2UsIG1hdGNoaW5nIHRoZSBwYXR0ZXJuIHVzZWQgYnkgb3RoZXIgdXRpbGl0eSBjb21tYW5k
cwpsaWtlIFZBQ1VVTSBhbmQgUkVJTkRFWC4gIFRoZSBzbmFwc2hvdCBjaGVjayBpcyByZXRhaW5l
ZCBmb3IgdGhlIHJlbWFpbmluZwpjYXNlOiB0cmFuc2FjdGlvbnMgd2l0aCBpc29sYXRpb24gbGV2
ZWwgaGlnaGVyIHRoYW4gUkVBRCBDT01NSVRURUQuCgpBbHNvIGFkZCBhIHRlc3QgZm9yIFdBSVQg
Rk9SIExTTiB3cmFwcGVkIGluIGEgcHJvY2VkdXJlLCBjb21wbGVtZW50aW5nCnRoZSBleGlzdGlu
ZyB0ZXN0IHRoYXQgdXNlcyBhIGZ1bmN0aW9uIHdyYXBwZXIuCgpSZXBvcnRlZC1ieTogU2F0eWFu
YXJheWFuYSBOYXJsYXB1cmFtIDxzYXR5YW5hcmxhcHVyYW1AZ21haWwuY29tPgpEaXNjdXNzaW9u
OiBodHRwczovL3Bvc3Rnci5lcy9tL0NBSGclMkJRRGNOLW4zTlVxZ1J0aiUzREJRYjlmRlFtSDgt
RGVFUk9DciUzRFBEYndfQkJSS09ZQSU0MG1haWwuZ21haWwuY29tCkF1dGhvcjogU2F0eWFuYXJh
eWFuYSBOYXJsYXB1cmFtIDxzYXR5YW5hcmxhcHVyYW1AZ21haWwuY29tPgpSZXZpZXdlZC1ieTog
QWxleGFuZGVyIEtvcm90a292IDxhZWtvcm90a292QGdtYWlsLmNvbT4KLS0tCiBzcmMvYmFja2Vu
ZC9jb21tYW5kcy93YWl0LmMgICAgICAgICAgICAgfCAxNSArKysrKysrKysrKysrLS0KIHNyYy9i
YWNrZW5kL3Rjb3AvdXRpbGl0eS5jICAgICAgICAgICAgICB8ICAzICsrLQogc3JjL2luY2x1ZGUv
Y29tbWFuZHMvd2FpdC5oICAgICAgICAgICAgIHwgIDMgKystCiBzcmMvdGVzdC9yZWNvdmVyeS90
LzA0OV93YWl0X2Zvcl9sc24ucGwgfCAyMSArKysrKysrKysrKysrKysrKysrLS0KIDQgZmlsZXMg
Y2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9z
cmMvYmFja2VuZC9jb21tYW5kcy93YWl0LmMgYi9zcmMvYmFja2VuZC9jb21tYW5kcy93YWl0LmMK
aW5kZXggODVmY2Q0NjNiNGMuLmVjMTMyZTEyNWE1IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9j
b21tYW5kcy93YWl0LmMKKysrIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvd2FpdC5jCkBAIC0zMSw3
ICszMSw4IEBACiAKIAogdm9pZAotRXhlY1dhaXRTdG10KFBhcnNlU3RhdGUgKnBzdGF0ZSwgV2Fp
dFN0bXQgKnN0bXQsIERlc3RSZWNlaXZlciAqZGVzdCkKK0V4ZWNXYWl0U3RtdChQYXJzZVN0YXRl
ICpwc3RhdGUsIFdhaXRTdG10ICpzdG10LCBib29sIGlzVG9wTGV2ZWwsCisJCQkgRGVzdFJlY2Vp
dmVyICpkZXN0KQogewogCVhMb2dSZWNQdHIJbHNuOwogCWludDY0CQl0aW1lb3V0ID0gMDsKQEAg
LTEzNSw2ICsxMzYsMTYgQEAgRXhlY1dhaXRTdG10KFBhcnNlU3RhdGUgKnBzdGF0ZSwgV2FpdFN0
bXQgKnN0bXQsIERlc3RSZWNlaXZlciAqZGVzdCkKIAkJfQogCX0KIAorCS8qCisJICogV0FJVCBG
T1IgbXVzdCBub3QgcnVuIGluc2lkZSBhIGZ1bmN0aW9uIG9yIHByb2NlZHVyZS4gRm9yYmlkIHRo
aXMgY2FzZQorCSAqIHVwZnJvbnQuCisJICovCisJaWYgKCFpc1RvcExldmVsKQorCQllcmVwb3J0
KEVSUk9SLAorCQkJCShlcnJjb2RlKEVSUkNPREVfRkVBVFVSRV9OT1RfU1VQUE9SVEVEKSwKKwkJ
CQkgZXJybXNnKCIlcyBjYW5ub3QgYmUgZXhlY3V0ZWQgZnJvbSBhIGZ1bmN0aW9uIG9yIHByb2Nl
ZHVyZSIsCisJCQkJCQkiV0FJVCBGT1IiKSkpOworCiAJLyoKIAkgKiBXZSBhcmUgZ29pbmcgdG8g
d2FpdCBmb3IgdGhlIExTTi4gIFdlIHNob3VsZCBmaXJzdCBjYXJlIHRoYXQgd2UgZG9uJ3QKIAkg
KiBob2xkIGEgc25hcHNob3QgYW5kIGNvcnJlc3BvbmRpbmdseSBvdXIgTXlQcm9jLT54bWluIGlz
IGludmFsaWQuCkBAIC0xNjEsNyArMTcyLDcgQEAgRXhlY1dhaXRTdG10KFBhcnNlU3RhdGUgKnBz
dGF0ZSwgV2FpdFN0bXQgKnN0bXQsIERlc3RSZWNlaXZlciAqZGVzdCkKIAkJZXJlcG9ydChFUlJP
UiwKIAkJCQllcnJjb2RlKEVSUkNPREVfT0JKRUNUX05PVF9JTl9QUkVSRVFVSVNJVEVfU1RBVEUp
LAogCQkJCWVycm1zZygiV0FJVCBGT1IgbXVzdCBiZSBjYWxsZWQgd2l0aG91dCBhbiBhY3RpdmUg
b3IgcmVnaXN0ZXJlZCBzbmFwc2hvdCIpLAotCQkJCWVycmRldGFpbCgiV0FJVCBGT1IgY2Fubm90
IGJlIGV4ZWN1dGVkIGZyb20gYSBmdW5jdGlvbiBvciBwcm9jZWR1cmUsIG5vciB3aXRoaW4gYSB0
cmFuc2FjdGlvbiB3aXRoIGFuIGlzb2xhdGlvbiBsZXZlbCBoaWdoZXIgdGhhbiBSRUFEIENPTU1J
VFRFRC4iKSk7CisJCQkJZXJyZGV0YWlsKCJXQUlUIEZPUiBjYW5ub3QgYmUgZXhlY3V0ZWQgd2l0
aGluIGEgdHJhbnNhY3Rpb24gd2l0aCBhbiBpc29sYXRpb24gbGV2ZWwgaGlnaGVyIHRoYW4gUkVB
RCBDT01NSVRURUQuIikpOwogCiAJLyoKIAkgKiBBcyB0aGUgcmVzdWx0IHdlIHNob3VsZCBob2xk
IG5vIHNuYXBzaG90LCBhbmQgY29ycmVzcG9uZGluZ2x5IG91ciB4bWluCmRpZmYgLS1naXQgYS9z
cmMvYmFja2VuZC90Y29wL3V0aWxpdHkuYyBiL3NyYy9iYWNrZW5kL3Rjb3AvdXRpbGl0eS5jCmlu
ZGV4IDFkMzRjMTk5MTNlLi43M2E1NmYxZGYxZCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvdGNv
cC91dGlsaXR5LmMKKysrIGIvc3JjL2JhY2tlbmQvdGNvcC91dGlsaXR5LmMKQEAgLTEwNjIsNyAr
MTA2Miw4IEBAIHN0YW5kYXJkX1Byb2Nlc3NVdGlsaXR5KFBsYW5uZWRTdG10ICpwc3RtdCwKIAog
CQljYXNlIFRfV2FpdFN0bXQ6CiAJCQl7Ci0JCQkJRXhlY1dhaXRTdG10KHBzdGF0ZSwgKFdhaXRT
dG10ICopIHBhcnNldHJlZSwgZGVzdCk7CisJCQkJRXhlY1dhaXRTdG10KHBzdGF0ZSwgKFdhaXRT
dG10ICopIHBhcnNldHJlZSwgaXNUb3BMZXZlbCwKKwkJCQkJCQkgZGVzdCk7CiAJCQl9CiAJCQli
cmVhazsKIApkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvY29tbWFuZHMvd2FpdC5oIGIvc3JjL2lu
Y2x1ZGUvY29tbWFuZHMvd2FpdC5oCmluZGV4IDUyMWEzMTI5MDhkLi5hNTYzNTc5Njk1YyAxMDA2
NDQKLS0tIGEvc3JjL2luY2x1ZGUvY29tbWFuZHMvd2FpdC5oCisrKyBiL3NyYy9pbmNsdWRlL2Nv
bW1hbmRzL3dhaXQuaApAQCAtMTYsNyArMTYsOCBAQAogI2luY2x1ZGUgInBhcnNlci9wYXJzZV9u
b2RlLmgiCiAjaW5jbHVkZSAidGNvcC9kZXN0LmgiCiAKLWV4dGVybiB2b2lkIEV4ZWNXYWl0U3Rt
dChQYXJzZVN0YXRlICpwc3RhdGUsIFdhaXRTdG10ICpzdG10LCBEZXN0UmVjZWl2ZXIgKmRlc3Qp
OworZXh0ZXJuIHZvaWQgRXhlY1dhaXRTdG10KFBhcnNlU3RhdGUgKnBzdGF0ZSwgV2FpdFN0bXQg
KnN0bXQsIGJvb2wgaXNUb3BMZXZlbCwKKwkJCQkJCSBEZXN0UmVjZWl2ZXIgKmRlc3QpOwogZXh0
ZXJuIFR1cGxlRGVzYyBXYWl0U3RtdFJlc3VsdERlc2MoV2FpdFN0bXQgKnN0bXQpOwogCiAjZW5k
aWYJCQkJCQkJLyogV0FJVF9IICovCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWNvdmVyeS90LzA0
OV93YWl0X2Zvcl9sc24ucGwgYi9zcmMvdGVzdC9yZWNvdmVyeS90LzA0OV93YWl0X2Zvcl9sc24u
cGwKaW5kZXggYmY2MWI4YzQ3Y2YuLmUxMDgzMDFjY2RiIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9y
ZWNvdmVyeS90LzA0OV93YWl0X2Zvcl9sc24ucGwKKysrIGIvc3JjL3Rlc3QvcmVjb3ZlcnkvdC8w
NDlfd2FpdF9mb3JfbHNuLnBsCkBAIC0yMTUsMTAgKzIxNSwyNyBAQCAkbm9kZV9zdGFuZGJ5LT5w
c3FsKAogCSdwb3N0Z3JlcycsCiAJIlNFTEVDVCBwZ193YWxfcmVwbGF5X3dhaXRfd3JhcCgnJHts
c24zfScpOyIsCiAJc3RkZXJyID0+IFwkc3RkZXJyKTsKLW9rKCAkc3RkZXJyID1+Ci0JICAvV0FJ
VCBGT1IgbXVzdCBiZSBjYWxsZWQgd2l0aG91dCBhbiBhY3RpdmUgb3IgcmVnaXN0ZXJlZCBzbmFw
c2hvdC8sCitvaygkc3RkZXJyID1+IC9XQUlUIEZPUiBjYW5ub3QgYmUgZXhlY3V0ZWQgZnJvbSBh
IGZ1bmN0aW9uIG9yIHByb2NlZHVyZS8sCiAJImdldCBhbiBlcnJvciB3aGVuIHJ1bm5pbmcgd2l0
aGluIGFub3RoZXIgZnVuY3Rpb24iKTsKIAorJG5vZGVfcHJpbWFyeS0+c2FmZV9wc3FsKAorCSdw
b3N0Z3JlcycsIHFxWworQ1JFQVRFIFBST0NFRFVSRSBwZ193YWxfcmVwbGF5X3dhaXRfcHJvYyh0
YXJnZXRfbHNuIHBnX2xzbikgQVMgXCRcJAorICBCRUdJTgorICAgIEVYRUNVVEUgZm9ybWF0KCdX
QUlUIEZPUiBMU04gJUw7JywgdGFyZ2V0X2xzbik7CisgIEVORAorXCRcJAorTEFOR1VBR0UgcGxw
Z3NxbDsKK10pOworCiskbm9kZV9wcmltYXJ5LT53YWl0X2Zvcl9jYXRjaHVwKCRub2RlX3N0YW5k
YnkpOworJG5vZGVfc3RhbmRieS0+cHNxbCgKKwkncG9zdGdyZXMnLAorCSJDQUxMIHBnX3dhbF9y
ZXBsYXlfd2FpdF9wcm9jKCcke2xzbjN9Jyk7IiwKKwlzdGRlcnIgPT4gXCRzdGRlcnIpOworb2so
JHN0ZGVyciA9fiAvV0FJVCBGT1IgY2Fubm90IGJlIGV4ZWN1dGVkIGZyb20gYSBmdW5jdGlvbiBv
ciBwcm9jZWR1cmUvLAorCSJnZXQgYW4gZXJyb3Igd2hlbiBydW5uaW5nIHdpdGhpbiBhIHByb2Nl
ZHVyZSIpOworCiAjIDYuIENoZWNrIHBhcmFtZXRlciB2YWxpZGF0aW9uIGVycm9yIGNhc2VzIG9u
IHN0YW5kYnkgYmVmb3JlIHByb21vdGlvbgogbXkgJHRlc3RfbHNuID0KICAgJG5vZGVfcHJpbWFy
eS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsICJTRUxFQ1QgcGdfY3VycmVudF93YWxfaW5zZXJ0X2xz
bigpIik7Ci0tIAoyLjM5LjUgKEFwcGxlIEdpdC0xNTQpCgo=
--00000000000055a455064f062776--