MIME-Version: 1.0
References: 
 <CAPpHfdt_dN5vyQQsTV=yeD+guDW7H7cvfkKj_mSETT0BEbyL+Q@mail.gmail.com>
 <CAPpHfdvK8XS-FvXSxcEr-=azS3SHJo3b0yrQCq4uOv4fsw0JGw@mail.gmail.com>
 <87y12i8i6f.fsf@wibble.ilmari.org>
 <f8d8d179-ad31-4b46-aaef-3916be8bc8af@gmail.com>
 <CAPpHfdvMVevMxAob4Yav9LyW2a4nrWqxUVQ8K1=Hs7EjOPQk1w@mail.gmail.com>
 <87v7xl92x2.fsf@wibble.ilmari.org>
 <CAPpHfduqZFZYL63Yx92pfAyiS8ACXyXSsnV1Geb_ecJTTU=Pmg@mail.gmail.com>
 <CAPpHfdtHjPuLPoLGAqeUnttxy-PooJNB4piiZraLXK2C8e8vwg@mail.gmail.com>
 <CALT9ZEHh4-K5ofp+EKO8MdCQJWMWkrq3mZstWPJda8feSdnT-g@mail.gmail.com>
 <CAPpHfdv=WVCbzdpoTxvXzUZZEqu_pDk2YZBnEGpUCrzuHxPN6w@mail.gmail.com>
 <20250411203241.e9.nmisch@google.com>
In-Reply-To: <20250411203241.e9.nmisch@google.com>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Sat, 12 Apr 2025 00:43:19 +0300
Message-ID: 
 <CAPpHfdtRvDtoVCN0fMVCUDong2eX-o4ATKJCQ9F0epPmm83rZA@mail.gmail.com>
Subject: Re: type cache cleanup improvements
To: Noah Misch <noah@leadboat.com>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>,
 =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
	Andrei Lepikhov <lepihov@gmail.com>, jian he <jian.universality@gmail.com>,
	Artur Zakirov <zaartur@gmail.com>, Alexander Lakhin <exclusion@gmail.com>,
	Teodor Sigaev <teodor@sigaev.ru>,
 Pgsql Hackers <pgsql-hackers@postgresql.org>,
	Aleksander Alekseev <aleksander@timescale.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Michael Paquier <michael@paquier.xyz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAPpHfdtRvDtoVCN0fMVCUDong2eX-o4ATKJCQ9F0epPmm83rZA%40mail.gmail.com>
Precedence: bulk

On Fri, Apr 11, 2025 at 11:32=E2=80=AFPM Noah Misch <noah@leadboat.com> wro=
te:
>
> On Tue, Oct 22, 2024 at 08:33:24PM +0300, Alexander Korotkov wrote:
> > On Tue, Oct 22, 2024 at 6:10=E2=80=AFPM Pavel Borisov <pashkin.elfe@gma=
il.com> wrote:
> > > On Tue, 22 Oct 2024 at 11:34, Alexander Korotkov <aekorotkov@gmail.co=
m> wrote:
> > >> I'm going to push this if no objections.
>
> (This became commit b85a9d0.)
>
> > +     /* Call delete_rel_type_cache() if we actually cleared something =
*/
> > +     if (hadTupDescOrOpclass)
> > +             delete_rel_type_cache_if_needed(typentry);
>
> I think the intent was to maintain the invariant that a RelIdToTypeIdCach=
eHash
> entry exists if and only if certain kinds of data appear in the TypeCache=
Hash
> entry.  However, TypeCacheOpcCallback() clears TCFLAGS_OPERATOR_FLAGS wit=
hout
> maintaining RelIdToTypeIdCacheHash.  Is it right to do that?

Thank you for the question.  I'll recheck this in next couple of days.

------
Regards,
Alexander Korotkov
Supabase