Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1scBqx-004k8u-QP for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Aug 2024 22:43:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1scBqw-00HQJ4-6y for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Aug 2024 22:43:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1scBqv-00HQHJ-So for pgsql-hackers@lists.postgresql.org; Thu, 08 Aug 2024 22:43:25 +0000 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1scBqt-003mOL-GL for pgsql-hackers@lists.postgresql.org; Thu, 08 Aug 2024 22:43:24 +0000 Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-e02b79c6f21so1419806276.2 for ; Thu, 08 Aug 2024 15:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723157003; x=1723761803; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t1FQISBUiTrdrB80x4cQ0MpziNeMYcyrdQxtfA320mY=; b=ie8MA5DyBZJbQfXd4UAkAFIJLppLjIYp2Z6uch28/5XeQAFK3yKpcTFdPvB8fxGjz/ hpuLN/Tmn0ABC1dQdkDAzeMKnR5eLtUSvePAGxVuWPqyaT5Zvxup3mky3iEwb/yYpcIP McM+YauhcY422DBBx6119VBoOPP1FFHAJs1T1EgVyAe3AFiuwZvNuv/lDx+LMzZMlf9W gUaqaL+WIZBpv/ilgNaDjRNnrRl7nKVGFiqziJvlqCoy1wq0Lsiw+kLEj3EfOrpmdnbW QgWYlJRdBUjEBF1DuFsSrTqVlUprz0II5xPvA/SlAAUaADAK7k8Y2sPYlXCJoxCWS13u RyiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723157003; x=1723761803; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t1FQISBUiTrdrB80x4cQ0MpziNeMYcyrdQxtfA320mY=; b=vuweYUsUnOJjrVpdVu19VhHEBoZdwh9bUNpAX11eJYQQfMtaggYK6lXfpU09Yky5ZI qfENVpohdkYJl47w/lPsuVeEW28d+H7dpzFnlzz3Thrdsh2PV50rtTsPEv5JGAqPULOd ZcXRWE2ULWBxuoCfwHZ3DOumausTb4gr+/4Jj2ZoC4f0lpy4BXkHwWUIjaKEqCpKcKJ4 GICZLpZLdflwR6g117yMVzI/R6qMbUQlU3td8oaQE/QIsM/SCp0tAl7dt6tKRimo0P32 M4IrsraSTCyXuJLAlLeigzK+w2nELKuT5dYz1DO6ghpRrHlfxUFMZ0R1NoY2/C1LwcxH 0GgA== X-Forwarded-Encrypted: i=1; AJvYcCWTgmW1oG41VxZ47Qyr2JqVQ/jSsrygPi5xhf40hxpAxChWJHdQrq9IjhJNS3BPHcEyukS719dz+q8so96LaVA9NFF7klHsOE89t8AvHx3m2P+L X-Gm-Message-State: AOJu0YzgSWdWCHZgnKMzR8NSw/TktZd97tBLwZNdU9D4YfzsIs6BSXmZ 2GukliaC7NkfKLMmyzPuACdk0p/TrqJnWWEV9Q+a5BBluHWLhcXdUQflKZtCTtijIQOpEFV0K7s 2Ub6sxmpqNJIsO1oflBvsXQzLK/A= X-Google-Smtp-Source: AGHT+IFd4O6aFjbogjBPErIK0iSeJhO9ThUbOd80p/eVkphDuZYjmzHwFqRgywyzameDqlEk/xI3+PTnuzeSO/X+lqQ= X-Received: by 2002:a05:6902:c0c:b0:e0b:c07c:80ec with SMTP id 3f1490d57ef6-e0e9dc8a2a5mr4637239276.46.1723157002596; Thu, 08 Aug 2024 15:43:22 -0700 (PDT) MIME-Version: 1.0 References: <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org> <171085858750.2046434.12246066729700037354.pgcf@coridan.postgresql.org> <909e16b4-9eda-435c-b033-8294ae4adc05@postgrespro.ru> <3a4b9c1c-3edf-4e29-9629-b4113aefb0f3@postgrespro.ru> <20240808171351.a9.nmisch@google.com> In-Reply-To: <20240808171351.a9.nmisch@google.com> From: Alexander Korotkov Date: Fri, 9 Aug 2024 01:43:11 +0300 Message-ID: Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands To: Noah Misch Cc: Dmitry Koval , pgsql-hackers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Aug 8, 2024 at 8:14=E2=80=AFPM Noah Misch wrote= : > On Sun, Apr 07, 2024 at 01:22:51AM +0300, Alexander Korotkov wrote: > > I've pushed 0001 and 0002 > > The partition MERGE (1adf16b8f) and SPLIT (87c21bb94) v17 patches introdu= ced > createPartitionTable() with this code: > > createStmt->relation =3D newPartName; > ... > wrapper->utilityStmt =3D (Node *) createStmt; > ... > ProcessUtility(wrapper, > ... > newRel =3D table_openrv(newPartName, NoLock); > > This breaks from the CVE-2014-0062 (commit 5f17304) principle of not repe= ating > name lookups. The attached demo uses this defect to make one partition h= ave > two parents. Thank you for a valuable report. I will dig into and fix that. ------ Regards, Alexander Korotkov Supabase