MIME-Version: 1.0
References: <ZnDx2FYlba_OafQd@momjian.us> <0a352a79-efaf-4e2f-884c-0630e57c6980@gmail.com>
In-Reply-To: <0a352a79-efaf-4e2f-884c-0630e57c6980@gmail.com>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Tue, 18 Jun 2024 15:13:11 +0300
Message-ID: <CAPpHfdtmVCrsEYWhugW9VRNGBCcmOVNa5-MtdvfJgwpNrMRAsQ@mail.gmail.com>
Subject: Re: Missing docs for new enable_group_by_reordering GUC
To: Andrei Lepikhov <lepihov@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000001ead07061b2902b9"
Archived-At: <https://www.postgresql.org/message-id/CAPpHfdtmVCrsEYWhugW9VRNGBCcmOVNa5-MtdvfJgwpNrMRAsQ%40mail.gmail.com>
Precedence: bulk

--0000000000001ead07061b2902b9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 18, 2024 at 9:14=E2=80=AFAM Andrei Lepikhov <lepihov@gmail.com>=
 wrote:
> On 6/18/24 09:32, Bruce Momjian wrote:
> > This commit added enable_group_by_reordering:
> >
> >       commit 0452b461bc4
> >       Author: Alexander Korotkov <akorotkov@postgresql.org>
> >       Date:   Sun Jan 21 22:21:36 2024 +0200
> > It mentions it was added as a GUC to postgresql.conf, but I see no SGML
> > docs for this new GUC value.  Would someone please add docs for this?
> > Thanks.
> It is my mistake, sorry for that. See the patch in attachment.

Bruce, thank for noticing.  Andrei, thank you for providing a fix.
Please, check the revised patch.

------
Regards,
Alexander Korotkov
Supabase

--0000000000001ead07061b2902b9
Content-Type: application/octet-stream; 
	name="v2-0001-Add-doc-entry-for-the-new-GUC-paramenter-enable_g.patch"
Content-Disposition: attachment; 
	filename="v2-0001-Add-doc-entry-for-the-new-GUC-paramenter-enable_g.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lxkd7m4r0>
X-Attachment-Id: f_lxkd7m4r0

RnJvbSBmNDQ0MzZiOWViZDNmNjNjZGQ0ZDFkM2UxYjQ2YThmNjYwZTVlZGFjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgS29yb3Rrb3YgPGFrb3JvdGtvdkBwb3N0Z3Jl
c3FsLm9yZz4KRGF0ZTogVHVlLCAxOCBKdW4gMjAyNCAxNTowODoxNyArMDMwMApTdWJqZWN0OiBb
UEFUQ0ggdjJdIEFkZCBkb2MgZW50cnkgZm9yIHRoZSBuZXcgR1VDIHBhcmFtZW50ZXIKIGVuYWJs
ZV9ncm91cF9ieV9yZW9yZGVyaW5nCgowNDUyYjQ2MWJjNCBhZGRzIGFsdGVybmF0aXZlIG9yZGVy
aW5ncyBvZiBncm91cC1ieSBrZXlzIGR1cmluZyB0aGUgcXVlcnkKb3B0aW1pemF0aW9uLiBUaGlz
IG5ldyBmZWF0dXJlIGlzIGNvbnRyb2xsZWQgYnkgdGhlIG5ldyBHVUMgcGFyYW1ldGVyCmVuYWJs
ZV9ncm91cF9ieV9yZW9yZGVyaW5nLCB3aGljaCBhY2NpZGVudGFsbHkgY2FtZSB3aXRob3V0IHRo
ZSBkb2N1bWVudGF0aW9uLgpUaGlzIGNvbW1pdCBhZGRzIHRoZSBtaXNzaW5nIGRvY3VtZW50YXRp
b24gZm9yIHRoYXQgR1VDLgoKUmVwb3J0ZWQtYnk6IEJydWNlIE1vbWppYW4KRGlzY3Vzc2lvbjog
aHR0cHM6Ly9wb3N0Z3IuZXMvbS9abkR4MkZZbGJhX09hZlFkJTQwbW9tamlhbi51cwpBdXRob3I6
IEFuZHJlaSBMZXBpa2hvdgotLS0KIGRvYy9zcmMvc2dtbC9jb25maWcuc2dtbCB8IDE4ICsrKysr
KysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKykKCmRpZmYgLS1n
aXQgYS9kb2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwgYi9kb2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwK
aW5kZXggNjk4MTY5YWZkYjYuLmQ0NWNiMDJhZDE1IDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwv
Y29uZmlnLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2NvbmZpZy5zZ21sCkBAIC01MzI3LDYgKzUz
MjcsMjQgQEAgQU5ZIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj5udW1fc3luYzwvcmVw
bGFjZWFibGU+ICggPHJlcGxhY2VhYmxlIGNsYXNzPSIKICAgICAgIDwvbGlzdGl0ZW0+CiAgICAg
IDwvdmFybGlzdGVudHJ5PgogCisgICAgIDx2YXJsaXN0ZW50cnkgaWQ9Imd1Yy1lbmFibGUtZ3Jv
dXBieS1yZW9yZGVyaW5nIiB4cmVmbGFiZWw9ImVuYWJsZV9ncm91cF9ieV9yZW9yZGVyaW5nIj4K
KyAgICAgIDx0ZXJtPjx2YXJuYW1lPmVuYWJsZV9ncm91cF9ieV9yZW9yZGVyaW5nPC92YXJuYW1l
PiAoPHR5cGU+Ym9vbGVhbjwvdHlwZT4pCisgICAgICA8aW5kZXh0ZXJtPgorICAgICAgIDxwcmlt
YXJ5Pjx2YXJuYW1lPmVuYWJsZV9ncm91cF9ieV9yZW9yZGVyaW5nPC92YXJuYW1lPiBjb25maWd1
cmF0aW9uIHBhcmFtZXRlcjwvcHJpbWFyeT4KKyAgICAgIDwvaW5kZXh0ZXJtPgorICAgICAgPC90
ZXJtPgorICAgICAgPGxpc3RpdGVtPgorICAgICAgIDxwYXJhPgorICAgICAgICBFbmFibGVzIG9y
IGRpc2FibGVzIHRoZSByZW9yZGVyaW5nIG9mIGtleXMgaW4gYQorICAgICAgICA8bGl0ZXJhbD5H
Uk9VUCBCWTwvbGl0ZXJhbD4gY2xhdXNlIHRvIG1hdGNoIHRoZSBvcmRlcmluZyBrZXlzIG9mIGEK
KyAgICAgICAgY2hpbGQgbm9kZSBvZiB0aGUgcGxhbiwgc3VjaCBhcyBhbiBpbmRleCBzY2FuLiBX
aGVuIHR1cm5lZCBvZmYsIGtleXMKKyAgICAgICAgaW4gYSA8bGl0ZXJhbD5HUk9VUCBCWTwvbGl0
ZXJhbD4gY2xhdXNlIGFyZSBvbmx5IHJlb3JkZXJlZCB0byBtYXRjaAorICAgICAgICB0aGUgPGxp
dGVyYWw+T1JERVIgQlk8L2xpdGVyYWw+IGNsYXVzZSwgaWYgYW55LiBUaGUgZGVmYXVsdCBpcwor
ICAgICAgICA8bGl0ZXJhbD5vbjwvbGl0ZXJhbD4uCisgICAgICAgPC9wYXJhPgorICAgICAgPC9s
aXN0aXRlbT4KKyAgICAgPC92YXJsaXN0ZW50cnk+CisKICAgICAgPHZhcmxpc3RlbnRyeSBpZD0i
Z3VjLWVuYWJsZS1nYXRoZXJtZXJnZSIgeHJlZmxhYmVsPSJlbmFibGVfZ2F0aGVybWVyZ2UiPgog
ICAgICAgPHRlcm0+PHZhcm5hbWU+ZW5hYmxlX2dhdGhlcm1lcmdlPC92YXJuYW1lPiAoPHR5cGU+
Ym9vbGVhbjwvdHlwZT4pCiAgICAgICA8aW5kZXh0ZXJtPgotLSAKMi4zOS4zIChBcHBsZSBHaXQt
MTQ1KQoK
--0000000000001ead07061b2902b9--