MIME-Version: 1.0
References: <CABPTF7Xs-64GQNjmbimZNhj2YSKbBny+evz6=cp3X2fkJS+vMQ@mail.gmail.com>
 <202601011659.ikh4ku4p3ovb@alvherre.pgsql>
In-Reply-To: <202601011659.ikh4ku4p3ovb@alvherre.pgsql>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Fri, 2 Jan 2026 01:42:34 +0200
Message-ID: <CAPpHfduDVNo4VXgnQFZUg9=2yHQJfUUqjokbi3qVxuJiKNfcwg@mail.gmail.com>
Subject: Re: Implement waiting for wal lsn replay: reloaded
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: Xuneng Zhou <xunengzhou@gmail.com>, Chao Li <li.evan.chao@gmail.com>, 
	pgsql-hackers <pgsql-hackers@lists.postgresql.org>, Andres Freund <andres@anarazel.de>, 
	Michael Paquier <michael@paquier.xyz>, jian he <jian.universality@gmail.com>, 
	Tomas Vondra <tomas@vondra.me>, Yura Sokolov <y.sokolov@postgrespro.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAPpHfduDVNo4VXgnQFZUg9%3D2yHQJfUUqjokbi3qVxuJiKNfcwg%40mail.gmail.com>
Precedence: bulk

On Thu, Jan 1, 2026 at 7:16=E2=80=AFPM =C3=81lvaro Herrera <alvherre@kurile=
mu.de> wrote:
> In 0002 you have this kind of thing:
>
> >                               ereport(ERROR,
> >                                               errcode(ERRCODE_QUERY_CAN=
CELED),
> > -                                             errmsg("timed out while w=
aiting for target LSN %X/%08X to be replayed; current replay LSN %X/%08X",
> > +                                             errmsg("timed out while w=
aiting for target LSN %X/%08X to be %s; current %s LSN %X/%08X",
> >                                                          LSN_FORMAT_ARG=
S(lsn),
> > -                                                        LSN_FORMAT_ARG=
S(GetXLogReplayRecPtr(NULL))));
> > +                                                        desc->verb,
> > +                                                        desc->noun,
> > +                                                        LSN_FORMAT_ARG=
S(currentLSN)));
> > +                     }
>
>
> I'm afraid this technique doesn't work, for translatability reasons.
> Your whole design of having a struct with ->verb and ->noun is not
> workable (which is a pity, but you can't really fight this.) You need to
> spell out the whole messages for each case, something like
>
> if (lsntype =3D=3D replay)
>    ereport(ERROR,
>            errcode(ERRCODE_QUERY_CANCELED),
>            errmsg("timed out while waiting for target LSN %X/%08X to be r=
eplayed; current standby_replay LSN %X/%08X",
> else if (lsntype =3D=3D flush)
>     ereport( ... )
>
> and so on.  This means four separate messages for translation for each
> message your patch is adding, which is IMO the correct approach.

+1
Thank you for catching this, Alvaro.  Yes, I think we need to get rid
of WaitLSNTypeDesc.  It's nice idea, but we support too many languages
to have something like this.

------
Regards,
Alexander Korotkov
Supabase