MIME-Version: 1.0
References: 
 <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org>
 <CAPpHfdsh_jPZ6-2JtWoFeZravVQYY4cYCcnKXQW6KxEx+F5vxg@mail.gmail.com>
 <2643645f-2a02-43de-9321-c995ab1b7ef8@postgrespro.ru>
 <CACJufxF1Hfx1PST7pCLrKkGcjHEn2A51znXmYwVccnt5GDORcw@mail.gmail.com>
 <57a94d8a-d7b6-4c5e-9001-be1cd403b172@postgrespro.ru>
 <54414932-9E82-47AA-902B-2DED18F07F64@gmail.com>
 <e7da0ceb-8a01-4856-8c87-f87f09b4a9ad@postgrespro.ru>
 <CACJufxET9Qe-=zJtjGrKPr7-1QbVcP9y-vJU9CMEDfPGt_dbyg@mail.gmail.com>
 <3280c458-a886-4c58-8e2b-4d220b73161d@postgrespro.ru>
 <CACJufxEBvrtcOWyX2NMwOCvb2ZvaRGaGeiMQpUD=yxL6ncBFOg@mail.gmail.com>
 <dbe8e3ac-0b85-4809-bfaf-1d11f3c9d814@postgrespro.ru>
 <CAPpHfdvSBR+sbsRCAybN949tOGArQvMH2QeDXf2L=7NDMNbJfw@mail.gmail.com>
 <b96a16a5-02de-4cc2-afb4-fbccba43eb54@postgrespro.ru>
 <CAPpHfduQwwa4ytK-dGjRGN0fTWfpWNNysYuUKrOetsyGioBMfA@mail.gmail.com>
 <09414bf8-9326-431c-9422-b13bddf5f554@postgrespro.ru>
 <CAPpHfdvpzezTnuumpdJYge=x1TbhgAkjMGh2GHnScf5SFsf2ew@mail.gmail.com>
 <29ff27f5-d359-4479-b11c-ce28e525d806@postgrespro.ru>
 <CAPpHfdtBH5YhAiKhXPcLAE4CCRMaGKqupzx8u2RKEm2aQ_e3Xw@mail.gmail.com>
 <CA+gpmfLSELzEKEzSFXeLkRRMGkRfm2+7ewXHyW-8ZWPbWOywyg@mail.gmail.com>
 <CAPpHfdtnWkesztu4qq1m8RfuR2OYXd5tbPyaHk-3Db2szWrb=Q@mail.gmail.com>
 <CAPpHfdta0DMb3XjePJJWf1xbAndE8w2uYPaWEOFBGQ=xsDkfiQ@mail.gmail.com>
 <tencent_3661BB522D5466B33EA33666@qq.com>
 <CAPpHfdvt64X0F3thjC0q9vOTU-JqG2M_MJfEeA2-_=odNOA3Dg@mail.gmail.com>
 <tencent_6DB357447E187E6516DFD9C1@qq.com>
 <CAPpHfdu8wPv6hes7v95fF__N1pkPG1yS3YumKUGmS_jdF2RtrA@mail.gmail.com>
 <CAHewXNmBM+5qbrJMu60NxPn+0y-=2wXM-QVVs3xRp8NxFvDb9A@mail.gmail.com>
 <CAPpHfdvs-U0HQWnhe8e7B=K5k=c9FvvA39UcqnmNoLqbkgAfjw@mail.gmail.com>
 <CAHewXNnBNVgj91xxm29nrJUeVcZd6WvUXAvnx1abJnC7vZgxAQ@mail.gmail.com>
 <CALdSSPgT4-epuBeVy3pF61gT1WbwoDXh9uYwqtR7PktFQVQzig@mail.gmail.com>
In-Reply-To: 
 <CALdSSPgT4-epuBeVy3pF61gT1WbwoDXh9uYwqtR7PktFQVQzig@mail.gmail.com>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Mon, 22 Dec 2025 00:02:22 +0200
Message-ID: 
 <CAPpHfdudazH3uQimTv=4ztU4M9j04CeQAcPZMVSbD-dYwuh=6w@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: Tender Wang <tndrwang@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAPpHfdudazH3uQimTv%3D4ztU4M9j04CeQAcPZMVSbD-dYwuh%3D6w%40mail.gmail.com>
Precedence: bulk

On Sun, Dec 21, 2025 at 9:42=E2=80=AFAM Kirill Reshke <reshkekirill@gmail.c=
om> wrote:
> On Sun, 21 Dec 2025, 12:14 Tender Wang, <tndrwang@gmail.com> wrote:
>> Alexander Korotkov <aekorotkov@gmail.com> =E4=BA=8E2025=E5=B9=B412=E6=9C=
=8820=E6=97=A5=E5=91=A8=E5=85=AD 19:08=E5=86=99=E9=81=93=EF=BC=9A
>>> I agree with you that ERRCODE_UNDEFINED_TABLE is certainly wrong error
>>> code because the table actually exists.  ERRCODE_WRONG_OBJECT_TYPE is
>>> better.  For example, we throw it when trying to attach a partition to
>>> non-partitioned table.  So, the parent table type is wrong.  However,
>>> are objects in the situation under consideration really have wrong
>>> type?  The problem is that one table is not partition of another.
>>> However, it's possibly that they could be attached without changing of
>>> their types.  So, I think about
>>> ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE.  What do you think?
>>
>>
>> It's ok for me. Please check the v2 patch.
>
>
> Hi! Your v2 looks fine
> The only question for me is, should we add any regression test to exercis=
e this code, or it is not worth the troubles?

I've checked contents of out regression tests.  I see we very rarely
include SQLSTATE there, mostly in psql and plpgsql tests.  Thus, I
think we should just fix the SQLSTATE without dedicating a test for
that.  So, I'm going to push the patch from Tender Wang if no
objections.

------
Regards,
Alexander Korotkov
Supabase