MIME-Version: 1.0
References: 
 <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org>
 <CA+TgmoY0=bT_xBP8csR=MFE=FxGE2n2-me2-31jBOgEcLvW7ug@mail.gmail.com>
 <CAPpHfdtp3_H_Rp1ubVYGUnnF0fXbam7+OOG_EMnWos1x2a_3Zg@mail.gmail.com>
 <859476bf-3cb0-455e-b093-b8ab5ef17f0e@postgrespro.ru>
 <CA+TgmoZux8hzQ0=1-Rvigm9VuojW0aHiGSzL+G_g43qyrLGiSg@mail.gmail.com>
 <f56c654f-f152-4dc8-b221-4d4484bed612@postgrespro.ru>
 <CAPpHfdtXDuBaHscJn-wada6Kaf3fxmS4k-1TTVhpS+Kx=uveyw@mail.gmail.com>
 <4e2764f7-f6be-478f-8d7f-f921dbd10f5f@postgrespro.ru>
 <CAPpHfdv2V2tsvVn5LYyrJkzmPA==vbdCEKiT8j9yaaiDTfaQtA@mail.gmail.com>
 <ff30dc7e-ebca-42a2-9d49-a66c9a3c7ee5@postgrespro.ru>
 <CALDaNm3V5DQSbZGxhYH+3MMMm-YdgOg+RdJ-ni6D0TZx_=Xd7w@mail.gmail.com>
 <7fdaf3e8-4c05-4739-bee6-98acc068d1c7@postgrespro.ru>
 <CAPpHfduH83+CW1dBppFVjxauPFGC+-ux+Y7wB0koZJCs029SXA@mail.gmail.com>
 <4433b492-9e97-4334-96d9-ddaaa5083099@postgrespro.ru>
 <CACJufxEi_JVg+=_BSS0o+TYUE_Hq+jmga_yxxuKLSGbQiAnZDg@mail.gmail.com>
 <67ecf5fb-e63d-4284-be75-d0479eef81aa@postgrespro.ru>
In-Reply-To: <67ecf5fb-e63d-4284-be75-d0479eef81aa@postgrespro.ru>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Thu, 5 Jun 2025 04:41:47 +0300
Message-ID: 
 <CAPpHfdugpFGUk-udjcroJLi6_5ypS9-3CxoC+MbRvpjncDy11w@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Dmitry Koval <d.koval@postgrespro.ru>
Cc: jian he <jian.universality@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000001f33c00636c9383a"
Archived-At: 
 <https://www.postgresql.org/message-id/CAPpHfdugpFGUk-udjcroJLi6_5ypS9-3CxoC%2BMbRvpjncDy11w%40mail.gmail.com>
Precedence: bulk

--0000000000001f33c00636c9383a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Dmitry!

On Wed, Jun 4, 2025 at 10:44=E2=80=AFPM Dmitry Koval <d.koval@postgrespro.r=
u> wrote:
> Thank you very much for review.

Thank you for your work on this patch.  I have some additional notes on
this patch.

Why don't you use *existing_relation_id argument of
RangeVarGetAndCheckCreationNamespace(), when it is called from
createPartitionTable() and ATExecSplitPartition()?  This argument provide
an elegant way to find a duplicate table with the same name.

It also seems that 0002 patch has the following error message, which aren't
experienced in the regression tests.

+                   datum =3D list_nth(spec->upperdatums, abs(cmpval) - 1);
+                   ereport(ERROR,
+                           errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
+                           errmsg("upper bound of partition \"%s\" is not
equal to upper bound of split partition",
+                                  relname),
+                           parser_errposition(pstate, datum->location));


+               ereport(ERROR,
+                       errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
+                       errmsg("new partition \"%s\" cannot have this value
because split partition does not have",
+                              relname),
+                       parser_errposition(pstate, overlap_location));


+       ereport(ERROR,
+               errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
+               errmsg("new partitions do not have value %s but split
partition does",
+                      searchNull ? "NULL" :
get_list_partvalue_string(notFoundVal)));


+                           ereport(ERROR,
+
errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
+                                   errmsg("DEFAULT partition should be
one"),
+                                   parser_errposition(pstate,
sps->name->location));

+       ereport(ERROR,
+               errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
+               errmsg("one partition in the list should be DEFAULT because
split partition is DEFAULT"),
+               parser_errposition(pstate, ((SinglePartitionSpec *)
linitial(partlist))->name->location));


+       ereport(ERROR,
+               errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
+               errmsg("new partition cannot be DEFAULT because DEFAULT
partition already exists"),
+               parser_errposition(pstate, spsDef->name->location));

+               ereport(ERROR,
+                       errcode(ERRCODE_CHECK_VIOLATION),
+                       errmsg("can not find partition for split partition
row"),
+                       errtable(splitRel));

------
Regards,
Alexander Korotkov
Supabase

--0000000000001f33c00636c9383a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: base64

PGRpdiBkaXI9Imx0ciI+SGkgRG1pdHJ5ITxicj48YnI+T24gV2VkLCBKdW4gNCwgMjAyNSBhdCAx
MDo0NOKAr1BNIERtaXRyeSBLb3ZhbCAmbHQ7PGEgaHJlZj0ibWFpbHRvOmQua292YWxAcG9zdGdy
ZXNwcm8ucnUiPmQua292YWxAcG9zdGdyZXNwcm8ucnU8L2E+Jmd0OyB3cm90ZTo8YnI+Jmd0OyBU
aGFuayB5b3UgdmVyeSBtdWNoIGZvciByZXZpZXcuPGJyPjxicj5UaGFuayB5b3UgZm9yIHlvdXIg
d29yayBvbiB0aGlzIHBhdGNoLsKgIEkgaGF2ZSBzb21lIGFkZGl0aW9uYWwgbm90ZXMgb24gdGhp
cyBwYXRjaC48YnI+PGJyPldoeSBkb24mIzM5O3QgeW91IHVzZSAqZXhpc3RpbmdfcmVsYXRpb25f
aWQgYXJndW1lbnQgb2YgUmFuZ2VWYXJHZXRBbmRDaGVja0NyZWF0aW9uTmFtZXNwYWNlKCksIHdo
ZW4gaXQgaXMgY2FsbGVkIGZyb20gY3JlYXRlUGFydGl0aW9uVGFibGUoKSBhbmQgQVRFeGVjU3Bs
aXRQYXJ0aXRpb24oKT/CoCBUaGlzIGFyZ3VtZW50IHByb3ZpZGUgYW4gZWxlZ2FudCB3YXkgdG8g
ZmluZCBhIGR1cGxpY2F0ZSB0YWJsZSB3aXRoIHRoZSBzYW1lIG5hbWUuPGJyPjxicj5JdCBhbHNv
IHNlZW1zIHRoYXQgMDAwMiBwYXRjaCBoYXMgdGhlIGZvbGxvd2luZyBlcnJvciBtZXNzYWdlLCB3
aGljaCBhcmVuJiMzOTt0IGV4cGVyaWVuY2VkIGluIHRoZSByZWdyZXNzaW9uIHRlc3RzLjxicj48
YnI+PGZvbnQgZmFjZT0ibW9ub3NwYWNlIj4rIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGRh
dHVtID0gbGlzdF9udGgoc3BlYy0mZ3Q7dXBwZXJkYXR1bXMsIGFicyhjbXB2YWwpIC0gMSk7PGJy
PisgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgZXJlcG9ydChFUlJPUiw8YnI+KyDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9P
QkpFQ1RfREVGSU5JVElPTiksPGJyPisgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
wqAgwqAgZXJybXNnKCZxdW90O3VwcGVyIGJvdW5kIG9mIHBhcnRpdGlvbiBcJnF1b3Q7JXNcJnF1
b3Q7IGlzIG5vdCBlcXVhbCB0byB1cHBlciBib3VuZCBvZiBzcGxpdCBwYXJ0aXRpb24mcXVvdDss
PGJyPisgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBy
ZWxuYW1lKSw8YnI+KyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBwYXJz
ZXJfZXJycG9zaXRpb24ocHN0YXRlLCBkYXR1bS0mZ3Q7bG9jYXRpb24pKTs8YnI+PGJyPjxicj4r
IMKgIMKgIMKgIMKgIMKgIMKgIMKgIGVyZXBvcnQoRVJST1IsPGJyPisgwqAgwqAgwqAgwqAgwqAg
wqAgwqAgwqAgwqAgwqAgwqAgZXJyY29kZShFUlJDT0RFX0lOVkFMSURfT0JKRUNUX0RFRklOSVRJ
T04pLDxicj4rIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGVycm1zZygmcXVvdDtu
ZXcgcGFydGl0aW9uIFwmcXVvdDslc1wmcXVvdDsgY2Fubm90IGhhdmUgdGhpcyB2YWx1ZSBiZWNh
dXNlIHNwbGl0IHBhcnRpdGlvbiBkb2VzIG5vdCBoYXZlJnF1b3Q7LDxicj4rIMKgIMKgIMKgIMKg
IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgcmVsbmFtZSksPGJyPisgwqAgwqAgwqAg
wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcGFyc2VyX2VycnBvc2l0aW9uKHBzdGF0ZSwgb3Zlcmxh
cF9sb2NhdGlvbikpOzxicj48YnI+PGJyPisgwqAgwqAgwqAgZXJlcG9ydChFUlJPUiw8YnI+KyDC
oCDCoCDCoCDCoCDCoCDCoCDCoCBlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9PQkpFQ1RfREVGSU5J
VElPTiksPGJyPisgwqAgwqAgwqAgwqAgwqAgwqAgwqAgZXJybXNnKCZxdW90O25ldyBwYXJ0aXRp
b25zIGRvIG5vdCBoYXZlIHZhbHVlICVzIGJ1dCBzcGxpdCBwYXJ0aXRpb24gZG9lcyZxdW90Oyw8
YnI+KyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHNlYXJjaE51bGwgPyAmcXVvdDtO
VUxMJnF1b3Q7IDogZ2V0X2xpc3RfcGFydHZhbHVlX3N0cmluZyhub3RGb3VuZFZhbCkpKTs8YnI+
PGJyPjxicj4rIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGVyZXBvcnQo
RVJST1IsPGJyPisgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
wqAgwqAgZXJyY29kZShFUlJDT0RFX0lOVkFMSURfT0JKRUNUX0RFRklOSVRJT04pLDxicj4rIMKg
IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGVycm1zZygm
cXVvdDtERUZBVUxUIHBhcnRpdGlvbiBzaG91bGQgYmUgb25lJnF1b3Q7KSw8YnI+KyDCoCDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBwYXJzZXJfZXJycG9z
aXRpb24ocHN0YXRlLCBzcHMtJmd0O25hbWUtJmd0O2xvY2F0aW9uKSk7PGJyPjxicj4rIMKgIMKg
IMKgIGVyZXBvcnQoRVJST1IsPGJyPisgwqAgwqAgwqAgwqAgwqAgwqAgwqAgZXJyY29kZShFUlJD
T0RFX0lOVkFMSURfT0JKRUNUX0RFRklOSVRJT04pLDxicj4rIMKgIMKgIMKgIMKgIMKgIMKgIMKg
IGVycm1zZygmcXVvdDtvbmUgcGFydGl0aW9uIGluIHRoZSBsaXN0IHNob3VsZCBiZSBERUZBVUxU
IGJlY2F1c2Ugc3BsaXQgcGFydGl0aW9uIGlzIERFRkFVTFQmcXVvdDspLDxicj4rIMKgIMKgIMKg
IMKgIMKgIMKgIMKgIHBhcnNlcl9lcnJwb3NpdGlvbihwc3RhdGUsICgoU2luZ2xlUGFydGl0aW9u
U3BlYyAqKSBsaW5pdGlhbChwYXJ0bGlzdCkpLSZndDtuYW1lLSZndDtsb2NhdGlvbikpOzxicj48
YnI+PGJyPisgwqAgwqAgwqAgZXJlcG9ydChFUlJPUiw8YnI+KyDCoCDCoCDCoCDCoCDCoCDCoCDC
oCBlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9PQkpFQ1RfREVGSU5JVElPTiksPGJyPisgwqAgwqAg
wqAgwqAgwqAgwqAgwqAgZXJybXNnKCZxdW90O25ldyBwYXJ0aXRpb24gY2Fubm90IGJlIERFRkFV
TFQgYmVjYXVzZSBERUZBVUxUIHBhcnRpdGlvbiBhbHJlYWR5IGV4aXN0cyZxdW90OyksPGJyPisg
wqAgwqAgwqAgwqAgwqAgwqAgwqAgcGFyc2VyX2VycnBvc2l0aW9uKHBzdGF0ZSwgc3BzRGVmLSZn
dDtuYW1lLSZndDtsb2NhdGlvbikpOzxicj48YnI+KyDCoCDCoCDCoCDCoCDCoCDCoCDCoCBlcmVw
b3J0KEVSUk9SLDxicj4rIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGVycmNvZGUo
RVJSQ09ERV9DSEVDS19WSU9MQVRJT04pLDxicj4rIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg
IMKgIMKgIGVycm1zZygmcXVvdDtjYW4gbm90IGZpbmQgcGFydGl0aW9uIGZvciBzcGxpdCBwYXJ0
aXRpb24gcm93JnF1b3Q7KSw8YnI+KyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBl
cnJ0YWJsZShzcGxpdFJlbCkpOzxicj48L2ZvbnQ+PGJyPi0tLS0tLTxicj5SZWdhcmRzLDxicj5B
bGV4YW5kZXIgS29yb3Rrb3Y8YnI+U3VwYWJhc2U8L2Rpdj4NCg==
--0000000000001f33c00636c9383a--