Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tegoZ-00F366-Uh for pgsql-hackers@arkaria.postgresql.org; Sun, 02 Feb 2025 20:43:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tegoZ-008OHf-0A for pgsql-hackers@arkaria.postgresql.org; Sun, 02 Feb 2025 20:43:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tegoY-008OHG-Ms for pgsql-hackers@lists.postgresql.org; Sun, 02 Feb 2025 20:43:34 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tegoW-002ppi-0X for pgsql-hackers@postgresql.org; Sun, 02 Feb 2025 20:43:33 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5d414b8af7bso7440059a12.0 for ; Sun, 02 Feb 2025 12:43:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738529011; x=1739133811; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yhjvtyDb2k8/J40/s21D7upgU8+s2jllXVGBiL4Pve0=; b=gJ17TYvxAHGhjZmIRnIam/us7wxMnIW4Ng6nfUQ5VUmB1RiPB3p4VKWjzNR2rRn7uo Mbcj6cpRCcKpatoRCKLBAWB77cfd+2tNpjbCpNwRL0g/c9tEp22isl5cvyUWuIhwhq2A 7XA6L9wStKNi3c2k/aCRSClbbQrmWHxP9z2k8emc4T245IFdRABq+ieDikq962LerIRn 3cAK/IBUJiIzEC5JVRi4nwUSNh+izdZR08DLiKP6fyLcZg08r2clb/LgJEKSFIABpRuU H/nSPCuY1RV1ako7oUo5FKoAQAjImSaOOi2uQ+i4wdbtFKHsoGluhG9yr3dlHvtmVX34 +a8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738529011; x=1739133811; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yhjvtyDb2k8/J40/s21D7upgU8+s2jllXVGBiL4Pve0=; b=q0QrfNpNc4CxFVKIkiVnBz/WkePkXSV/O5FhJq/0VRi7FGE/m6pqc8Y6/gM2qlR8R2 pzXY09dKxx6tlEjZfLQ5KEAremURjuiTZ+e57WRfGkAi9JumXFx7iMyzvnP5Ie4Yr5zO Ek33mjrcWU4OrE8xSXsAsigC7xH/gTlvemltKcANCnz3v/pcoLh/botm4CK07NCrz4+I KgJeL5RtMP91AksPps6nBJvGrkecu6/2H0dlGNCPdRME6UfW8sSQHEdgCpDuKu/lSksY RE1J03CU3UgZWv4jCoTPCS1hWxbCW87Jc1Nl63USByvDbO4AfymKj5fy8xdqE2nNCxah OSzQ== X-Gm-Message-State: AOJu0Yxxc2SIfU780LfujtToEeyu+E8l9wvy+XUWz5hgDvvcyvLbySon M/HZbqq7OnynnMChlRDulW6j/2Kv411gUzW5b01she9tCX/VT9YJyoqS4wA9qFWn7pOCY7lNhIp ChpV85guT0zh14sTXqYnlmiSqMHg= X-Gm-Gg: ASbGncswNEFl0atrSGkvzY0kGXdQ9wrPXC1QJW0k4WijWY4Hrok1Rhd0cSKe1Qt+T9t 2tZ+15MY5wDESwFg8MQAMknawjr8vAsZY8EI5cgeYiTu6s8utNq+GxFBVLTkLBmC+ocA2Zr2H X-Google-Smtp-Source: AGHT+IHoJD/xrI2fVXQDd82Krd+7Y0yJxM5nGqKiPNwZF4yiHI9SqNNSZs1dkhz5eIGp15E8Dn0lbyTlP8LqLYoKGT4= X-Received: by 2002:a05:6402:1f01:b0:5dc:7725:a0e0 with SMTP id 4fb4d7f45d1cf-5dc7725a441mr14958551a12.15.1738529010798; Sun, 02 Feb 2025 12:43:30 -0800 (PST) MIME-Version: 1.0 References: <9485d892-fd04-4e3a-ac24-7dd767cb7333@postgrespro.ru> <0B6CBF4C-CC2A-4200-9126-CE3A390D938B@upgrade.com> <6732acf8ce0f31025b535ae1a64568750924a887.camel@moonset.ru> <5AA8FFD5-6DE2-4A31-8E00-AE98F738F5D1@upgrade.com> <85b963fe-5977-43aa-9241-75b862abcc69@postgrespro.ru> <9C7A167C-DCDE-4A17-9ABE-6276723FEC50@upgrade.com> <2d493cf9-9ba7-4cc1-a3f2-67afd7c163ee@postgrespro.ru> <30d54302-9e9c-4e04-819e-a13b679cdcc8@postgrespro.ru> <86f76aa5-1ab5-4e2e-9b15-405051852a2a@postgrespro.ru> <1e81a0a1-a63b-48fb-905a-d6495f89ab73@postgrespro.ru> <0b4eefc7-4c38-4caa-b2ca-a4c75dd7dd12@postgrespro.ru> In-Reply-To: <0b4eefc7-4c38-4caa-b2ca-a4c75dd7dd12@postgrespro.ru> From: Alexander Korotkov Date: Sun, 2 Feb 2025 22:43:19 +0200 X-Gm-Features: AWEUYZn0brFVx2mB6N1Axt0qoX4O2ZbO0hAj95_5Gie8jgoGyC8-5pv_5pQ_f_Q Message-ID: Subject: Re: Vacuum statistics To: Alena Rybakina Cc: pgsql-hackers , Jim Nasby , Ilia Evdokimov , Kirill Reshke , Andrei Zubkov , Masahiko Sawada , Melanie Plageman , jian he , a.lepikhov@postgrespro.ru, Sami Imseih Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Jan 13, 2025 at 3:26=E2=80=AFPM Alena Rybakina wrote: > I noticed that the cfbot is bad, the reason seems to be related to the la= ck of a parameter in src/backend/utils/misc/postgresql.conf.sample. I added= it, it should help. The patch doesn't apply cleanly. Please rebase. I see you introduced new GUC variable pgstat_track_vacuum_statistics, which should address the increased size of statistics. However, I don't see how it could affect the size of PgStat_StatTabEntry struct. It seems that when pgstat_track_vacuum_statistics =3D=3D 0, extended vacuum statistics is not collected but the size of hash table entries is the same. Also, should pgstat_track_vacuum_statistics also affect per database statistics? The name of 0001 is "... on heap relations". Should we say "on table relations", because new machinery should work with alternative table AMs as well. There are deletions of empty lines in src/include/utils/pgstat_internal.h and src/include/pgstat.h. Please, remote them as it's not purpose of this patchset. ------ Regards, Alexander Korotkov Supabase