MIME-Version: 1.0
References: <86bfd241-a58c-479a-9a72-2c67a02becf8@postgrespro.ru>
 <CAMbWs49c_7dT_oiP729b-JPRiDtTuDca3exN_cOZZwjGG-0bMA@mail.gmail.com>
 <b907ce77-c054-4009-a871-4d55cb3f73f9@postgrespro.ru> <fdaa003e-919c-cbc9-4f0c-e4546e96bd65@gmail.com>
 <edfbd846-dcc1-42d1-ac26-715691b687d3@postgrespro.ru> <0f655bcd-6487-4179-f9cf-c248efbad510@gmail.com>
 <ZjFRSVnvvGrsdndU@pryzbyj2023> <41117807-3bea-45bc-a9c0-743c29abff2d@postgrespro.ru>
 <ZjTlQiBPYm707Rxv@pryzbyj2023> <CAPpHfduhHm+4yeObsj9wK4iZvV2Ve5xcr6BwZDFiNBYbE1PfLg@mail.gmail.com>
 <ZlIljQuKtXwn7I27@pryzbyj2023>
In-Reply-To: <ZlIljQuKtXwn7I27@pryzbyj2023>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Sun, 26 May 2024 06:56:33 +0300
Message-ID: <CAPpHfdus1rnsoiB6DW=6S+_c0pC6F0aOKsc-ROnbwbs2SjfQyw@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Dmitry Koval <d.koval@postgrespro.ru>, Alexander Lakhin <exclusion@gmail.com>, 
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAPpHfdus1rnsoiB6DW%3D6S%2B_c0pC6F0aOKsc-ROnbwbs2SjfQyw%40mail.gmail.com>
Precedence: bulk

On Sat, May 25, 2024 at 8:53=E2=80=AFPM Justin Pryzby <pryzby@telsasoft.com=
> wrote:
> On Fri, May 03, 2024 at 04:32:25PM +0300, Alexander Korotkov wrote:
> > On Fri, May 3, 2024 at 4:23=E2=80=AFPM Justin Pryzby <pryzby@telsasoft.=
com> wrote:
> > > Note that the error that led to "EXCLUDING IDENTITY" is being discuse=
d
> > > over here:
> > > https://www.postgresql.org/message-id/3b8a9dc1-bbc7-0ef5-6863-c432afa=
c7d59@gmail.com
> > >
> > > It's possible that once that's addressed, the exclusion should be
> > > removed here, too.
> >
> > +1
>
> Can EXCLUDING IDENTITY be removed now ?
>
> I wasn't able to find why it was needed - at one point, I think there
> was a test case that threw an error, but now when I remove the EXCLUDE,
> nothing goes wrong.

Yes, it was broken before [1][2], but now it seems to work.  At the
same time, I'm not sure if we need to remove the EXCLUDE now.
IDENTITY is anyway successfully created when the new partition gets
attached.

Links.
1. https://www.postgresql.org/message-id/171085360143.2046436.7217841141682=
511557.pgcf@coridan.postgresql.org
2. https://www.postgresql.org/message-id/flat/ZiGH0xc1lxJ71ZfB%40pryzbyj202=
3#297b6aef85cb089abb38e9b1a9a7ffff

------
Regards,
Alexander Korotkov
Supabase