MIME-Version: 1.0
References: <567ED6CA.2040504@sigaev.ru> <d5d3f257-a2d8-4776-9c97-83f98e74636c@postgrespro.ru>
 <CAPpHfdtACtU_XbuNf9mgDBsTH1cN=i+uASXKBX_rvQk6zQ3MdQ@mail.gmail.com>
 <7389d0dd-05d5-41b7-a12d-2e73f939f851@postgrespro.ru> <CAPpHfdsAWGF2VvcszNofc32Sa2pefBpgY1nw2aYV=FTG7Q3wyA@mail.gmail.com>
 <74e3c8bc-dccd-45e5-ad2d-6a6e96fc5864@postgrespro.ru> <CAPpHfdutHt31sdt2rfU=4fsDMWxf6tvtnHARgCzLY2Tf21+fgw@mail.gmail.com>
 <a5762b63-59c0-4721-8755-2ae6a73338ce@postgrespro.ru> <CAPpHfdsADL+agHnnjvi_42hNJWQdHK76SVPbNjsqAyHzxOxv8w@mail.gmail.com>
 <b79b5a8f-40d8-4da9-938e-b96585ccb5d5@postgrespro.ru> <CAPpHfdtSXxhdv3mLOLjEewGeXJ+Ftfhjqodn1WWuq5JLsKx48g@mail.gmail.com>
 <6d27d752-db0b-4cac-9843-6ba3dd7a1e94@postgrespro.ru> <CAPpHfdu4YJa5xCaOQnLzk4qsutRWrJGbcffVuZ=6R=eTAdMLig@mail.gmail.com>
 <f3705bb3-f9b0-4d92-a660-48ebd764d2df@postgrespro.ru> <CAPpHfdtGmUHv=E4QWGWHk2QUuJ-x0mTNBssW_Ehv2dcOQ2L66g@mail.gmail.com>
 <CAPpHfduah1PLzajBJFDmp7+MZuaWYpie2p+GsV0r03fcGghQ-g@mail.gmail.com> <7d5aed92-d4cc-4b76-8ae0-051d182c9eec@postgrespro.ru>
In-Reply-To: <7d5aed92-d4cc-4b76-8ae0-051d182c9eec@postgrespro.ru>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Mon, 17 Jun 2024 15:11:09 +0300
Message-ID: <CAPpHfdv087igFrMiU3yghtG9SmmYoWk0jP8WFJ9yR301CHit+w@mail.gmail.com>
Subject: Re: POC, WIP: OR-clause support for indexes
To: Alena Rybakina <a.rybakina@postgrespro.ru>
Cc: Andrei Lepikhov <a.lepikhov@postgrespro.ru>, jian he <jian.universality@gmail.com>, 
	Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org, 
	Peter Geoghegan <pg@bowt.ie>, "Finnerty, Jim" <jfinnert@amazon.com>, Marcos Pegoraro <marcos@f10.com.br>, teodor@sigaev.ru, 
	Tomas Vondra <tomas.vondra@enterprisedb.com>, Peter Eisentraut <peter@eisentraut.org>, 
	Ranier Vilela <ranier.vf@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAPpHfdv087igFrMiU3yghtG9SmmYoWk0jP8WFJ9yR301CHit%2Bw%40mail.gmail.com>
Precedence: bulk

On Mon, Jun 17, 2024 at 1:33=E2=80=AFPM Alena Rybakina
<a.rybakina@postgrespro.ru> wrote:
> I noticed that 7 libraries have been added to src/backend/optimizer/plan/=
initsplan.c, and as far as I remember, Tom Lane has already expressed doubt=
s about the approach that requires adding a large number of libraries [0], =
but I'm afraid I'm out of ideas about alternative approach.

Thank you for pointing.  Right, the number of extra headers included
was one of points for criticism on this patch.  I'll look to move this
functionality elsewhere, while the stage of transformation could
probably be the same.

> In addition, I checked the fix in the previous cases that you wrote earli=
er [1] and noticed that SeqScan continues to generate, unfortunately, witho=
ut converting expressions:

I've rechecked and see I made wrong conclusion about this.  The plan
regression is still here.  But I'm still looking to workaround this
without extra GUC.

I think we need to additionally do something like [1], but take
further steps to avoid planning overhead when not necessary.  In
particular, I think we should only consider splitting SAOP for bitmap
OR in the following cases:
1. There are partial indexes with predicates over target column.
2. There are multiple indexes covering target column and different
subsets of other columns presented in restrictions.
3. There are indexes covreing target column without support of SAOP
(amsearcharray =3D=3D false).
Hopefully this should skip generation of useless bitmap paths in
majority cases. Thoughts?

Links.
1. https://www.postgresql.org/message-id/67bd918d-285e-44d2-a207-f52d9a4c35=
e6%40postgrespro.ru

------
Regards,
Alexander Korotkov
Supabase