public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alexander Korotkov <[email protected]>
To: torikoshia <[email protected]>
Cc: jian he <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)
Date: Fri, 19 Jan 2024 15:27:18 +0200
Message-ID: <CAPpHfdv1EQh9WUnJM5uZvRzP80grdqv69NSVHUu0CUk54dTTxg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CAPpHfdvfpON-osWgDg-gsJGi9MnC4XdAWCdcH1vJcq9LOa97cw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAPpHfduYDAmgccWM--A2md-zS-6zP_H41-xtUskV_daBfpAk_Q@mail.gmail.com>
<[email protected]>
<CAD21AoD474GqjdoUkm8kU0e8xO__A-BHR1=_QyCAmAkcKoHY1w@mail.gmail.com>
<CACJufxFyM-TPsaXPg6-b_Ps0=bnAi9xyhvVKT1UtuF-qyepEnA@mail.gmail.com>
<[email protected]>
<CAPpHfds-WExDYWUvtBfb=Q9tjp4gcH4-noDgo6YCNhiR-DmJVw@mail.gmail.com>
<[email protected]>
<CACJufxGJjj94XTWsD9eJaiE99CPRBkO1frvJWTJ-6NDpa+ksLg@mail.gmail.com>
<[email protected]>
Hi!
On Fri, Jan 19, 2024 at 2:37 PM torikoshia <[email protected]> wrote:
> Thanks for making the patch!
The patch is pushed! The proposed changes are incorporated excluding this.
> > - /* If SAVE_ERROR_TO is specified, skip rows
> > with soft errors */
> > + /* If ON_ERROR is specified with IGNORE, skip
> > rows with soft errors */
>
> This is correct now, but considering future works which add other
> options like "file 'copy.log'" and
> "table 'copy_log'", it may be better not to limit the case to 'IGNORE'.
> How about something like this?
>
> If ON_ERROR is specified and the value is not STOP, skip rows with
> soft errors
I think when we have more options, then we wouldn't just skip rows
with soft errors but rather save them. So, I left this comment as is
for now.
------
Regards,
Alexander Korotkov
view thread (117+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)
In-Reply-To: <CAPpHfdv1EQh9WUnJM5uZvRzP80grdqv69NSVHUu0CUk54dTTxg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox