MIME-Version: 1.0
References: <567ED6CA.2040504@sigaev.ru> <37bf870a-22e0-4aba-b845-549482118f8d@gmail.com>
 <CAPpHfdtPkA3XGM+FOanXfFNm45YEMkuqpfL0ZSL7uOP1bHPPEg@mail.gmail.com>
 <8174de69-9e1a-0827-0e81-ef97f56a5939@gmail.com> <ed2b909c-35d4-4a39-ac38-8a15634a281b@postgrespro.ru>
 <CAEudQApBzH9JNkDpXARrjFG0WGM2PcU02f6Ga9sLVS2H6z9YAQ@mail.gmail.com>
 <3b717020-14d9-425f-8c60-ce336b5a23b3@postgrespro.ru> <CAPpHfdvM4E-wPCRbYkr9eGH2sSxgOYKZ1iOUyjKYqTEyurFRLQ@mail.gmail.com>
 <43db6a40-5c5f-4909-ad62-3060b297e686@postgrespro.ru> <CAPpHfdtgcye9ELaLHw4ZOUxWQ9t1P=oBDJX8KwwOHqasESdXQQ@mail.gmail.com>
 <CAPpHfdv+jtNwofg-p5z86jLYZUTt6tR17Wy00ta0dL=wHQN3ZA@mail.gmail.com>
 <ab8aedce-7a2f-4bb2-bfad-3f1ad91e7336@gmail.com> <41ba3d47-2a48-476c-88d4-6ebd889a7af2@gmail.com>
 <CAPpHfdvehQbCpQG9zYr739y2nXQkE=FYsat5VE-pDoB4RDPfBw@mail.gmail.com>
 <88844a88-57dd-4722-b697-15c10f1b81a7@gmail.com> <CAPpHfduOn0htAXp6h3gcv1hMUuoQSYfM-sk6TXKcM57C8B4Umw@mail.gmail.com>
 <fdba7c11-4f3e-43d3-ac89-cab82aef0b6f@gmail.com> <8cf87fc0-1f79-4427-8134-9245a1a52cf4@gmail.com>
In-Reply-To: <8cf87fc0-1f79-4427-8134-9245a1a52cf4@gmail.com>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Sun, 2 Feb 2025 19:58:27 +0200
Message-ID: <CAPpHfdv=diZVP_JYPd2Pf_55-W1gf6Pt9DcmP-xyRfiMH5mv-Q@mail.gmail.com>
Subject: Re: POC, WIP: OR-clause support for indexes
To: Andrei Lepikhov <lepihov@gmail.com>
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>, Ranier Vilela <ranier.vf@gmail.com>, 
	Alexander Lakhin <exclusion@gmail.com>, jian he <jian.universality@gmail.com>, 
	Robert Haas <robertmhaas@gmail.com>, Nikolay Shaplov <dhyan@nataraj.su>, 
	pgsql-hackers@lists.postgresql.org, pgsql-hackers@postgresql.org, 
	Peter Geoghegan <pg@bowt.ie>, Marcos Pegoraro <marcos@f10.com.br>, teodor@sigaev.ru, 
	Peter Eisentraut <peter@eisentraut.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAPpHfdv%3DdiZVP_JYPd2Pf_55-W1gf6Pt9DcmP-xyRfiMH5mv-Q%40mail.gmail.com>
Precedence: bulk

On Tue, Jan 28, 2025 at 10:42=E2=80=AFAM Andrei Lepikhov <lepihov@gmail.com=
> wrote:
> On 1/28/25 11:36, Andrei Lepikhov wrote:
> > On 1/27/25 16:50, Alexander Korotkov wrote:
> > qsort(matches, n, sizeof(OrArgIndexMatch), or_arg_index_match_cmp);
> >
> > To fit an index, the order of elements in the target array of the
> > `ScalarArrayOpExpr` may change compared to the initial list of OR
> > expressions. If there are indexes that cover the same set of columns bu=
t
> > in reverse order, this could potentially alter the position of a
> > Subplan. However, I believe this is a rare case; it is supported by the
> > initial OR path and should be acceptable.
> I beg your pardon - I forgot that we've restricted the feature's scope
> and can't combine OR clauses into ScalarArrayOpExpr if the args list
> contains references to different columns.
> So, my note can't be applied here.

OK, thank you!

------
Regards,
Alexander Korotkov
Supabase