MIME-Version: 1.0
References: <1d12d2-67235980-35-19a406a0@63439497>
 <CAPpHfdtp61pSt72KxxOnnV_Oj4OTAiKYCSTek0Pm87hVDod4Bg@mail.gmail.com>
 <CAA4eK1Lmd-stXWrNqX9iXugjY=ahhe7zRfyq+-vN512xvF4G2w@mail.gmail.com>
 <CAPpHfdsTiYQPywr4yeqVhUtA+eFdqisqcAOiTb+kiYhi9EVEvw@mail.gmail.com>
 <CAPpHfdvk-nfu5xzJyPArxWctofWPR+1L9uJ+yyWFA34n6b5rGQ@mail.gmail.com>
 <CAA4eK1Ladnm40UO-YC+c7eBYqjyFQSwg0dn1w_CiaMoBTsJUDA@mail.gmail.com>
 <CAPpHfduX--KKX853UwaJ8Cjo5bxbh19V_+McKQ3p9aS6b8T1Wg@mail.gmail.com>
 <CAA4eK1+VbBxYY-rG4B7Jq6TsYvdjt3d2nbUrs7p9-1sP5mH+sw@mail.gmail.com>
 <CAPpHfdvxqjE+RZdoOODQZAmQip6NpvSH40DuvVFWuf_00ek-yQ@mail.gmail.com>
 <1d97ec-6841b600-3-b7b4780@40747246>
 <CAA4eK1LvssAcp61qg957xRF0=K4xF0hfJQjQ6c9V7EGHSqraPg@mail.gmail.com>
 <28c8bf-68470780-3-51b29480@89454035>
 <CAPpHfdt77k3BqD=anh4b7UiRevfPOu2Hcf3rvSZXntxH+4G=Ug@mail.gmail.com>
 <fbc5d94e-6fbd-4a64-85d4-c9e284a58eb2@gmail.com>
 <CAPpHfdvPpg5VUTNOqfKSNx66ij3ZJNZbf4kn6SDcPkdq9FTvng@mail.gmail.com>
 <0a617d34-abc3-4090-92a5-ea15d45e36f6@gmail.com>
 <228607.1750003556@sss.pgh.pa.us>
In-Reply-To: <228607.1750003556@sss.pgh.pa.us>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Mon, 16 Jun 2025 04:58:51 +0300
Message-ID: 
 <CAPpHfdvJMe4i0_wp1tq2ZGSDKqUHKPwkfD_Y6KyJ3XQRFvc0cQ@mail.gmail.com>
Subject: Re: Slot's restart_lsn may point to removed WAL segment after hard
 restart unexpectedly
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Lakhin <exclusion@gmail.com>,
 Vitaly Davydov <v.davydov@postgrespro.ru>,
	Amit Kapila <amit.kapila16@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
	Masahiko Sawada <sawada.mshk@gmail.com>, tomas@vondra.me
Content-Type: multipart/mixed; boundary="0000000000009a40370637a6bdfc"
Archived-At: 
 <https://www.postgresql.org/message-id/CAPpHfdvJMe4i0_wp1tq2ZGSDKqUHKPwkfD_Y6KyJ3XQRFvc0cQ%40mail.gmail.com>
Precedence: bulk

--0000000000009a40370637a6bdfc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi, Tom!

On Sun, Jun 15, 2025 at 7:05=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> BTW, while you're cleaning up this commit, could you remove the
> excess newlines in some of the "note" commands in 046 and 047, like
>
> note('starting checkpoint\n');
>
> This produces bizarre output, as shown in the buildfarm logs:

Thank you for reporting this.  The revised patch is attached.  In
addition to reducing tests runtime, it removes excess newlines from
some note() calls.  The commit message is here.  I'm going to push
this if no objections.

------
Regards,
Alexander Korotkov
Supabase

--0000000000009a40370637a6bdfc
Content-Type: application/octet-stream;
	name="v2-0001-Improve-runtime-and-output-of-tests-for-replicati.patch"
Content-Disposition: attachment;
	filename="v2-0001-Improve-runtime-and-output-of-tests-for-replicati.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mbyg2ehf0>
X-Attachment-Id: f_mbyg2ehf0

RnJvbSA1ZTMzMmVjZTk3YTZhZWZjZWM1NjlhZjdlMTZhNDI1MWZjNzkwNzFjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgS29yb3Rrb3YgPGFrb3JvdGtvdkBwb3N0Z3Jl
c3FsLm9yZz4KRGF0ZTogU3VuLCAxNSBKdW4gMjAyNSAxMzo1NDowOSArMDMwMApTdWJqZWN0OiBb
UEFUQ0ggdjJdIEltcHJvdmUgcnVudGltZSBhbmQgb3V0cHV0IG9mIHRlc3RzIGZvciByZXBsaWNh
dGlvbiBzbG90cwogY2hlY2twb2ludGluZy4KClRoZSBUQVAgdGVzdHMgdGhhdCB2ZXJpZnkgbG9n
aWNhbCBhbmQgcGh5c2ljYWwgcmVwbGljYXRpb24gc2xvdCBiZWhhdmlvcgpkdXJpbmcgY2hlY2tw
b2ludHMgKDA0Nl9jaGVja3BvaW50X2xvZ2ljYWxfc2xvdC5wbCBhbmQKMDQ3X2NoZWNrcG9pbnRf
cGh5c2ljYWxfc2xvdC5wbCkgaW5zZXJ0ZWQgdHdvIGJhdGNoZXMgb2YgMiBtaWxsaW9uIHJvd3Mg
ZWFjaCwKZ2VuZXJhdGluZyBhcHByb3hpbWF0ZWx5IDUyMCBNQiBvZiBXQUwuICBPbiBzbG93IG1h
Y2hpbmVzLCBvciB3aGVuIGNvbXBpbGVkCndpdGggJy1EUkVMQ0FDSEVfRk9SQ0VfUkVMRUFTRSAt
RENBVENBQ0hFX0ZPUkNFX1JFTEVBU0UnLCB0aGlzIGNhdXNlZCB0aGUKdGVzdHMgdG8gcnVuIGZv
ciA4LTkgbWludXRlcyBhbmQgb2NjYXNpb25hbGx5IHRpbWUgb3V0LCBhcyBzZWVuIG9uIHRoZQpi
dWlsZGZhcm0gYW5pbWFsIHByaW9uLgoKUmVkdWNlIGVhY2ggSU5TRVJUIHRvIDUwayByb3dzIG9m
IHdpZGVyIGRhdGEsIHdoaWNoIHlpZWxkcyBhcHByb3hpbWF0ZWx5CjUgc2VnbWVudHMgb2YgV0FM
LiAgVGhpcyB2b2x1bWUgaXMgc3RpbGwgc3VmZmljaWVudCB0byBhZHZhbmNlIHRoZSBzbG90IHRv
CnRoZSBuZXh0IHNlZ21lbnQgYW5kIGV4ZXJjaXNlIHRoZSBjb2RlIHBhdGhzIHVuZGVyIHRlc3Qs
IGJ1dCBpdCBjdXRzCnRoZSB0b3RhbCB3YWxsLWNsb2NrIHJ1biB0aW1lLgoKV2hpbGUgaGVyZSwg
cmVtb3ZlIHN1cGVyZmx1b3VzICdcbicgY2hhcmFjdGVycyBmcm9tIHNldmVyYWwgbm90ZSgpIGNh
bGxzOwp0aGVzZSBhcHBlYXJlZCBsaXRlcmFsbHkgaW4gdGhlIGJ1aWxkLWZhcm0gbG9ncyBhbmQg
bG9va2VkIG9kZC4KClJlcG9ydGVkLWJ5OiBBbGV4YW5kZXIgTGFraGluIDxleGNsdXNpb25AZ21h
aWwuY29tPgpSZXBvcnRlZC1ieTogVG9tIExhbmUgPHRnbEBzc3MucGdoLnBhLnVzPgpEaXNjdXNz
aW9uOiBodHRwczovL3Bvc3Rnci5lcy9tL2ZiYzVkOTRlLTZmYmQtNGE2NC04NWQ0LWM5ZTI4NGE1
OGViMiU0MGdtYWlsLmNvbQotLS0KIHNyYy90ZXN0L3JlY292ZXJ5L3QvMDQ2X2NoZWNrcG9pbnRf
bG9naWNhbF9zbG90LnBsIHwgMTQgKysrKysrKy0tLS0tLS0KIC4uLi9yZWNvdmVyeS90LzA0N19j
aGVja3BvaW50X3BoeXNpY2FsX3Nsb3QucGwgICAgIHwgIDggKysrKy0tLS0KIDIgZmlsZXMgY2hh
bmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3Jj
L3Rlc3QvcmVjb3ZlcnkvdC8wNDZfY2hlY2twb2ludF9sb2dpY2FsX3Nsb3QucGwgYi9zcmMvdGVz
dC9yZWNvdmVyeS90LzA0Nl9jaGVja3BvaW50X2xvZ2ljYWxfc2xvdC5wbAppbmRleCBiNDI2NWM0
YTZhNS4uOTY0YmMzNGZiZTggMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDQ2X2No
ZWNrcG9pbnRfbG9naWNhbF9zbG90LnBsCisrKyBiL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDQ2X2No
ZWNrcG9pbnRfbG9naWNhbF9zbG90LnBsCkBAIC01OCwyMyArNTgsMjMgQEAgU0VMRUNUIDEgXHdh
dGNoIDAuMQogXHEKICkpOwogCi0jIEluc2VydCAyTSByb3dzOyB0aGF0J3MgYWJvdXQgMjYwTUIg
KH4yMCBzZWdtZW50cykgd29ydGggb2YgV0FMLgorIyBJbnNlcnQgNTBLIHJvd3M7IHRoYXQncyBh
Ym91dCA4Nk1CICh+NSBzZWdtZW50cykgd29ydGggb2YgV0FMLgogJG5vZGUtPnNhZmVfcHNxbCgn
cG9zdGdyZXMnLAotCXF7aW5zZXJ0IGludG8gdCAoYikgc2VsZWN0IG1kNShpOjp0ZXh0KSBmcm9t
IGdlbmVyYXRlX3NlcmllcygxLDEwMDAwMDApIHMoaSl9CisJcXtpbnNlcnQgaW50byB0IChiKSBz
ZWxlY3QgcmVwZWF0KG1kNShpOjp0ZXh0KSw1MCkgZnJvbSBnZW5lcmF0ZV9zZXJpZXMoMSw1MDAw
MCkgcyhpKX0KICk7CiAKICMgUnVuIGFub3RoZXIgY2hlY2twb2ludCB0byBzZXQgYSBuZXcgcmVz
dG9yZSBMU04uCiAkbm9kZS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsIHF7Y2hlY2twb2ludH0pOwog
Ci0jIEFub3RoZXIgMk0gcm93czsgdGhhdCdzIGFib3V0IDI2ME1CICh+MjAgc2VnbWVudHMpIHdv
cnRoIG9mIFdBTC4KKyMgQW5vdGhlciA1MEsgcm93czsgdGhhdCdzIGFib3V0IDg2TUIgKH41IHNl
Z21lbnRzKSB3b3J0aCBvZiBXQUwuCiAkbm9kZS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsCi0JcXtp
bnNlcnQgaW50byB0IChiKSBzZWxlY3QgbWQ1KGk6OnRleHQpIGZyb20gZ2VuZXJhdGVfc2VyaWVz
KDEsMTAwMDAwMCkgcyhpKX0KKwlxe2luc2VydCBpbnRvIHQgKGIpIHNlbGVjdCByZXBlYXQobWQ1
KGk6OnRleHQpLDUwKSBmcm9tIGdlbmVyYXRlX3NlcmllcygxLDUwMDAwKSBzKGkpfQogKTsKIAog
IyBSdW4gYW5vdGhlciBjaGVja3BvaW50LCB0aGlzIHRpbWUgaW4gdGhlIGJhY2tncm91bmQsIGFu
ZCBtYWtlIGl0IHdhaXQKICMgb24gdGhlIGluamVjdGlvbiBwb2ludCkgc28gdGhhdCB0aGUgY2hl
Y2twb2ludCBzdG9wcyByaWdodCBiZWZvcmUKICMgcmVtb3Zpbmcgb2xkIFdBTCBzZWdtZW50cy4K
LW5vdGUoJ3N0YXJ0aW5nIGNoZWNrcG9pbnRcbicpOworbm90ZSgnc3RhcnRpbmcgY2hlY2twb2lu
dCcpOwogCiBteSAkY2hlY2twb2ludCA9ICRub2RlLT5iYWNrZ3JvdW5kX3BzcWwoJ3Bvc3RncmVz
Jyk7CiAkY2hlY2twb2ludC0+cXVlcnlfc2FmZSgKQEAgLTg4LDcgKzg4LDcgQEAgY2hlY2twb2lu
dDsKICkpOwogCiAjIFdhaXQgdW50aWwgdGhlIGNoZWNrcG9pbnQgc3RvcHMgcmlnaHQgYmVmb3Jl
IHJlbW92aW5nIFdBTCBzZWdtZW50cy4KLW5vdGUoJ3dhaXRpbmcgZm9yIGluamVjdGlvbl9wb2lu
dFxuJyk7Citub3RlKCd3YWl0aW5nIGZvciBpbmplY3Rpb25fcG9pbnQnKTsKICRub2RlLT53YWl0
X2Zvcl9ldmVudCgnY2hlY2twb2ludGVyJywgJ2NoZWNrcG9pbnQtYmVmb3JlLW9sZC13YWwtcmVt
b3ZhbCcpOwogbm90ZSgnaW5qZWN0aW9uX3BvaW50IGlzIHJlYWNoZWQnKTsKIApAQCAtMTA3LDcg
KzEwNyw3IEBAIHNlbGVjdCBjb3VudCgqKSBmcm9tIHBnX2xvZ2ljYWxfc2xvdF9nZXRfY2hhbmdl
cygnc2xvdF9sb2dpY2FsJywgbnVsbCwgbnVsbCkgXHdhCiApKTsKIAogIyBXYWl0IHVudGlsIHRo
ZSBzbG90J3MgcmVzdGFydF9sc24gcG9pbnRzIHRvIHRoZSBuZXh0IFdBTCBzZWdtZW50Lgotbm90
ZSgnd2FpdGluZyBmb3IgaW5qZWN0aW9uX3BvaW50XG4nKTsKK25vdGUoJ3dhaXRpbmcgZm9yIGlu
amVjdGlvbl9wb2ludCcpOwogJG5vZGUtPndhaXRfZm9yX2V2ZW50KCdjbGllbnQgYmFja2VuZCcs
CiAJJ2xvZ2ljYWwtcmVwbGljYXRpb24tc2xvdC1hZHZhbmNlLXNlZ21lbnQnKTsKIG5vdGUoJ2lu
amVjdGlvbl9wb2ludCBpcyByZWFjaGVkJyk7CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWNvdmVy
eS90LzA0N19jaGVja3BvaW50X3BoeXNpY2FsX3Nsb3QucGwgYi9zcmMvdGVzdC9yZWNvdmVyeS90
LzA0N19jaGVja3BvaW50X3BoeXNpY2FsX3Nsb3QucGwKaW5kZXggNDU0ZTU2YjliZDIuLjMxNDFi
MjU2YmYzIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWNvdmVyeS90LzA0N19jaGVja3BvaW50X3Bo
eXNpY2FsX3Nsb3QucGwKKysrIGIvc3JjL3Rlc3QvcmVjb3ZlcnkvdC8wNDdfY2hlY2twb2ludF9w
aHlzaWNhbF9zbG90LnBsCkBAIC00Myw5ICs0Myw5IEBAICRub2RlLT5zYWZlX3BzcWwoJ3Bvc3Rn
cmVzJywKICMgUnVuIGNoZWNrcG9pbnQgdG8gZmx1c2ggY3VycmVudCBzdGF0ZSB0byBkaXNrIGFu
ZCBzZXQgYSBiYXNlbGluZS4KICRub2RlLT5zYWZlX3BzcWwoJ3Bvc3RncmVzJywgcXtjaGVja3Bv
aW50fSk7CiAKLSMgSW5zZXJ0IDJNIHJvd3M7IHRoYXQncyBhYm91dCAyNjBNQiAofjIwIHNlZ21l
bnRzKSB3b3J0aCBvZiBXQUwuCisjIEluc2VydCA1MEsgcm93czsgdGhhdCdzIGFib3V0IDg2TUIg
KH41IHNlZ21lbnRzKSB3b3J0aCBvZiBXQUwuCiAkbm9kZS0+c2FmZV9wc3FsKCdwb3N0Z3Jlcycs
Ci0JcXtpbnNlcnQgaW50byB0IChiKSBzZWxlY3QgbWQ1KGk6OnRleHQpIGZyb20gZ2VuZXJhdGVf
c2VyaWVzKDEsMTAwMDAwKSBzKGkpfQorCXF7aW5zZXJ0IGludG8gdCAoYikgc2VsZWN0IHJlcGVh
dChtZDUoaTo6dGV4dCksNTApIGZyb20gZ2VuZXJhdGVfc2VyaWVzKDEsNTAwMDApIHMoaSl9CiAp
OwogCiAjIEFkdmFuY2Ugc2xvdCB0byB0aGUgY3VycmVudCBwb3NpdGlvbiwganVzdCB0byBoYXZl
IGV2ZXJ5dGhpbmcgInZhbGlkIi4KQEAgLTU2LDkgKzU2LDkgQEAgJG5vZGUtPnNhZmVfcHNxbCgn
cG9zdGdyZXMnLAogIyBSdW4gYW5vdGhlciBjaGVja3BvaW50IHRvIHNldCBhIG5ldyByZXN0b3Jl
IExTTi4KICRub2RlLT5zYWZlX3BzcWwoJ3Bvc3RncmVzJywgcXtjaGVja3BvaW50fSk7CiAKLSMg
QW5vdGhlciAyTSByb3dzOyB0aGF0J3MgYWJvdXQgMjYwTUIgKH4yMCBzZWdtZW50cykgd29ydGgg
b2YgV0FMLgorIyBBbm90aGVyIDUwSyByb3dzOyB0aGF0J3MgYWJvdXQgODZNQiAofjUgc2VnbWVu
dHMpIHdvcnRoIG9mIFdBTC4KICRub2RlLT5zYWZlX3BzcWwoJ3Bvc3RncmVzJywKLQlxe2luc2Vy
dCBpbnRvIHQgKGIpIHNlbGVjdCBtZDUoaTo6dGV4dCkgZnJvbSBnZW5lcmF0ZV9zZXJpZXMoMSwx
MDAwMDAwKSBzKGkpfQorCXF7aW5zZXJ0IGludG8gdCAoYikgc2VsZWN0IHJlcGVhdChtZDUoaTo6
dGV4dCksNTApIGZyb20gZ2VuZXJhdGVfc2VyaWVzKDEsNTAwMDApIHMoaSl9CiApOwogCiBteSAk
cmVzdGFydF9sc25faW5pdCA9ICRub2RlLT5zYWZlX3BzcWwoJ3Bvc3RncmVzJywKLS0gCjIuMzku
NSAoQXBwbGUgR2l0LTE1NCkKCg==
--0000000000009a40370637a6bdfc--