MIME-Version: 1.0
References: <0f655bcd-6487-4179-f9cf-c248efbad510@gmail.com>
 <ZjFRSVnvvGrsdndU@pryzbyj2023>
 <41117807-3bea-45bc-a9c0-743c29abff2d@postgrespro.ru>
 <ZjTlQiBPYm707Rxv@pryzbyj2023>
 <CAPpHfduhHm+4yeObsj9wK4iZvV2Ve5xcr6BwZDFiNBYbE1PfLg@mail.gmail.com>
 <CAPpHfdtgLiT2d++-qLircLB8ATUfzgR=aTmRDdF7w=2E9yDHbQ@mail.gmail.com>
 <Zjvwqs-GV0MjWIhU@pryzbyj2023>
 <CAPpHfdvh_XYHahtpoxfzDkvYOFUH1F5tm3JTV=sOZt8M4CTBcA@mail.gmail.com>
 <ZkN6EfjQGz8TOhbL@pryzbyj2023>
 <CAPpHfdvz3S7SoRiaSk9C-Juy2EzHs6NC_c9uUR0i7bymKXkvuQ@mail.gmail.com>
 <ai_c4-v8iLA2kXFV@pryzbyj2023>
In-Reply-To: <ai_c4-v8iLA2kXFV@pryzbyj2023>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Mon, 15 Jun 2026 23:50:07 +0300
Message-ID: 
 <CAPpHfdvOvaPxMoUp3T6hf4UmAaOhdPCcw71OGUWDjTXvrTZ_JA@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Dmitry Koval <d.koval@postgrespro.ru>,
 Alexander Lakhin <exclusion@gmail.com>,
	pgsql-hackers@lists.postgresql.org,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAPpHfdvOvaPxMoUp3T6hf4UmAaOhdPCcw71OGUWDjTXvrTZ_JA%40mail.gmail.com>
Precedence: bulk

On Mon, Jun 15, 2026 at 2:07=E2=80=AFPM Justin Pryzby <pryzby@telsasoft.com=
> wrote:
>
> I hit an error when I tried this patch.
>
> CREATE TABLE a (a text) PARTITION BY RANGE(a);
> CREATE TABLE a1 PARTITION OF a DEFAULT;
> INSERT INTO a SELECT repeat('1', 9999999);
> CREATE TABLE a2 PARTITION OF a FOR VALUES FROM (2)TO(3);
> ALTER TABLE a MERGE PARTITIONS (a1, a2) INTO a1;
> ERROR:  row is too big: size 39264, maximum size 8160

Thank you for your report.  It appears that createPartitionTable()
misses NewRelationCreateToastTable() call (for instance, DefineTable()
has this call).  The attached patch implements fix and has tests.  I'm
going to push it if no objections.

------
Regards,
Alexander Korotkov
Supabase