MIME-Version: 1.0
References: <1d12d2-67235980-35-19a406a0@63439497>
 <CAA4eK1KMaPA5jir_SFu+qr3qu55OOdFWVZpuUkqTSGZ9fyPpHA@mail.gmail.com>
 <2c1d-68344100-b7-3411b8c0@256938178>
 <CAA4eK1LmVoZ8jm5Jt3DERN9Z=y6L6xj5O0asw0smWw31Y8KfVw@mail.gmail.com>
 <CAPpHfdtp61pSt72KxxOnnV_Oj4OTAiKYCSTek0Pm87hVDod4Bg@mail.gmail.com>
 <CAA4eK1Lmd-stXWrNqX9iXugjY=ahhe7zRfyq+-vN512xvF4G2w@mail.gmail.com>
 <CAPpHfdsTiYQPywr4yeqVhUtA+eFdqisqcAOiTb+kiYhi9EVEvw@mail.gmail.com>
 <CAPpHfdvk-nfu5xzJyPArxWctofWPR+1L9uJ+yyWFA34n6b5rGQ@mail.gmail.com>
 <CAA4eK1Ladnm40UO-YC+c7eBYqjyFQSwg0dn1w_CiaMoBTsJUDA@mail.gmail.com>
 <CAPpHfduX--KKX853UwaJ8Cjo5bxbh19V_+McKQ3p9aS6b8T1Wg@mail.gmail.com>
 <CAA4eK1+VbBxYY-rG4B7Jq6TsYvdjt3d2nbUrs7p9-1sP5mH+sw@mail.gmail.com>
 <CAPpHfdvxqjE+RZdoOODQZAmQip6NpvSH40DuvVFWuf_00ek-yQ@mail.gmail.com>
 <1d97ec-6841b600-3-b7b4780@40747246>
 <CAA4eK1LvssAcp61qg957xRF0=K4xF0hfJQjQ6c9V7EGHSqraPg@mail.gmail.com>
 <28c8bf-68470780-3-51b29480@89454035>
 <CAPpHfdt77k3BqD=anh4b7UiRevfPOu2Hcf3rvSZXntxH+4G=Ug@mail.gmail.com>
 <fbc5d94e-6fbd-4a64-85d4-c9e284a58eb2@gmail.com>
In-Reply-To: <fbc5d94e-6fbd-4a64-85d4-c9e284a58eb2@gmail.com>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Sun, 15 Jun 2025 14:02:44 +0300
Message-ID: 
 <CAPpHfdvPpg5VUTNOqfKSNx66ij3ZJNZbf4kn6SDcPkdq9FTvng@mail.gmail.com>
Subject: Re: Slot's restart_lsn may point to removed WAL segment after hard
 restart unexpectedly
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Vitaly Davydov <v.davydov@postgrespro.ru>,
 Amit Kapila <amit.kapila16@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
 Masahiko Sawada <sawada.mshk@gmail.com>, tomas@vondra.me
Content-Type: multipart/mixed; boundary="000000000000b5681106379a3881"
Archived-At: 
 <https://www.postgresql.org/message-id/CAPpHfdvPpg5VUTNOqfKSNx66ij3ZJNZbf4kn6SDcPkdq9FTvng%40mail.gmail.com>
Precedence: bulk

--000000000000b5681106379a3881
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 15, 2025 at 12:00=E2=80=AFPM Alexander Lakhin <exclusion@gmail.=
com> wrote:
>
> Hello Alexander,
>
> 10.06.2025 23:14, Alexander Korotkov wrote:
>
> So, my proposal is to commit the attached patchset to the HEAD, and
> commit [1] to the back branches.  Any objections?
>
>
> As the buildfarm animal prion shows [1], the 046_checkpoint_logical_slot
> test fails with "-DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE":
> # poll_query_until timed out executing this query:
> #
> #         SELECT count(*) > 0 FROM pg_stat_activity
> #         WHERE backend_type =3D 'client backend' AND wait_event =3D 'log=
ical-replication-slot-advance-segment'
> #
> # expecting this output:
> # t
> # last actual query output:
> # f
> # with stderr:
> [04:16:27] t/046_checkpoint_logical_slot.pl ......
> Dubious, test returned 29 (wstat 7424, 0x1d00)
> No subtests run
> [04:20:58] t/047_checkpoint_physical_slot.pl ..... ok   271294 ms ( 0.00 =
usr  0.00 sys +  0.37 cusr  0.26 csys =3D  0.63 CPU)
>
> I'm able to reproduce this locally as well. Though the test passes for me
> with the increased timeout, that is it's not stuck:
> PG_TEST_TIMEOUT_DEFAULT=3D360 PROVE_TESTS=3D"t/046*" make -s check -C src=
/test/recovery/
> # +++ tap check in src/test/recovery +++
> t/046_checkpoint_logical_slot.pl .. ok
> All tests successful.
> Files=3D1, Tests=3D1, 533 wallclock secs ( 0.01 usr  0.00 sys +  4.70 cus=
r  9.61 csys =3D 14.32 CPU)
> Result: PASS
>
> Could you have a look?
>
> [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dprion&dt=3D=
2025-06-14%2001%3A58%3A06

Could you, please, check this patch?  On my system it makes 046 and
047 execute in 140 secs with -O0 and -DRELCACHE_FORCE_RELEASE
-DCATCACHE_FORCE_RELEASE.

------
Regards,
Alexander Korotkov
Supabase

--000000000000b5681106379a3881
Content-Type: application/octet-stream;
	name="v1-0001-Fix-046_checkpoint_-logical-physical-_slot.pl-exe.patch"
Content-Disposition: attachment;
	filename="v1-0001-Fix-046_checkpoint_-logical-physical-_slot.pl-exe.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mbxk2msq0>
X-Attachment-Id: f_mbxk2msq0

RnJvbSBkYjU5MWIzYzBiOWFlNzYwMzk1Zjc5ZGY2OGNhNzg5MjIxMDhlN2Y0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgS29yb3Rrb3YgPGFrb3JvdGtvdkBwb3N0Z3Jl
c3FsLm9yZz4KRGF0ZTogU3VuLCAxNSBKdW4gMjAyNSAxMzo1NDowOSArMDMwMApTdWJqZWN0OiBb
UEFUQ0ggdjFdIEZpeCAwNDZfY2hlY2twb2ludF8obG9naWNhbC9waHlzaWNhbClfc2xvdC5wbCBl
eGVjdXRpb24KIHRpbWUKClJlcG9ydGVkLWJ5OgpCdWc6CkRpc2N1c3Npb246CkF1dGhvcjoKUmV2
aWV3ZWQtYnk6ClRlc3RlZC1ieToKQmFja3BhdGNoLXRocm91Z2g6Ci0tLQogc3JjL3Rlc3QvcmVj
b3ZlcnkvdC8wNDZfY2hlY2twb2ludF9sb2dpY2FsX3Nsb3QucGwgIHwgOCArKysrLS0tLQogc3Jj
L3Rlc3QvcmVjb3ZlcnkvdC8wNDdfY2hlY2twb2ludF9waHlzaWNhbF9zbG90LnBsIHwgOCArKysr
LS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpk
aWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVjb3ZlcnkvdC8wNDZfY2hlY2twb2ludF9sb2dpY2FsX3Ns
b3QucGwgYi9zcmMvdGVzdC9yZWNvdmVyeS90LzA0Nl9jaGVja3BvaW50X2xvZ2ljYWxfc2xvdC5w
bAppbmRleCBiNDI2NWM0YTZhNS4uNGZlOTI4MjEwZGQgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3Jl
Y292ZXJ5L3QvMDQ2X2NoZWNrcG9pbnRfbG9naWNhbF9zbG90LnBsCisrKyBiL3NyYy90ZXN0L3Jl
Y292ZXJ5L3QvMDQ2X2NoZWNrcG9pbnRfbG9naWNhbF9zbG90LnBsCkBAIC01OCwxNyArNTgsMTcg
QEAgU0VMRUNUIDEgXHdhdGNoIDAuMQogXHEKICkpOwogCi0jIEluc2VydCAyTSByb3dzOyB0aGF0
J3MgYWJvdXQgMjYwTUIgKH4yMCBzZWdtZW50cykgd29ydGggb2YgV0FMLgorIyBJbnNlcnQgNTBL
IHJvd3M7IHRoYXQncyBhYm91dCA4Nk1CICh+NSBzZWdtZW50cykgd29ydGggb2YgV0FMLgogJG5v
ZGUtPnNhZmVfcHNxbCgncG9zdGdyZXMnLAotCXF7aW5zZXJ0IGludG8gdCAoYikgc2VsZWN0IG1k
NShpOjp0ZXh0KSBmcm9tIGdlbmVyYXRlX3NlcmllcygxLDEwMDAwMDApIHMoaSl9CisJcXtpbnNl
cnQgaW50byB0IChiKSBzZWxlY3QgcmVwZWF0KG1kNShpOjp0ZXh0KSw1MCkgZnJvbSBnZW5lcmF0
ZV9zZXJpZXMoMSw1MDAwMCkgcyhpKX0KICk7CiAKICMgUnVuIGFub3RoZXIgY2hlY2twb2ludCB0
byBzZXQgYSBuZXcgcmVzdG9yZSBMU04uCiAkbm9kZS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsIHF7
Y2hlY2twb2ludH0pOwogCi0jIEFub3RoZXIgMk0gcm93czsgdGhhdCdzIGFib3V0IDI2ME1CICh+
MjAgc2VnbWVudHMpIHdvcnRoIG9mIFdBTC4KKyMgQW5vdGhlciA1MEsgcm93czsgdGhhdCdzIGFi
b3V0IDg2TUIgKH41IHNlZ21lbnRzKSB3b3J0aCBvZiBXQUwuCiAkbm9kZS0+c2FmZV9wc3FsKCdw
b3N0Z3JlcycsCi0JcXtpbnNlcnQgaW50byB0IChiKSBzZWxlY3QgbWQ1KGk6OnRleHQpIGZyb20g
Z2VuZXJhdGVfc2VyaWVzKDEsMTAwMDAwMCkgcyhpKX0KKwlxe2luc2VydCBpbnRvIHQgKGIpIHNl
bGVjdCByZXBlYXQobWQ1KGk6OnRleHQpLDUwKSBmcm9tIGdlbmVyYXRlX3NlcmllcygxLDUwMDAw
KSBzKGkpfQogKTsKIAogIyBSdW4gYW5vdGhlciBjaGVja3BvaW50LCB0aGlzIHRpbWUgaW4gdGhl
IGJhY2tncm91bmQsIGFuZCBtYWtlIGl0IHdhaXQKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlY292
ZXJ5L3QvMDQ3X2NoZWNrcG9pbnRfcGh5c2ljYWxfc2xvdC5wbCBiL3NyYy90ZXN0L3JlY292ZXJ5
L3QvMDQ3X2NoZWNrcG9pbnRfcGh5c2ljYWxfc2xvdC5wbAppbmRleCA0NTRlNTZiOWJkMi4uMzE0
MWIyNTZiZjMgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDQ3X2NoZWNrcG9pbnRf
cGh5c2ljYWxfc2xvdC5wbAorKysgYi9zcmMvdGVzdC9yZWNvdmVyeS90LzA0N19jaGVja3BvaW50
X3BoeXNpY2FsX3Nsb3QucGwKQEAgLTQzLDkgKzQzLDkgQEAgJG5vZGUtPnNhZmVfcHNxbCgncG9z
dGdyZXMnLAogIyBSdW4gY2hlY2twb2ludCB0byBmbHVzaCBjdXJyZW50IHN0YXRlIHRvIGRpc2sg
YW5kIHNldCBhIGJhc2VsaW5lLgogJG5vZGUtPnNhZmVfcHNxbCgncG9zdGdyZXMnLCBxe2NoZWNr
cG9pbnR9KTsKIAotIyBJbnNlcnQgMk0gcm93czsgdGhhdCdzIGFib3V0IDI2ME1CICh+MjAgc2Vn
bWVudHMpIHdvcnRoIG9mIFdBTC4KKyMgSW5zZXJ0IDUwSyByb3dzOyB0aGF0J3MgYWJvdXQgODZN
QiAofjUgc2VnbWVudHMpIHdvcnRoIG9mIFdBTC4KICRub2RlLT5zYWZlX3BzcWwoJ3Bvc3RncmVz
JywKLQlxe2luc2VydCBpbnRvIHQgKGIpIHNlbGVjdCBtZDUoaTo6dGV4dCkgZnJvbSBnZW5lcmF0
ZV9zZXJpZXMoMSwxMDAwMDApIHMoaSl9CisJcXtpbnNlcnQgaW50byB0IChiKSBzZWxlY3QgcmVw
ZWF0KG1kNShpOjp0ZXh0KSw1MCkgZnJvbSBnZW5lcmF0ZV9zZXJpZXMoMSw1MDAwMCkgcyhpKX0K
ICk7CiAKICMgQWR2YW5jZSBzbG90IHRvIHRoZSBjdXJyZW50IHBvc2l0aW9uLCBqdXN0IHRvIGhh
dmUgZXZlcnl0aGluZyAidmFsaWQiLgpAQCAtNTYsOSArNTYsOSBAQCAkbm9kZS0+c2FmZV9wc3Fs
KCdwb3N0Z3JlcycsCiAjIFJ1biBhbm90aGVyIGNoZWNrcG9pbnQgdG8gc2V0IGEgbmV3IHJlc3Rv
cmUgTFNOLgogJG5vZGUtPnNhZmVfcHNxbCgncG9zdGdyZXMnLCBxe2NoZWNrcG9pbnR9KTsKIAot
IyBBbm90aGVyIDJNIHJvd3M7IHRoYXQncyBhYm91dCAyNjBNQiAofjIwIHNlZ21lbnRzKSB3b3J0
aCBvZiBXQUwuCisjIEFub3RoZXIgNTBLIHJvd3M7IHRoYXQncyBhYm91dCA4Nk1CICh+NSBzZWdt
ZW50cykgd29ydGggb2YgV0FMLgogJG5vZGUtPnNhZmVfcHNxbCgncG9zdGdyZXMnLAotCXF7aW5z
ZXJ0IGludG8gdCAoYikgc2VsZWN0IG1kNShpOjp0ZXh0KSBmcm9tIGdlbmVyYXRlX3Nlcmllcygx
LDEwMDAwMDApIHMoaSl9CisJcXtpbnNlcnQgaW50byB0IChiKSBzZWxlY3QgcmVwZWF0KG1kNShp
Ojp0ZXh0KSw1MCkgZnJvbSBnZW5lcmF0ZV9zZXJpZXMoMSw1MDAwMCkgcyhpKX0KICk7CiAKIG15
ICRyZXN0YXJ0X2xzbl9pbml0ID0gJG5vZGUtPnNhZmVfcHNxbCgncG9zdGdyZXMnLAotLSAKMi4z
OS41IChBcHBsZSBHaXQtMTU0KQoK
--000000000000b5681106379a3881--