MIME-Version: 1.0
References: <db087c3e-230e-4119-8a03-8b5d74956bc2@gmail.com>
 <CAN4CZFN83RsDejW5e9P1pCzAB6LKCgsBkAZk-4Y_UscBXtdJ1Q@mail.gmail.com>
 <1981b5f0-7d06-4911-a231-23bbb6bf504c@gmail.com> <CAN4CZFP5oVKkjAeb7-jrWR8spqvnhQq7HSTMhpWBiYuPmtqyjg@mail.gmail.com>
In-Reply-To: <CAN4CZFP5oVKkjAeb7-jrWR8spqvnhQq7HSTMhpWBiYuPmtqyjg@mail.gmail.com>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Mon, 26 Jan 2026 15:33:50 +0200
Message-ID: <CAPpHfdvWbF2S6fsc+dF=7OjLG6iFXVcDH+MK0aVKzaH9iptLvQ@mail.gmail.com>
Subject: Re: Use correct collation in pg_trgm
To: Zsolt Parragi <zsolt.parragi@percona.com>
Cc: David Geier <geidav.pg@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, 
	Heikki Linnakangas <hlinnaka@iki.fi>, Kirill Reshke <reshkekirill@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAPpHfdvWbF2S6fsc%2BdF%3D7OjLG6iFXVcDH%2BMK0aVKzaH9iptLvQ%40mail.gmail.com>
Precedence: bulk

Hi!

Thank you for working on this.

On Mon, Jan 26, 2026 at 3:24=E2=80=AFPM Zsolt Parragi <zsolt.parragi@percon=
a.com> wrote:
>
> > While reading through [1] I realized that the word boundary detection
> > also uses the wrong collation. Patch 0002 fixes that.
>
> Good catch, I considered checking that when I reviewed the patch, but
> I thought that it would be an issue with CJK languages, and I was
> completely wrong about that.
>
> Updated patch looks good, I only noticed two minor things:
>
> * the new test should have a newline at the end of the file
> * and probably a conditional skip based on locale availability, the
> citext_utf8.sql test case does something similar

I wonder about existing indexes, which already use default collation
not column collation.  Should we add a release note saying they might
be obsolete?  Alternatively, given we now have opclass options, we may
add a new opclass option defining whether to use column collation
(must be false for existing indexes).

------
Regards,
Alexander Korotkov
Supabase