MIME-Version: 1.0
References: <CAMbWs49c_7dT_oiP729b-JPRiDtTuDca3exN_cOZZwjGG-0bMA@mail.gmail.com>
 <b907ce77-c054-4009-a871-4d55cb3f73f9@postgrespro.ru> <fdaa003e-919c-cbc9-4f0c-e4546e96bd65@gmail.com>
 <edfbd846-dcc1-42d1-ac26-715691b687d3@postgrespro.ru> <0f655bcd-6487-4179-f9cf-c248efbad510@gmail.com>
 <ZjFRSVnvvGrsdndU@pryzbyj2023> <41117807-3bea-45bc-a9c0-743c29abff2d@postgrespro.ru>
 <ZjTlQiBPYm707Rxv@pryzbyj2023> <CAPpHfduhHm+4yeObsj9wK4iZvV2Ve5xcr6BwZDFiNBYbE1PfLg@mail.gmail.com>
 <CAPpHfdtgLiT2d++-qLircLB8ATUfzgR=aTmRDdF7w=2E9yDHbQ@mail.gmail.com> <Zjvwqs-GV0MjWIhU@pryzbyj2023>
In-Reply-To: <Zjvwqs-GV0MjWIhU@pryzbyj2023>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Thu, 9 May 2024 00:51:32 +0300
Message-ID: <CAPpHfdvh_XYHahtpoxfzDkvYOFUH1F5tm3JTV=sOZt8M4CTBcA@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Dmitry Koval <d.koval@postgrespro.ru>, Alexander Lakhin <exclusion@gmail.com>, 
	pgsql-hackers@lists.postgresql.org, 
	Tomas Vondra <tomas.vondra@enterprisedb.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAPpHfdvh_XYHahtpoxfzDkvYOFUH1F5tm3JTV%3DsOZt8M4CTBcA%40mail.gmail.com>
Precedence: bulk

On Thu, May 9, 2024 at 12:37=E2=80=AFAM Justin Pryzby <pryzby@telsasoft.com=
> wrote:
>
> On Wed, May 08, 2024 at 09:00:10PM +0300, Alexander Korotkov wrote:
> > On Fri, May 3, 2024 at 4:32=E2=80=AFPM Alexander Korotkov <aekorotkov@g=
mail.com> wrote:
> > > On Fri, May 3, 2024 at 4:23=E2=80=AFPM Justin Pryzby <pryzby@telsasof=
t.com> wrote:
> > > > On Wed, May 01, 2024 at 10:51:24PM +0300, Dmitry Koval wrote:
> > > > > 30.04.2024 23:15, Justin Pryzby =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > > > > > Is this issue already fixed ?
> > > > > > I wasn't able to reproduce it.  Maybe it only happened with ear=
lier
> > > > > > patch versions applied ?
> > > > >
> > > > > I think this was fixed in commit [1].
> > > > >
> > > > > [1] https://github.com/postgres/postgres/commit/fcf80c5d5f0f3787e=
70fca8fd029d2e08a923f91
> > > >
> > > > I tried to reproduce it at fcf80c5d5f~, but couldn't.
> > > > I don't see how that patch would fix it anyway.
> > > > I'm hoping Alexander can confirm what happened.
> > >
> > > This problem is only relevant for an old version of fix [1], which
> > > overrides schemas for new partitions.  That version was never
> > > committed.
> >
> > Here are the patches.
> > 0002 Skips copying extended statistics while creating new partitions in=
 MERGE/SPLIT
> >
> > For 0002 I'd like to hear some feedback on wordings used in docs and co=
mments.
>
> commit message:
>
> Currenlty =3D> Currently
> partiions =3D> partitios
> copying =3D> by copying


Thank you!

>
> > However, parent's table extended statistics already covers all its
> > children.
>
> =3D> That's the wrong explanation.  It's not that "stats on the parent
> table cover its children".  It's that there are two types of stats:
> stats for the "table hierarchy" and stats for the individual table.
> That's true for single-column stats as well as for extended stats.
> In both cases, that's indicated by the inh flag in the code and in the
> catalog.
>
> The right explanation is that extended stats on partitioned tables are
> not similar to indexes.  Indexes on parent table are nothing other than
> a mechanism to create indexes on the child tables.  That's not true for
> stats.
>
> See also my prior messages
> ZiJW1g2nbQs9ekwK@pryzbyj2023
> Zi5Msg74C61DjJKW@pryzbyj2023

Yes, I understand that parents pg_statistic entry with stainherit =3D=3D
true includes statistics for the children.  I tried to express this by
word "covers".  But you're right, this is the wrong explanation.

Can I, please, ask you to revise the patch?

> I think EXCLUDE IDENTITY can/should now also be removed - see 509199587.
> I'm not able to reproduce that problem anyway, even before that...

I will check this.

------
Regards,
Alexander Korotkov
Supabase