MIME-Version: 1.0
References: <PUrgXj3toL_CVxytc7fzYQNlY5FiUllklbS9UL1wU5ptiJAC2ChrF64EwO8neCKU9QnET5Zjv1HpMLFAgQPJQxOzM9f49jjkV56gEpUOYw8=@protonmail.com>
 <CAPzjO7U4oM8pkLOPrMq=ugWHqjfo-a1hdm6rd2Y+y+Xqt_Tkdw@mail.gmail.com>
 <jj4b3wolr7gt3rjjvv7yw2luv5kho7s4t5sizwoq4vjbdsxvce@twycelwxpdxq>
 <CAPzjO7X+0GG+sCn73tQughD+R+VHRdqj2cqGMk=UoC6h--=EXQ@mail.gmail.com> <CAMaYL5ZrpwPwX+eF3tXZEy3+y4=-1p_keBWubvdFZPydeqmPpA@mail.gmail.com>
In-Reply-To: <CAMaYL5ZrpwPwX+eF3tXZEy3+y4=-1p_keBWubvdFZPydeqmPpA@mail.gmail.com>
From: Stefan Fercot <stefan.fercot@dataegret.com>
Date: Fri, 18 Oct 2024 14:39:26 +0200
Message-ID: <CAPzjO7VYFFeeMAFL4j2JsDTtDGG2FdnOXU5LN+JrbbkKrvr=ew@mail.gmail.com>
Subject: Re: Recovery of .partial WAL segments
To: Stepan Neretin <sndcppg@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000009203260624bf98e2"
Archived-At: <https://www.postgresql.org/message-id/CAPzjO7VYFFeeMAFL4j2JsDTtDGG2FdnOXU5LN%2BJrbbkKrvr%3Dew%40mail.gmail.com>
Precedence: bulk

--0000000000009203260624bf98e2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Oct 18, 2024 at 11:07=E2=80=AFAM Stepan Neretin <sndcppg@gmail.com>=
 wrote:

> Hi there! It looks good to me!
>

Thanks!

But I have a question. How is the partialxlogfname freed in case of an
> error?


I'm not sure I understand your question. What kind of error would you
expect exactly?
I mostly added a pfree there because we don't need it further. But why
would it be more of a problem compared to other variables/pointers?

Kind regards,
Stefan

--0000000000009203260624bf98e2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,<br></div><br><div class=3D"gmail_quote"><div dir=
=3D"ltr" class=3D"gmail_attr">On Fri, Oct 18, 2024 at 11:07=E2=80=AFAM Step=
an Neretin &lt;<a href=3D"mailto:sndcppg@gmail.com">sndcppg@gmail.com</a>&g=
t; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div d=
ir=3D"ltr"><div><span style=3D"white-space:pre-wrap">Hi there! It looks goo=
d to me!<br></span></div></div></blockquote><div><br></div><div>Thanks!</di=
v><div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span st=
yle=3D"white-space:pre-wrap">But I have a question. How is the partialxlogf=
name freed in case of an error?</span></blockquote><div><br></div><div>I=
9;m not sure I understand your question. What kind of error would you expec=
t exactly?</div><div>I mostly added a pfree there because we don&#39;t need=
 it further. But why would it be more of a problem compared to other variab=
les/pointers?</div><div><br></div><div>Kind regards,<br></div><div>Stefan</=
div></div></div>

--0000000000009203260624bf98e2--