MIME-Version: 1.0
References: <PUrgXj3toL_CVxytc7fzYQNlY5FiUllklbS9UL1wU5ptiJAC2ChrF64EwO8neCKU9QnET5Zjv1HpMLFAgQPJQxOzM9f49jjkV56gEpUOYw8=@protonmail.com>
 <CAPzjO7U4oM8pkLOPrMq=ugWHqjfo-a1hdm6rd2Y+y+Xqt_Tkdw@mail.gmail.com> <jj4b3wolr7gt3rjjvv7yw2luv5kho7s4t5sizwoq4vjbdsxvce@twycelwxpdxq>
In-Reply-To: <jj4b3wolr7gt3rjjvv7yw2luv5kho7s4t5sizwoq4vjbdsxvce@twycelwxpdxq>
From: Stefan Fercot <stefan.fercot@dataegret.com>
Date: Fri, 9 Aug 2024 20:25:34 +0200
Message-ID: <CAPzjO7X+0GG+sCn73tQughD+R+VHRdqj2cqGMk=UoC6h--=EXQ@mail.gmail.com>
Subject: Re: Recovery of .partial WAL segments
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000009a78bc061f444582"
Archived-At: <https://www.postgresql.org/message-id/CAPzjO7X%2B0GG%2BsCn73tQughD%2BR%2BVHRdqj2cqGMk%3DUoC6h--%3DEXQ%40mail.gmail.com>
Precedence: bulk

--0000000000009a78bc061f444582
Content-Type: multipart/alternative; boundary="0000000000009a78bb061f444580"

--0000000000009a78bb061f444580
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Aug 9, 2024 at 4:29=E2=80=AFPM Dmitry Dolgov <9erthalion6@gmail.com=
> wrote:

> Seems like the retry loop from 019_replslot_limit might help.
>

Thanks for the tip. Attached v2 adds the retry loop in the test which would
hopefully fix the cfbot.

Kind Regards,
Stefan

--0000000000009a78bb061f444580
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><div></div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Fri, Aug 9, 2024 at 4:29=E2=80=AFPM =
Dmitry Dolgov &lt;<a href=3D"mailto:9erthalion6@gmail.com">9erthalion6@gmai=
l.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex">Seems like the retry loop from 019_replslot_limit might help.<br></blo=
ckquote><div><br></div><div>Thanks for the tip. Attached v2 adds the retry =
loop in the test which would hopefully fix the cfbot.</div><div><br></div><=
div>Kind Regards,<br>Stefan </div></div></div>

--0000000000009a78bb061f444580--
--0000000000009a78bc061f444582
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="v2-0001-Make-XLogFileRead-try-to-restore-.partial-wal-arc.patch"
Content-Disposition: attachment; 
	filename="v2-0001-Make-XLogFileRead-try-to-restore-.partial-wal-arc.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lzn19m1f0>
X-Attachment-Id: f_lzn19m1f0

RnJvbSAyMDM3NDczOTQ1MDNiNDc5MzM4OTgwOTQ4Y2NiM2RmODRkYzhkMWExIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gRmVyY290IDxwZ3N0ZWZAZmVyY290LmJlPgpEYXRl
OiBGcmksIDUgQXByIDIwMjQgMTA6NTc6MDMgKzAyMDAKU3ViamVjdDogW1BBVENIIHYyLl0gTWFr
ZSBYTG9nRmlsZVJlYWQgdHJ5IHRvIHJlc3RvcmUgLnBhcnRpYWwgd2FsIGFyY2hpdmVzCgpUcnkg
dG8gcmVzdG9yZSB0aGUgbm9ybWFsIGFyY2hpdmVkIHdhbCBzZWdtZW50IGZpcnN0IGFuZCwgaWYg
bm90IGZvdW5kLCB0aGVuIHRyeSB0byByZXN0b3JlIHRoZSBhcmNoaXZlZCAucGFydGlhbCB3YWwg
c2VnbWVudC4KVGhpcyBpcyBzYWZlIGJlY2F1c2UgdGhlIG5leHQgY29tcGxldGVkIHdhbCBzZWdt
ZW50IHNob3VsZCBjb250YWluIGF0IGxlYXN0IHRoZSBzYW1lIGRhdGEuCi0tLQogc3JjL2JhY2tl
bmQvYWNjZXNzL3RyYW5zYW0veGxvZ3JlY292ZXJ5LmMgfCAyMCArKysrKysrKystCiBzcmMvdGVz
dC9yZWNvdmVyeS90LzAyOF9waXRyX3RpbWVsaW5lcy5wbCB8IDQ3ICsrKysrKysrKysrKysrKysr
KysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDY0IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0p
CgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZ3JlY292ZXJ5LmMg
Yi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9ncmVjb3ZlcnkuYwppbmRleCAyZWQzZWEy
YjQ1Li5jOGU3OTNlM2Q5IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94
bG9ncmVjb3ZlcnkuYworKysgYi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9ncmVjb3Zl
cnkuYwpAQCAtNDE5Niw2ICs0MTk2LDggQEAgWExvZ0ZpbGVSZWFkKFhMb2dTZWdObyBzZWdubywg
aW50IGVtb2RlLCBUaW1lTGluZUlEIHRsaSwKIAljaGFyCQlhY3Rpdml0eW1zZ1tNQVhGTkFNRUxF
TiArIDE2XTsKIAljaGFyCQlwYXRoW01BWFBHUEFUSF07CiAJaW50CQkJZmQ7CisJY2hhcgkgICAq
cGFydGlhbHhsb2dmbmFtZTsKKwlib29sCQlyZXN0b3JlZEFyY2hpdmVkRmlsZTsKIAogCVhMb2dG
aWxlTmFtZSh4bG9nZm5hbWUsIHRsaSwgc2Vnbm8sIHdhbF9zZWdtZW50X3NpemUpOwogCkBAIC00
MjA3LDEwICs0MjA5LDI0IEBAIFhMb2dGaWxlUmVhZChYTG9nU2VnTm8gc2Vnbm8sIGludCBlbW9k
ZSwgVGltZUxpbmVJRCB0bGksCiAJCQkJCSB4bG9nZm5hbWUpOwogCQkJc2V0X3BzX2Rpc3BsYXko
YWN0aXZpdHltc2cpOwogCi0JCQlpZiAoIVJlc3RvcmVBcmNoaXZlZEZpbGUocGF0aCwgeGxvZ2Zu
YW1lLAorCQkJLyoKKwkJCSAqIFRyeSB0byByZXN0b3JlIHRoZSBub3JtYWwgd2FsIHNlZ21lbnQg
Zmlyc3QgYW5kLCBpZiBub3QgZm91bmQsCisJCQkgKiB0aGVuIHRyeSB0byByZXN0b3JlIHRoZSAu
cGFydGlhbCB3YWwgc2VnbWVudC4KKwkJCSAqLworCisJCQlwYXJ0aWFseGxvZ2ZuYW1lID0gcHNw
cmludGYoIiVzLnBhcnRpYWwiLCB4bG9nZm5hbWUpOworCisJCQlyZXN0b3JlZEFyY2hpdmVkRmls
ZSA9ICFSZXN0b3JlQXJjaGl2ZWRGaWxlKHBhdGgsIHhsb2dmbmFtZSwKKwkJCQkJCQkJCQkJCQkJ
IlJFQ09WRVJZWExPRyIsCisJCQkJCQkJCQkJCQkJCXdhbF9zZWdtZW50X3NpemUsCisJCQkJCQkJ
CQkJCQkJCUluUmVkbykgJiYKKwkJCQkhUmVzdG9yZUFyY2hpdmVkRmlsZShwYXRoLCBwYXJ0aWFs
eGxvZ2ZuYW1lLAogCQkJCQkJCQkJICJSRUNPVkVSWVhMT0ciLAogCQkJCQkJCQkJIHdhbF9zZWdt
ZW50X3NpemUsCi0JCQkJCQkJCQkgSW5SZWRvKSkKKwkJCQkJCQkJCSBJblJlZG8pOworCisJCQlw
ZnJlZShwYXJ0aWFseGxvZ2ZuYW1lKTsKKwkJCWlmIChyZXN0b3JlZEFyY2hpdmVkRmlsZSkKIAkJ
CQlyZXR1cm4gLTE7CiAJCQlicmVhazsKIApkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVjb3Zlcnkv
dC8wMjhfcGl0cl90aW1lbGluZXMucGwgYi9zcmMvdGVzdC9yZWNvdmVyeS90LzAyOF9waXRyX3Rp
bWVsaW5lcy5wbAppbmRleCA0YjdkODI1YjcxLi5hOTU4YTBjNmU3IDEwMDY0NAotLS0gYS9zcmMv
dGVzdC9yZWNvdmVyeS90LzAyOF9waXRyX3RpbWVsaW5lcy5wbAorKysgYi9zcmMvdGVzdC9yZWNv
dmVyeS90LzAyOF9waXRyX3RpbWVsaW5lcy5wbApAQCAtMTEwLDcgKzExMCw3IEBAICRub2RlX3N0
YW5kYnktPnN0b3A7CiAjIHNlZ21lbnQgMDAwMDAwMDIwMDAwMDAwMDAwMDAwMDAzLCBiZWZvcmUg
dGhlIHRpbWVsaW5lIHN3aXRjaGluZwogIyByZWNvcmQuICAoVGhleSBhcmUgYWxzbyBwcmVzZW50
IGluIHRoZQogIyAwMDAwMDAwMTAwMDAwMDAwMDAwMDAwMDMucGFydGlhbCBmaWxlLCBidXQgLnBh
cnRpYWwgZmlsZXMgYXJlIG5vdAotIyB1c2VkIGF1dG9tYXRpY2FsbHkuKQorIyB1c2VkIHdoZW4g
cmVjb3ZlcmluZyBhbG9uZyB0aGUgbGF0ZXN0IHRpbWVsaW5lIGJ5IGRlZmF1bHQuKQogCiAjIE5v
dyB0ZXN0IFBJVFIgdG8gdGhlIHJlY292ZXJ5IHRhcmdldC4gIEl0IHNob3VsZCBmaW5kIHRoZSBX
QUwgaW4KICMgc2VnbWVudCAwMDAwMDAwMjAwMDAwMDAwMDAwMDAwMDMsIGJ1dCBub3QgZm9sbG93
IHRoZSB0aW1lbGluZSBzd2l0Y2gKQEAgLTE3Myw0ICsxNzMsNDkgQEAgJG5vZGVfcGl0cjItPnBv
bGxfcXVlcnlfdW50aWwoJ3Bvc3RncmVzJywgIlNFTEVDVCBwZ19pc19pbl9yZWNvdmVyeSgpID0g
J2YnOyIpCiAkcmVzdWx0ID0gJG5vZGVfcGl0cjItPnNhZmVfcHNxbCgncG9zdGdyZXMnLCAiU0VM
RUNUIG1heChpKSBGUk9NIGZvbzsiKTsKIGlzKCRyZXN1bHQsIHFxezN9LCAiY2hlY2sgdGFibGUg
Y29udGVudHMgYWZ0ZXIgcG9pbnQtaW4tdGltZSByZWNvdmVyeSIpOwogCisjIFRoZSAwMDAwMDAw
MTAwMDAwMDAwMDAwMDAwMDMucGFydGlhbCBmaWxlIGNvdWxkIGhhdmUgYmVlbiBnZW5lcmF0ZWQK
KyMgYnkgcGdfcmVjZWl2ZXdhbCB3aXRob3V0IGFueSBzdGFuZGJ5IG5vZGUgaW52b2x2ZWQuIElu
IHRoaXMgY2FzZSwgd2UKKyMgd291bGRuJ3QgYmUgYWJsZSB0byByZWNvdmVyIGZyb20gMDAwMDAw
MDIwMDAwMDAwMDAwMDAwMDAzLgorIyBOb3csIHRlc3QgUElUUiB0byB0aGUgaW5pdGlhbCByZWNv
dmVyeSB0YXJnZXQgc3RheWluZyBvbiB0aGUgYmFja3VwJ3MKKyMgY3VycmVudCB0aW1lbGluZSwg
dHJ5aW5nIHRvIGZldGNoIHRoZSBkYXRhIGZyb20gdGhlCisjIDAwMDAwMDAxMDAwMDAwMDAwMDAw
MDAwMy5wYXJ0aWFsIGZpbGUuCisKK215ICRub2RlX3BpdHIzID0gUG9zdGdyZVNRTDo6VGVzdDo6
Q2x1c3Rlci0+bmV3KCdub2RlX3BpdHIzJyk7Ciskbm9kZV9waXRyMy0+aW5pdF9mcm9tX2JhY2t1
cCgKKwkkbm9kZV9wcmltYXJ5LCAkYmFja3VwX25hbWUsCisJc3RhbmRieSA9PiAwLAorCWhhc19y
ZXN0b3JpbmcgPT4gMSk7Ciskbm9kZV9waXRyMy0+YXBwZW5kX2NvbmYoCisJJ3Bvc3RncmVzcWwu
Y29uZicsIHFxeworcmVjb3ZlcnlfdGFyZ2V0X25hbWUgPSAncnAnCityZWNvdmVyeV90YXJnZXRf
YWN0aW9uID0gJ3Byb21vdGUnCityZWNvdmVyeV90YXJnZXRfdGltZWxpbmUgPSAnY3VycmVudCcK
K30pOworCitteSAkbG9nX29mZnNldCA9IC1zICRub2RlX3BpdHIzLT5sb2dmaWxlOworJG5vZGVf
cGl0cjMtPnN0YXJ0OworCitteSAkbXNnX2xvZ2dlZCA9IDA7CitteSAkbWF4X2F0dGVtcHRzID0g
JFBvc3RncmVTUUw6OlRlc3Q6OlV0aWxzOjp0aW1lb3V0X2RlZmF1bHQ7Cit3aGlsZSAoJG1heF9h
dHRlbXB0cy0tID49IDApCit7CisJaWYgKCRub2RlX3BpdHIzLT5sb2dfY29udGFpbnMoCisJCQki
cmVzdG9yZWQgbG9nIGZpbGUgXCIwMDAwMDAwMTAwMDAwMDAwMDAwMDAwMDMucGFydGlhbFwiIGZy
b20gYXJjaGl2ZSIsCisJCQkkbG9nX29mZnNldCkpCisJeworCQkkbXNnX2xvZ2dlZCA9IDE7CisJ
CWxhc3Q7CisJfQorCXNsZWVwIDE7Cit9CitvaygkbXNnX2xvZ2dlZCwgInJlc3RvcmVkIDAwMDAw
MDAxMDAwMDAwMDAwMDAwMDAwMy5wYXJ0aWFsIik7CisKKyMgV2FpdCB1bnRpbCByZWNvdmVyeSBm
aW5pc2hlcy4KKyRub2RlX3BpdHIzLT5wb2xsX3F1ZXJ5X3VudGlsKCdwb3N0Z3JlcycsICJTRUxF
Q1QgcGdfaXNfaW5fcmVjb3ZlcnkoKSA9ICdmJzsiKQorICBvciBkaWUgIlRpbWVkIG91dCB3aGls
ZSB3YWl0aW5nIGZvciBQSVRSIHByb21vdGlvbiI7CisKKyMgQ2hlY2sgdGhhdCB3ZSBzZWUgdGhl
IGRhdGEgd2UgZXhwZWN0LgorJHJlc3VsdCA9ICRub2RlX3BpdHIzLT5zYWZlX3BzcWwoJ3Bvc3Rn
cmVzJywgIlNFTEVDVCBtYXgoaSkgRlJPTSBmb287Iik7CitpcygkcmVzdWx0LCBxcXsxfSwgImNo
ZWNrIHRhYmxlIGNvbnRlbnRzIGFmdGVyIHBvaW50LWluLXRpbWUgcmVjb3ZlcnkiKTsKKwogZG9u
ZV90ZXN0aW5nKCk7Ci0tIAoyLjM0LjEKCg==
--0000000000009a78bc061f444582--