Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfwEX-0007nb-1F for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Oct 2021 03:37:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mfwEV-0002Js-5Q for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Oct 2021 03:37:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfwEU-0002JR-L5 for pgsql-hackers@lists.postgresql.org; Thu, 28 Oct 2021 03:37:38 +0000 Received: from smtp-fw-9103.amazon.com ([207.171.188.200]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfwEO-0004FO-RJ for pgsql-hackers@postgresql.org; Thu, 28 Oct 2021 03:37:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1635392252; x=1666928252; h=from:to:subject:date:message-id:mime-version; bh=wfsFoqIHElgvLzmrvm596/OmdqsFwiGYiGjhKJaExw0=; b=Dybr3mJ9LkQtZLr8n/DcBj6QneUQCM/R4t7LOSUTj1c1tF7iPbiuiSmA xeQS3xwEjMy9v5ORFtL971THh/7U1m29EGhkCFnq0Wl01RExFTOOnRjrB aEw3SFD+DR3JzflMvi6dRhcp1a5qdJxaJX1eRH2sUuU4UzHvK+pXQxmQK U=; X-Amazon-filename: improve_loop.patch X-IronPort-AV: E=Sophos;i="5.87,188,1631577600"; d="scan'208";a="967856371" Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1e-0bfdb89e.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-9103.sea19.amazon.com with ESMTP; 28 Oct 2021 03:37:31 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-0bfdb89e.us-east-1.amazon.com (Postfix) with ESMTPS id 8F546E017F for ; Thu, 28 Oct 2021 03:37:30 +0000 (UTC) Received: from EX13D03UWC003.ant.amazon.com (10.43.162.79) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.24; Thu, 28 Oct 2021 03:37:29 +0000 Received: from EX13D03UWC004.ant.amazon.com (10.43.162.49) by EX13D03UWC003.ant.amazon.com (10.43.162.79) with Microsoft SMTP Server (TLS) id 15.0.1497.24; Thu, 28 Oct 2021 03:37:29 +0000 Received: from EX13D03UWC004.ant.amazon.com ([10.43.162.49]) by EX13D03UWC004.ant.amazon.com ([10.43.162.49]) with mapi id 15.00.1497.024; Thu, 28 Oct 2021 03:37:29 +0000 From: "Bossart, Nathan" To: "pgsql-hackers@postgresql.org" Subject: inefficient loop in StandbyReleaseLockList() Thread-Topic: inefficient loop in StandbyReleaseLockList() Thread-Index: AQHXy60hDCrPdFjQ0k6deEIHcwG+yA== Date: Thu, 28 Oct 2021 03:37:29 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.162.43] Content-Type: multipart/mixed; boundary="_002_CD2F0E7F982245ECA411AE56F14DEA9Famazoncom_" MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --_002_CD2F0E7F982245ECA411AE56F14DEA9Famazoncom_ Content-Type: text/plain; charset="utf-8" Content-ID: <49B2EC4EEFF52F4296582671609CEDE2@amazon.com> Content-Transfer-Encoding: base64 SGkgaGFja2VycywNCg0KSSd2ZSBzZWVuIGEgZmV3IGNhc2VzIG5vdyBmb3IgdjEzIHdoZXJlIHRo ZSBzdGFydHVwIHByb2Nlc3Mgb24gYQ0Kc3RhbmRieSBhcHBlYXJzIHRvIGJlIHN0dWNrIG9uIFN0 YW5kYnlSZWxlYXNlTG9ja0xpc3QoKS4gIEl0IGxvb2tzDQpsaWtlIG1vc3Qgb2YgdGhlIHRpbWUg aXMgc3BlbnQgb24gbGlzdF9kZWxldGVfZmlyc3QoKS4gIEkgYmVsaWV2ZSB0aGlzDQppcyByZWxh dGVkIHRvIHRoZSByZWNlbnQgbGlzdCByZXdyaXRlICgxY2ZmMWI5KSwgd2hpY2ggaGFzIHRoZQ0K Zm9sbG93aW5nIG5vdGUgaW4gdGhlIGNvbW1pdCBtZXNzYWdlOg0KDQogICAgICAgICogSW5zZXJ0 aW5nIG9yIGRlbGV0aW5nIGEgbGlzdCBlbGVtZW50IG5vdyB0YWtlcyB0aW1lIHByb3BvcnRpb25h bCB0bw0KICAgICAgICB0aGUgZGlzdGFuY2UgdG8gdGhlIGVuZCBvZiB0aGUgbGlzdCwgZHVlIHRv IG1vdmluZyB0aGUgYXJyYXkgZWxlbWVudHMuDQogICAgICAgIChIb3dldmVyLCBpdCB0eXBpY2Fs bHkgKmRvZXNuJ3QqIHJlcXVpcmUgcGFsbG9jIG9yIHBmcmVlLCBzbyBleGNlcHQgaW4NCiAgICAg ICAgbG9uZyBsaXN0cyBpdCdzIHByb2JhYmx5IHN0aWxsIGZhc3RlciB0aGFuIGJlZm9yZS4pICBO b3RhYmx5LCBsY29ucygpDQogICAgICAgIHVzZWQgdG8gYmUgYWJvdXQgdGhlIHNhbWUgY29zdCBh cyBsYXBwZW5kKCksIGJ1dCB0aGF0J3Mgbm8gbG9uZ2VyIHRydWUNCiAgICAgICAgaWYgdGhlIGxp c3QgaXMgbG9uZy4gIENvZGUgdGhhdCB1c2VzIGxjb25zKCkgYW5kIGxpc3RfZGVsZXRlX2ZpcnN0 KCkNCiAgICAgICAgdG8gbWFpbnRhaW4gYSBzdGFjayBtaWdodCB1c2VmdWxseSBiZSByZXdyaXR0 ZW4gdG8gcHVzaCBhbmQgcG9wIGF0IHRoZQ0KICAgICAgICBlbmQgb2YgdGhlIGxpc3QgcmF0aGVy IHRoYW4gdGhlIGJlZ2lubmluZy4NCg0KVGhlIGN1cnJlbnQgZm9ybSBvZiBTdGFuZGJ5UmVsZWFz ZUxvY2tMaXN0KCkgaXMgc29tZXRoaW5nIGxpa2UgdGhpczoNCg0KICAgICAgICB3aGlsZSAobXls aXN0ICE9IE5JTCkNCiAgICAgICAgew0KICAgICAgICAgICAgICAgIGludCBpID0gbGluaXRpYWxf aW50KG15bGlzdCk7DQogICAgICAgICAgICAgICAgLi4uDQogICAgICAgICAgICAgICAgbXlsaXN0 ID0gbGlzdF9kZWxldGVfZmlyc3QobXlsaXN0KTsNCiAgICAgICAgfQ0KDQpGb3IgYSBsb25nIGVu b3VnaCBsaXN0LCB0aGlzIGlzIHdpbGRseSBpbmVmZmljaWVudC4gIFRoZSBmb2xsb3dpbmcNCmZv cm0gaXMgbXVjaCBmYXN0ZXIgZm9yIGxvbmdlciBsaXN0czoNCg0KICAgICAgICBmb3JlYWNoKGxj LCBteWxpc3QpDQogICAgICAgIHsNCiAgICAgICAgICAgICAgICBpbnQgaSA9IGxmaXJzdF9pbnQo bGMpOw0KICAgICAgICAgICAgICAgIC4uLg0KICAgICAgICB9DQogICAgICAgIGxpc3RfZnJlZSht eWxpc3QpOw0KDQpJIHdyb3RlIHVwIGEgc2ltcGxlIHRlc3QgZnVuY3Rpb24gZm9yIGVhY2ggZm9y bS4gIEZvciBhIGxpc3Qgb2YNCjUwMCwwMDAgaW50ZWdlcnMsIHRoZSBmaXJzdCBmb3JtIHRvb2sg YWJvdXQgYSBtaW51dGUsIHdoaWxlIHRoZSBzZWNvbmQNCmZvcm0gdG9vayBhYm91dCA2IG1pbGxp c2Vjb25kcy4NCg0KSSd2ZSBhdHRhY2hlZCBhIHBhdGNoIHRoYXQgY29udmVydHMgU3RhbmRieVJl bGVhc2VMb2NrTGlzdCgpIHRvIHRoZQ0Kc2Vjb25kIGxvb3AgZm9ybS4NCg0KTmF0aGFuDQoNCg== --_002_CD2F0E7F982245ECA411AE56F14DEA9Famazoncom_ Content-Type: application/octet-stream; name="improve_loop.patch" Content-Description: improve_loop.patch Content-Disposition: attachment; filename="improve_loop.patch"; size=817; creation-date="Thu, 28 Oct 2021 03:37:29 GMT"; modification-date="Thu, 28 Oct 2021 03:37:29 GMT" Content-ID: <82D4861CCC882342A759EF894FA6C8AC@amazon.com> Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3N0b3JhZ2UvaXBjL3N0YW5kYnkuYyBiL3NyYy9iYWNr ZW5kL3N0b3JhZ2UvaXBjL3N0YW5kYnkuYwppbmRleCBiMTczMjZiYzIwLi4xNDk2ODU1OTI1IDEw MDY0NAotLS0gYS9zcmMvYmFja2VuZC9zdG9yYWdlL2lwYy9zdGFuZGJ5LmMKKysrIGIvc3JjL2Jh Y2tlbmQvc3RvcmFnZS9pcGMvc3RhbmRieS5jCkBAIC05ODYsOSArOTg2LDExIEBAIFN0YW5kYnlB Y3F1aXJlQWNjZXNzRXhjbHVzaXZlTG9jayhUcmFuc2FjdGlvbklkIHhpZCwgT2lkIGRiT2lkLCBP aWQgcmVsT2lkKQogc3RhdGljIHZvaWQKIFN0YW5kYnlSZWxlYXNlTG9ja0xpc3QoTGlzdCAqbG9j a3MpCiB7Ci0Jd2hpbGUgKGxvY2tzKQorCUxpc3RDZWxsICAgKmxjOworCisJZm9yZWFjaChsYywg bG9ja3MpCiAJewotCQl4bF9zdGFuZGJ5X2xvY2sgKmxvY2sgPSAoeGxfc3RhbmRieV9sb2NrICop IGxpbml0aWFsKGxvY2tzKTsKKwkJeGxfc3RhbmRieV9sb2NrICpsb2NrID0gKHhsX3N0YW5kYnlf bG9jayAqKSBsZmlyc3QobGMpOwogCQlMT0NLVEFHCQlsb2NrdGFnOwogCiAJCWVsb2codHJhY2Vf cmVjb3ZlcnkoREVCVUc0KSwKQEAgLTEwMDIsOSArMTAwNCw5IEBAIFN0YW5kYnlSZWxlYXNlTG9j a0xpc3QoTGlzdCAqbG9ja3MpCiAJCQkJIGxvY2stPnhpZCwgbG9jay0+ZGJPaWQsIGxvY2stPnJl bE9pZCk7CiAJCQlBc3NlcnQoZmFsc2UpOwogCQl9Ci0JCXBmcmVlKGxvY2spOwotCQlsb2NrcyA9 IGxpc3RfZGVsZXRlX2ZpcnN0KGxvY2tzKTsKIAl9CisKKwlsaXN0X2ZyZWVfZGVlcChsb2Nrcyk7 CiB9CiAKIHN0YXRpYyB2b2lkCg== --_002_CD2F0E7F982245ECA411AE56F14DEA9Famazoncom_--