public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Chao Li <[email protected]>
Cc: Postgres hackers <[email protected]>
Cc: Jacob Champion <[email protected]>
Subject: Re: Fix OAuth validator docs for error_detail on internal errors
Date: Fri, 5 Jun 2026 21:31:50 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

> On 5 Jun 2026, at 00:21, Chao Li <[email protected]> wrote:
>> On Jun 5, 2026, at 04:19, Daniel Gustafsson <[email protected]> wrote:
>> 
>>> On 4 Jun 2026, at 14:33, Chao Li <[email protected]> wrote:
>> 
>>> “Any result parameters are ignored” is no longer accurate; it should be something like “any result parameters except result->error_detail are ignored”. This patch just makes that tiny doc fix.
>> 
>> That's true, but error_detail is explained in detail in the next paragraph so
>> I'm not sure this change is needed.
> 
> Agreed. Adding the “exception for result->error_detail” sounds a bit redundant with the next paragraph. But “any result parameters are ignored” also seems to conflict with the next paragraph, so I think we can just delete that part.
> 
> ValidatorModuleResult has three fields, so the logic is:
> 
> * The first paragraph talks about authorized and authn_id when the validator succeeds.
> * The second paragraph talks about the validator’s return values.
> * The third paragraph talks about result->error_detail when the validator fails.
> 
>> Another thing we don't explicitly document which seems more interesting is that
>> authn_id is used even in case of failure if log_connections is enabled.  Maybe
>> that deserves a mention?
> 
> This is a good point. I added that in v2.

This version looks good to me, the authn_id sentence is a bit long so I might
do some careful rewording before pushing.

--
Daniel Gustafsson

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fix OAuth validator docs for error_detail on internal errors
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox