Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnmgy-0000IE-8r for pgsql-hackers@arkaria.postgresql.org; Sat, 15 Apr 2023 20:40:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pnmgw-0003Yr-A8 for pgsql-hackers@arkaria.postgresql.org; Sat, 15 Apr 2023 20:40:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnmgw-0003Yi-0Y for pgsql-hackers@lists.postgresql.org; Sat, 15 Apr 2023 20:40:14 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pnmgt-0036no-Hu for pgsql-hackers@postgresql.org; Sat, 15 Apr 2023 20:40:13 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id A08932F76437 for ; Sat, 15 Apr 2023 22:40:10 +0200 (CEST) Received: from s980.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 8E9862E289CE; Sat, 15 Apr 2023 22:40:10 +0200 (CEST) Received: from s474.loopia.se (unknown [172.22.191.5]) by s980.loopia.se (Postfix) with ESMTP id 891602201661; Sat, 15 Apr 2023 22:40:10 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s934.loopia.se ([172.22.191.6]) by s474.loopia.se (s474.loopia.se [172.22.190.14]) (amavisd-new, port 10024) with LMTP id gvU2ZB06G5oa; Sat, 15 Apr 2023 22:40:10 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s934.loopia.se (Postfix) with ESMTPSA id 8D29D7CEA5C; Sat, 15 Apr 2023 22:40:09 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Subject: Re: Should vacuum process config file reload more often From: Daniel Gustafsson In-Reply-To: Date: Sat, 15 Apr 2023 22:40:08 +0200 Cc: Melanie Plageman , Robert Haas , Andres Freund , Tom Lane , Kyotaro Horiguchi , PostgreSQL Hackers , Amit Kapila Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230329.132155.629765142788133576.horikyota.ntt@gmail.com> <20230329.173456.1185961934810139447.horikyota.ntt@gmail.com> <935191FB-083B-4060-89FC-466F61FAA391@yesql.se> <1252075.1680547394@sss.pgh.pa.us> <20230403190837.qubpnwugfe2k2g46@awork3.anarazel.de> <7E06F879-7E20-4A6A-862F-CA72CDC9A323@yesql.se> <5028847C-937A-4CC2-B127-AFF5F9FB79C5@yesql.se> <2B703533-102A-47E5-A4F7-C6A68C09BB27@yesql.se> <23D2F3D0-90C2-428A-817F-1E16194DDC2D@yesql.se> To: Masahiko Sawada X-Mailer: Apple Mail (2.3696.120.41.1.2) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 11 Apr 2023, at 17:05, Masahiko Sawada = wrote: > The comment of message_level_is_interesting() says: >=20 > * This is useful to short-circuit any expensive preparatory work that > * might be needed for a logging message. >=20 > Which can apply to taking a lwlock, I think. I agree that we can, and should, use message_level_is_interesting to = skip taking this lock. Also, the more I think about the more I'm convinced = that we should not change the current logging frequency of once per table from = what we ship today. In DEGUG2 the logs should tell the whole story without = requiring extrapolation based on missing entries. So I think we should use your = patch to solve this open item. If there is interest in reducing the logging = frequency we should discuss that in its own thread, insted of it being hidden in = here. -- Daniel Gustafsson