Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q17Ro-0006jw-OG for pgsql-hackers@arkaria.postgresql.org; Mon, 22 May 2023 15:27:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q17Rn-0005JU-Kb for pgsql-hackers@arkaria.postgresql.org; Mon, 22 May 2023 15:27:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q17Rn-0005JK-BJ for pgsql-hackers@lists.postgresql.org; Mon, 22 May 2023 15:27:43 +0000 Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q17Rj-001PhH-SU for pgsql-hackers@postgresql.org; Mon, 22 May 2023 15:27:42 +0000 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-19c7e1acf9eso794700fac.1 for ; Mon, 22 May 2023 08:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon-tech.20221208.gappssmtp.com; s=20221208; t=1684769259; x=1687361259; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Fnf9OKNt0gHyQqtmJcdf95VJQiNqhK7CIh1EDgk/mgE=; b=mkJY9lDh/xaYtiha1RJVlBd2ykabtS+FQ875qVT+gYGCjsCvrZH9PwrTzBu8LsY5xW QHXZSX+iDgFE7Y/tK6gn2dFJ6A8EzriNbi3LB7ogg6yqEO1GCvYK8PB0XH93iEg3NEbC ZifHjCpWj5SjUnfNn9wSJ6p9G6APqG+R9FP6XxwrWidVoIsSjT2EyAk9PABn/EVccdnH tHLNoliurbJVmRwp+6S8BQDzxMeXHlwlcYseddkgrbruU8z36uVvX4pTMiNZBf5gmqdN mxcv8Sxn5WUzdjMgyEmXRnXMyo4zT66YzMnlCIXExeavdJtzNhRXNjWK8Ug4tNZo5kdP 9NKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684769259; x=1687361259; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Fnf9OKNt0gHyQqtmJcdf95VJQiNqhK7CIh1EDgk/mgE=; b=cZk6Be2/BDhGhR2WaHDtciVe3b3fVDV5/hejBDA5kVjXfXy0LuZppSKMCG+hZjd42r /sRQCWuctn5I4YW+sWAxANicW7Krjp4P7dhWhAsCum4EymigxPRTMrnxo3xzCz1X4XrY KIDIDInhc3hwvYzfN0YYGguQuMFc65RDihp/ArJUlu/zrCDZ1tXK8jt83wcxOtopBTDL Wx4QlUA4q/mp5RL4NpZK3pV091PoqSu/k+1/ydfnTfrNcovTCBoqt9BiTtP3p7epSFJc 8vw0477p/lbBoFt2GURE9cG68N2GDDlH6y6J6xgDFy6EwUC97onl26tAZ6h/pac1WNQ6 HFqQ== X-Gm-Message-State: AC+VfDxy8SlRvx4Gd5CYaQWMpEXZd5iZZ/wScE4UboNZ353QTNlD/fhL 0ctFc0jvEds2LhvZGwqi1N5HvndOLhjmI2hOVzU= X-Google-Smtp-Source: ACHHUZ5kGe6/kfRqMO1xFWp2hZAFpfrG/AhvJ+PL2IfhqFbxyiRL+Ce1Y3uIMDgK0HZw7qHppAkc/g== X-Received: by 2002:a05:6871:205:b0:19d:d608:3a60 with SMTP id t5-20020a056871020500b0019dd6083a60mr2631034oad.22.1684769258947; Mon, 22 May 2023 08:27:38 -0700 (PDT) Received: from localhost ([2607:fb90:e602:57ee:8a4:550b:a504:c1ba]) by smtp.gmail.com with ESMTPSA id n5-20020a056870a44500b0018e996a507esm2576214oal.31.2023.05.22.08.27.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 08:27:38 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 22 May 2023 10:27:37 -0500 Message-Id: Subject: Re: Add missing includes From: "Tristan Partin" To: "Alvaro Herrera" Cc: X-Mailer: aerc 0.14.0 References: <20230522151657.vincyjdi56uedfhk@alvherre.pgsql> In-Reply-To: <20230522151657.vincyjdi56uedfhk@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon May 22, 2023 at 10:16 AM CDT, Alvaro Herrera wrote: > > Some files were missing information from the c.h header. > > Actually, these omissions are intentional, and we have bespoke handling > for this in our own header-checking scripts (src/tools/pginclude). I > imagine this is documented somewhere, but ATM I can't remember where. > (And if not, maybe that's something we should do.) Interesting. Thanks for the information. Thought I had seen in a different email thread that header files were supposed to include all that they needed to. Anyways, ignore the patch :). --=20 Tristan Partin Neon (https://neon.tech)