Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q43nB-0007We-MU for pgsql-hackers@arkaria.postgresql.org; Tue, 30 May 2023 18:09:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q43n8-0007gJ-CB for pgsql-hackers@arkaria.postgresql.org; Tue, 30 May 2023 18:09:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q43n7-0007gA-NA for pgsql-hackers@lists.postgresql.org; Tue, 30 May 2023 18:09:53 +0000 Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q43n4-002kHI-I2 for pgsql-hackers@postgresql.org; Tue, 30 May 2023 18:09:52 +0000 Received: by mail-ot1-x330.google.com with SMTP id 46e09a7af769-6ad13a1fbceso3479745a34.2 for ; Tue, 30 May 2023 11:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon-tech.20221208.gappssmtp.com; s=20221208; t=1685470189; x=1688062189; h=in-reply-to:references:subject:cc:from:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wN8X6oBZIqsdDkM14+y6zjB+bWQqaj0BGKd0t8DWbFc=; b=eZd52Kb38l3vWXk72Hsm1d5wfPAAONOjSVQOhvdbKneeXEQGevrMgKG8OOUfRZ8WL+ 4GehOumX/onrnBK2jrTsyYoCm/+yMNyEN3kESiEXAixFjY0+zcVcTW4uYMLl9u6ulXGu yh+EGA0CJu7x0AFFqln8bznfg7bSwirQFtvxfnGHOFsI1ZCd1j37wWGnl65TxrcRYpud A8/RwhpwqtMcqClUZ0jzUIouyLFXAQAXbc73OtJ8V4n4D9cy8bnemJQ4SfGjo/OYIYpI roxl80QjWrRD7XgoxYMW8VF7i593Wg/tvUc60diSN1yteEGuMA9UiCmcfSXtPx8OkbbJ vzPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685470189; x=1688062189; h=in-reply-to:references:subject:cc:from:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wN8X6oBZIqsdDkM14+y6zjB+bWQqaj0BGKd0t8DWbFc=; b=mBrAKp1I5G1AzLZo0WwIt26/dAm/mCSCGD2CK+pu14kFI79MLN57ueYSJ8+q0b2Uh9 7vihY1AWAdcq4Cf7Ljul65VDe28mcu9cqyO7VI5bmgVJoavY7B8GAOxZnOfw/RpXJv76 dQ1pgdvBHLLRfO6LeZVdMHHq4L6KDWWOwKMhuhESJovrh3MguFfEdhqYleB/lfhLs9pR ji6cgDNpzS9K5NK1FPdR3GwzI2pnUQToD83ixfD4apMeMjPIDb5i/NIUmhYEkbKD5ooy AeAvBVR4qJey4nPEZzss65Ygqls+nUgv8AX5t4XqnaSCaqsT9xfdOxwHPbJc1Af1r/J1 nelg== X-Gm-Message-State: AC+VfDyGwfAdwCl0XfZI+iZbwAZUyfcQaZ2XIKjZpI/R7Oc+qBQHEFPO hDGFU2Ac1cD/Co7kEpSYrNKt2Q== X-Google-Smtp-Source: ACHHUZ5VG+Z91B/rtUxqueBueuEdamsHworMXKt3OqCE/fVG693PeUMvXMeeMBFPglJCCZDMqBmXfQ== X-Received: by 2002:a9d:6295:0:b0:6af:9d30:4ba8 with SMTP id x21-20020a9d6295000000b006af9d304ba8mr26570otk.26.1685470189057; Tue, 30 May 2023 11:09:49 -0700 (PDT) Received: from localhost ([2607:fb90:e602:57ee:8a4:550b:a504:c1ba]) by smtp.gmail.com with ESMTPSA id j12-20020a9d7f0c000000b0069f9203967bsm5791972otq.76.2023.05.30.11.09.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 11:09:48 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 30 May 2023 13:09:47 -0500 Message-Id: To: "samay sharma" , "Peter Eisentraut" From: "Tristan Partin" Cc: "Andres Freund" , "Justin Pryzby" , "Nazir Bilal Yavuz" , "John Naylor" , Subject: Re: Documentation for building with meson X-Mailer: aerc 0.14.0 References: <20221105213903.fc7igvsbhnijdmqf@awork3.anarazel.de> <20221123063654.GH11463@telsasoft.com> <20221123201620.GK11463@telsasoft.com> <6f9c0595-1de0-ca15-b5fc-c650c3f57016@enterprisedb.com> <20221201172139.ua64fs5m7soyunqk@awork3.anarazel.de> <0517adcd-4fea-f20d-0a74-31f75627138e@enterprisedb.com> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hey! Nice work organizing the docs. Looks pretty good. I had a single comment regarding the Meson docs in general. It seems like Postgres cares a bit about Windows/Mac development. Is ninja the blessed way to build Postgres on Windows and Mac? Otherwise, I would suggest just being more generic and replace instances of `ninja xxx` in the docs with `meson compile xxx`, making the command backend-agnostic to accomodate XCode and VS project users. --=20 Tristan Partin Neon (https://neon.tech)