Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 01 Jun 2023 23:06:04 -0500
Subject: Re: [PATCH] Missing dep on Catalog.pm in meson rules
To: =?utf-8?q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
 "PostgreSQL Hackers" <pgsql-hackers@postgresql.org>
From: "Tristan Partin" <tristan@neon.tech>
Message-Id: <CT1V90ZD4ZPZ.2J5QU7ZEYSB60@gonk>
References: <87v8g7s6bf.fsf@wibble.ilmari.org>
 <CT1MJFE3PEEV.2S08CXLDYMCWP@gonk>
 <329a690c-1f4e-4759-8018-8ee562c159f0@app.fastmail.com>
In-Reply-To: <329a690c-1f4e-4759-8018-8ee562c159f0@app.fastmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/CT1V90ZD4ZPZ.2J5QU7ZEYSB60%40gonk>
Precedence: bulk

On Thu Jun 1, 2023 at 4:22 PM CDT, Dagfinn Ilmari Manns=C3=A5ker wrote:
> On Thu, 1 Jun 2023, at 22:16, Tristan Partin wrote:
> > Could you create a variable for the file instead of calling files() 3
> > times?
> >
> >> catalog_pm =3D files('path/to/Catalog.pm')
>
> Sure, but which meson.build file should it go in? I know nothing about me=
son variable scoping.

Not a problem. In Meson, variables are globally-scoped. You can use
unset_variable() however to unset it.

In our case, we should add the ^line to src/backend/catalog/meson.build.
I would say just throw the line after the copyright comment. Hopefully
there isn't a problem with the ordering of the Meson file tree traversal
(ie the targets you are changing are configured after we get through
src/backend/catalog/meson.build).

--=20
Tristan Partin
Neon (https://neon.tech)