Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 02 Jun 2023 08:10:43 -0500
Message-Id: <CT26U28ECWTA.3VIVYB9J55L4K@gonk>
Cc: =?utf-8?q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
 "PostgreSQL Hackers" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Missing dep on Catalog.pm in meson rules
To: "Andres Freund" <andres@anarazel.de>
From: "Tristan Partin" <tristan@neon.tech>
References: <87v8g7s6bf.fsf@wibble.ilmari.org>
 <CT1MJFE3PEEV.2S08CXLDYMCWP@gonk>
 <329a690c-1f4e-4759-8018-8ee562c159f0@app.fastmail.com>
 <CT1V90ZD4ZPZ.2J5QU7ZEYSB60@gonk>
 <20230602130028.yf4jagpqqmivhx77@alap3.anarazel.de>
In-Reply-To: <20230602130028.yf4jagpqqmivhx77@alap3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/CT26U28ECWTA.3VIVYB9J55L4K%40gonk>
Precedence: bulk

On Fri Jun 2, 2023 at 8:00 AM CDT, Andres Freund wrote:
> Hi,
>
> On 2023-06-01 23:06:04 -0500, Tristan Partin wrote:
> > In our case, we should add the ^line to src/backend/catalog/meson.build=
.
>
> src/backend is only reached well after src/include, due to needing
> dependencies on files generated in src/include.

I was worried about this :(.

> I wonder if we instead could just make perl output the files it loads and
> handle dependencies automatically that way? But that's more work, so it's
> probably the right thing to go for the manual path for now.

I am not familar with Perl enough (at all haha) to know if that is
possible. I don't know exactly what these Perl files do, but perhaps it
might make sense to have some global lookup table that is setup near the
beginning of the script.

perl_files =3D {
  'Catalog.pm': files('path/to/Catalog.pm'),
  ...
}

Otherwise, manual as it is in the original patch seems like an alright
compromise for now.

--=20
Tristan Partin
Neon (https://neon.tech)