Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 09 Jun 2023 12:58:31 -0500
Cc: <pgsql-hackers@postgresql.org>
Subject: Re: Use COPY for populating all pgbench tables
To: "Gurjeet Singh" <gurjeet@singh.im>, "Gregory Smith"
 <gregsmithpgsql@gmail.com>
From: "Tristan Partin" <tristan@neon.tech>
Message-Id: <CT8BC7RXT33R.3CHYIXGD5NVHK@gonk>
References: <CSTU5P82ONZ1.19XFUGHMXHBRY@c3po>
 <CAHLJuCW4gapAYZMc2vuy9mL2jdhNj3SLL9ef9U+stD=8EXfV=g@mail.gmail.com>
 <CABwTF4XMdHTxemhskad41Vj_hp2nPgifjwegOqR52_8-wEbv2Q@mail.gmail.com>
In-Reply-To: 
 <CABwTF4XMdHTxemhskad41Vj_hp2nPgifjwegOqR52_8-wEbv2Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/CT8BC7RXT33R.3CHYIXGD5NVHK%40gonk>
Precedence: bulk

On Fri Jun 9, 2023 at 12:25 PM CDT, Gurjeet Singh wrote:
> On Fri, Jun 9, 2023 at 6:24=E2=80=AFAM Gregory Smith <gregsmithpgsql@gmai=
l.com> wrote:
> >
> > Unfortunately there's no simple command line option to change just that=
 one thing about how pgbench runs.  You have to construct a command line th=
at documents each and every step you want instead.  You probably just want =
this form:
> >
> >     $ pgbench -i -I dtGvp -s 500
>
> The steps are severely under-documented in pgbench --help output.
> Grepping that output I could not find any explanation of these steps,
> so I dug through the code and found them in runInitSteps(). Just as I
> was thinking of writing a patch to remedy that, just to be sure, I
> checked online docs and sure enough, they are well-documented under
> pgbench [1].
>
> I think at least a pointer to the the pgbench docs should be mentioned
> in the pgbench --help output; an average user may not rush to read the
> code to find the explanation, but a hint to where to find more details
> about what the letters in --init-steps mean, would save them a lot of
> time.
>
> [1]: https://www.postgresql.org/docs/15/pgbench.html
>
> Best regards,
> Gurjeet
> http://Gurje.et

I think this would be nice to have if you wanted to submit a patch.

--=20
Tristan Partin
Neon (https://neon.tech)