Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 12 Jun 2023 16:43:29 -0500
To: "Peter Eisentraut" <peter@eisentraut.org>, "Andres Freund"
 <andres@anarazel.de>
From: "Tristan Partin" <tristan@neon.tech>
Cc: <pgsql-hackers@postgresql.org>
Subject: Re: Meson build updates
Message-Id: <CTB00342PAX7.36RK20RD57EUH@gonk>
References: <CSPIJVUDZFKX.3KHMOAVGF94RV@c3po>
 <20230609164135.77fjwqkqzdxfs3f5@awork3.anarazel.de>
 <CT8BP7BRV4A2.AOE7263UX2SH@gonk>
 <20230609183603.o56z3ngtak6qhb3s@awork3.anarazel.de>
 <CTATUZLNWYKO.2PMYWTUA85JUK@gonk>
 <20230612172038.f2xf2cwlnhjldqng@awork3.anarazel.de>
 <CTAW8GBWEJ7F.129Y59WDVDNMW@gonk>
 <277c356e-7ef7-4c87-f4b2-97a13914dd02@eisentraut.org>
In-Reply-To: <277c356e-7ef7-4c87-f4b2-97a13914dd02@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/CTB00342PAX7.36RK20RD57EUH%40gonk>
Precedence: bulk

On Mon Jun 12, 2023 at 4:24 PM CDT, Peter Eisentraut wrote:
> On 12.06.23 20:48, Tristan Partin wrote:
> > Attached you will find a v3 with the offending commits removed. I did
> > leave the overrides in since you didn't mention it in your last email.
>
> Patches 1-14 look ok to me.  (But I didn't test anything, so some=20
> caveats about whether the non-cosmetic patches actually work apply.)  If=
=20
> we're fine-tuning the capitalization the options descriptions, let's=20
> also turn "tap tests" into "TAP tests" and "TCL" into "Tcl".

I'll get to that.

> Patch 15 about the wrap integration, I'm not sure.  I share the concerns=
=20
> about whether this is worth maintaining.  Maybe put this patch into the=
=20
> commitfest separately, to allow for further study and testing.  (The=20
> other patches, if they are acceptable, ought to go into PG16, I think.)

Ok. I will split it off for further discussion. Expect a v4 tomorrow
with a few extra changes with regard to another review from a Meson
maintainer.

--=20
Tristan Partin
Neon (https://neon.tech)