Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9ANk-0008QI-8t for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Jun 2023 20:12:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q9ANj-0006ha-0M for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Jun 2023 20:12:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9ANi-0006ca-MO for pgsql-hackers@lists.postgresql.org; Tue, 13 Jun 2023 20:12:46 +0000 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q9ANb-002C5w-BD for pgsql-hackers@postgresql.org; Tue, 13 Jun 2023 20:12:45 +0000 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6b2b7ca1cb8so3702090a34.2 for ; Tue, 13 Jun 2023 13:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon-tech.20221208.gappssmtp.com; s=20221208; t=1686687157; x=1689279157; h=in-reply-to:references:to:subject:cc:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IDIGFLUPr/+p+Mthoj0h2LXgp6123t1/kmRUhM1vCDA=; b=QmxLPjcfRgQFSqtYUEFeQZWPGSFCAbGARAz66YsAGf4Z2Suda6pefXxPIHvf45aZLu EfppGt1tp6RN17K+BBl4ViCZIYYCZOIEsjmyJTZZOCEq7fJYYo1XNOI2Wd0mwcLdt9b0 tOyJfLrL7Imji95QC/XAGWbEKUD2cBNE50Iq+M0SwUjjKghDvCxciNlpgijct7y9yUdK PEMmKQlhB2H3TBpOzjyoS/v/i+pMP/TaDkrNJcoN+rzfqF+pdvx7VCOul87ysbbfe86F 9YNc+b/Rx1Lva8FMGjJLtlLvf+SaNWi3wcNnVvc71utEXJZxSpHFy5Gj+cR5jCwBpfhC J55g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686687157; x=1689279157; h=in-reply-to:references:to:subject:cc:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IDIGFLUPr/+p+Mthoj0h2LXgp6123t1/kmRUhM1vCDA=; b=VwmVlvZ1hbD9HvBR0GbbK28wOFHT2tVneVQat2j00mMFe6M/vp9HnSnM25chPbEl+n i2T7/oGFpwygnJIIkQ0G0P1svTegcbSx0Bvul280Dl03EOYCBk62Yr1F/6vG+JeOESas bfpq31WyfciwtfIEFY2gUuOPRKvp+iKSvI52yWwEs44KuHsGEYbqOzRJrG6jwBxQWvhG kLLQ4yf6R6MH+zDojMecOFUqT/oLQoVCgA80FGRTBQnUo6Ejv8IHzuwi7vFJxZnohQcD F7LTApHrSF+wgkfFOBDHnaWT1rjiBMaFMLGgFfcMalTndvuSWzbeE3Po//vxLlte3yqf RfCA== X-Gm-Message-State: AC+VfDwrmlY/VvuBvy75tAQpHW0+6NYZ7CVrEOgmpbSoIHle0gEFlq/F jyvHq0eqAg50euNnhFASKvM+wSx7d1lp1i1sMaI= X-Google-Smtp-Source: ACHHUZ6eV8FqDIaFDyUqHf7iyL4K7+N+E9cmsNqRm4wbj0TG44BwWonRByvP8gXSrADqB5EZYDydyA== X-Received: by 2002:a05:6830:1089:b0:6af:a42a:f362 with SMTP id y9-20020a056830108900b006afa42af362mr9955490oto.30.1686687157520; Tue, 13 Jun 2023 13:12:37 -0700 (PDT) Received: from localhost ([2607:fb90:e696:c1dc:3996:e070:71ee:42fb]) by smtp.gmail.com with ESMTPSA id a9-20020a9d74c9000000b006a43519523fsm5159448otl.1.2023.06.13.13.12.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 13:12:36 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 13 Jun 2023 15:12:35 -0500 Message-Id: From: "Tristan Partin" Cc: Subject: Re: Meson build updates To: "Tristan Partin" , "Peter Eisentraut" , "Andres Freund" X-Mailer: aerc 0.15.2-46-g263d8cbec504 References: <20230609164135.77fjwqkqzdxfs3f5@awork3.anarazel.de> <20230609183603.o56z3ngtak6qhb3s@awork3.anarazel.de> <20230612172038.f2xf2cwlnhjldqng@awork3.anarazel.de> <277c356e-7ef7-4c87-f4b2-97a13914dd02@eisentraut.org> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon Jun 12, 2023 at 4:43 PM CDT, Tristan Partin wrote: > On Mon Jun 12, 2023 at 4:24 PM CDT, Peter Eisentraut wrote: > > On 12.06.23 20:48, Tristan Partin wrote: > > > Attached you will find a v3 with the offending commits removed. I did > > > leave the overrides in since you didn't mention it in your last email= . > > > > Patches 1-14 look ok to me. (But I didn't test anything, so some=20 > > caveats about whether the non-cosmetic patches actually work apply.) I= f=20 > > we're fine-tuning the capitalization the options descriptions, let's=20 > > also turn "tap tests" into "TAP tests" and "TCL" into "Tcl". > > I'll get to that. Done. > > Patch 15 about the wrap integration, I'm not sure. I share the concern= s=20 > > about whether this is worth maintaining. Maybe put this patch into the= =20 > > commitfest separately, to allow for further study and testing. (The=20 > > other patches, if they are acceptable, ought to go into PG16, I think.) > > Ok. I will split it off for further discussion. Expect a v4 tomorrow > with a few extra changes with regard to another review from a Meson > maintainer. Attached. I did have an idea to help with repetitive build descriptions in: https://www.postgresql.org/message-id/CTBSCT2V1TVP.2AUJVJLNWQVG3%40gonk. I kind of want to see Andres' response, before this gets merged. But that could also be a follow on commit if he likes the idea. I'll leave it up to you to decide. --=20 Tristan Partin Neon (https://neon.tech)